From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D92D3E77188 for ; Tue, 14 Jan 2025 19:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ES4PfYVi7ZyhgRUm9GYH+FMCnEy4+AUcUAHWe5oV5jA=; b=p1wanNvC722a/d34gEUkxVVOTv QT+4uR7riQ7MCKqIRVE6hpRu3inl7tARI9HKijwOfS9D8ysOtQsxdGgRHsK7K8B6YTndrKDeJLVu8 Cy/N2BEVnFv+Jh2FORrwQ7+TP8ZQGbz6lJhDUi1a+uCpnF3XzTqQKZe+BfGTuVdu0lyO4kxWiJ34B WJBnWoDDh47aZwqoiTi01NHzGdpNUk4dxx6k1KO0rQ8e3C6P+WA8HeqMeeT35vuaLAxzrLK/WJNO1 KGtzzkD4REBMIkEOUyk+eCKnUgpJYUEyaczhEbOSoC+OlgowIQT8OUxbpnW2qdsoCjvFfqyOiwHMf APP+pKUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tXme2-00000009Y5X-3ACO; Tue, 14 Jan 2025 19:32:10 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tXmZk-00000009XPN-3tVT for linux-arm-kernel@bombadil.infradead.org; Tue, 14 Jan 2025 19:27:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=ES4PfYVi7ZyhgRUm9GYH+FMCnEy4+AUcUAHWe5oV5jA=; b=HmvJxjwEU/xspRhsK5Df36KL61 rak8pSe4P0gDcNJAmOa2L7SHM6HJSQa35d191cyvJuHDpnS7cClTL6n8jnc45IlL6BE63CyZdgGhn 4W9XRuVqZZx8TdxiflgzvRsNDhIxaSKPVfegWJ9Y/RqpemQIrJVJJlzPQfd1i2Se+KDxafswhZJB3 lzzkEf2xHYi8oYGrhzGfykfanTdreXnj7/QsNQeeYZvuSCJEqVGwP44HUwm0AHsy57pGYZgbqsBkn ynFXnSIIPmD1WDhvXAcqlNfaozs8vNNMqyoyWMYkHZR/7I1/b1EyGwL0xww4xXb4uAzLKZW7hb7nu iJ1BOvoA==; Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tXmZf-0000000Aa8B-3isa for linux-arm-kernel@lists.infradead.org; Tue, 14 Jan 2025 19:27:43 +0000 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-218c8aca5f1so127177325ad.0 for ; Tue, 14 Jan 2025 11:27:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1736882857; x=1737487657; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ES4PfYVi7ZyhgRUm9GYH+FMCnEy4+AUcUAHWe5oV5jA=; b=V/JM1qwzn62BqvpvP4waV3zfslLKf0wDq/W46N8LhLwDn/ujpVMq2sqXCeAUZBLTpm yRVmqRtfVX8jOnbmA/hNYvdt61XefOvo6BJpL17wengxbUc9/B1edd0JPkfA0igvXMyU PiCdf1ejvBw/auCeJ5eMOlAJw9j3bpOfGi+p3VBBDzdUs8a5EqW8j83fA9sd4LX53clA 9nV8BPHu4ozNUBzkCnvut0DFXFRdw001kgRsknJ4EWxtGXTbgGmy/ynJGazebAs3gzCh 7EkDJYlMESzz+AWTsRyJpOCkb+ARKDi9lFuRfwq415URFqinTCbomP8OvLxupHuO33cq ihKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736882857; x=1737487657; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ES4PfYVi7ZyhgRUm9GYH+FMCnEy4+AUcUAHWe5oV5jA=; b=rI9AGgasmMaUQ8D2xqAbROo3A5QjZQEn4neyq+rYouOxUWIVdNhUZX2uXb12VjRLvU V9svcjkBKBXpzQ8e1bnT7ZcuYLi3rPQ0Kgcu5gr6R1Zv0YTFSWFDnULsbcixRktRsBN0 2QEGUZZZMa5aVbusns4NawP8NNyDEqMEPCxs1jl7TLfFrSOj8QV5bug9yAO1bP3SRxla hsyY+GH5dSi8fnAOJWNwUeP17dwDRyaG9l6IJYT2VmEv0DRRvfD9hEyV1CGLhCn9NdXT UB1aTVRDSFBXu7z7gDI66Bj9I9n+Ot3xJHaaYK+yCadq6YFBHtBZT8Nv3vGkRh+88kNa C6Kw== X-Forwarded-Encrypted: i=1; AJvYcCVJ7ufUvEiL9O2R8lxqyEDpVdQ7NKFhd3A+sAhzVhMf0NxLf4hkrivtOo2tYHOOMQHKAFlxXgnrV0qqaZdyRhNb@lists.infradead.org X-Gm-Message-State: AOJu0Yz0cs4J4jByLQWekoiPRGUZGwx1nY059DXMc/D2OFK3BlLXU+lD yJi5wCySDBXps4Wpr7kSoyQAQv2IxH5t2xhM9r+caRbGQwjvHE4r7hEGzWSRZw3tXWnu8FFWFUS 5 X-Gm-Gg: ASbGncuXj+IGZwvroyGtFbKLGwbiHYJTZNw5nZEHu55dmT5Sd2g+gw54qCtD8OrrKIK stfvQn9T/q7e1UGpkcCq7MxSx2XzunnUFNP3Hq9imirRZoHgzKKi13bWk/ve2UzKkugO3rUo6L0 4XE7SyVE3W19HyBHfrNUeYXZ7pC0kFr/5S3YKrLQOnwa0r96m7nTVvlK5yIOGakkuvzGQ4D2cMw zfjnQ6OMMrtFcrCw7VnmLglw2oNZtR3K8hq0RCGc40PLIbnh7au X-Google-Smtp-Source: AGHT+IHNba0GEbibje0t5wLZKfmTow6LQxoYMbmUndt+PVUCx5IeqgXnaaRg1lp0Qu+9TDj1PY7X3A== X-Received: by 2002:a17:902:d4cd:b0:216:3c2b:a5e5 with SMTP id d9443c01a7336-21a83f71115mr361190955ad.27.1736882856927; Tue, 14 Jan 2025 11:27:36 -0800 (PST) Received: from ghost ([2601:647:6700:64d0:c3be:2c11:1223:572a]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f10e006sm70578375ad.1.2025.01.14.11.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2025 11:27:34 -0800 (PST) Date: Tue, 14 Jan 2025 11:27:30 -0800 From: Charlie Jenkins To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Paul Walmsley , Palmer Dabbelt , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , =?iso-8859-1?Q?G=FCnther?= Noack , Christian Brauner , Guo Ren , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Jonathan Corbet , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, bpf@vger.kernel.org, linux-csky@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v6 00/16] perf tools: Use generic syscall scripts for all archs Message-ID: References: <20250108-perf_syscalltbl-v6-0-7543b5293098@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250114_192740_219137_94373A0B X-CRM114-Status: GOOD ( 41.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 14, 2025 at 02:58:26PM -0300, Arnaldo Carvalho de Melo wrote: > On Mon, Jan 13, 2025 at 11:55:05AM -0300, Arnaldo Carvalho de Melo wrote: > > On Fri, Jan 10, 2025 at 11:31:01AM -0800, Charlie Jenkins wrote: > > > On Thu, Jan 09, 2025 at 03:00:59PM -0800, Charlie Jenkins wrote: > > > > Ooh okay I see, the quiet commands were being ignored as-is. We could > > > > add the lines to handle this to Makefile.syscalls, but I think the > > > > better solution is to move the lines from Makefile.build to > > > > Makefile.perf to be more generically available. Here is a patch for > > > > that. I also added the comment from the kernel Makefile describing what > > > > this does. > > > > > > From 8dcec7f5d937ede3d33c687573dc2f1654ddc59e Mon Sep 17 00:00:00 2001 > > > > From: Charlie Jenkins > > > > Date: Thu, 9 Jan 2025 14:36:40 -0800 > > > > Subject: [PATCH] perf tools: Expose quiet/verbose variables in Makefile.perf > > > > > > > > The variables to make builds silent/verbose live inside > > > > tools/build/Makefile.build. Move those variables to the top-level > > > > Makefile.perf to be generally available. > > > > > > > > > Let me know how you want to handle this, I can send this out as a > > > separate patch if that's better. > > > > I used the patch you provided above after hand editing the message > > before feeding it to 'git am', added these comments: > > Somehow this is causing some trouble: > > ⬢ [acme@toolbox perf-tools-next]$ make -C tools/perf build-test > make: Entering directory '/home/acme/git/perf-tools-next/tools/perf' > - tarpkg: ./tests/perf-targz-src-pkg . > /bin/sh: line 1: @make: command not found > make[4]: *** [Makefile:27: clean-asm_pure_loop] Error 127 > make[3]: *** [Makefile.perf:764: tests-coresight-targets-clean] Error 2 > make[2]: *** [Makefile:96: clean] Error 2 > make[1]: *** [tests/make:330: make_static] Error 2 > make: *** [Makefile:109: build-test] Error 2 > make: Leaving directory '/home/acme/git/perf-tools-next/tools/perf' > ⬢ [acme@toolbox perf-tools-next]$ > > Can you please try fixing it as I'm busy now (I'll be on vacation from > tomorrow till early February)? This is what I extracted: There was an erroneous $(Q) in tools/perf/tests/shell/coresight/Makefile. Previously it would expand to the empty string so wouldn't cause any problems, but now it's in the middle of an expression so hence the error. I'll send an updated patch. > > commit c199fd785d18121ffd0ba5758e23a42ba2984e11 > Author: Charlie Jenkins > Date: Mon Jan 13 11:50:55 2025 -0300 > > perf tools: Expose quiet/verbose variables in Makefile.perf > > The variables to make builds silent/verbose live inside > tools/build/Makefile.build. Move those variables to the top-level > Makefile.perf to be generally available. > > Committer testing: > > See the SYSCALL lines, now they are consistent with the other > operations in other lines: > > SYSTBL /tmp/build/perf-tools-next/arch/x86/include/generated/asm/syscalls_32.h > SYSTBL /tmp/build/perf-tools-next/arch/x86/include/generated/asm/syscalls_64.h > GEN /tmp/build/perf-tools-next/common-cmds.h > GEN /tmp/build/perf-tools-next/arch/arm64/include/generated/asm/sysreg-defs.h > PERF_VERSION = 6.13.rc2.g3d94bb6ed1d0 > GEN perf-archive > MKDIR /tmp/build/perf-tools-next/jvmti/ > MKDIR /tmp/build/perf-tools-next/jvmti/ > MKDIR /tmp/build/perf-tools-next/jvmti/ > MKDIR /tmp/build/perf-tools-next/jvmti/ > GEN perf-iostat > CC /tmp/build/perf-tools-next/jvmti/libjvmti.o > CC /tmp/build/perf-tools-next/jvmti/jvmti_agent.o > > Reported-by: Arnaldo Carvalho de Melo > Signed-off-by: Charlie Jenkins > Tested-by: Arnaldo Carvalho de Melo > Cc: Adrian Hunter > Cc: Alexander Shishkin > Cc: Arnd Bergmann > Cc: Christian Brauner > Cc: Guo Ren > Cc: Günther Noack > Cc: Ian Rogers > Cc: Ingo Molnar > Cc: James Clark > Cc: Jiri Olsa > Cc: John Garry > Cc: Jonathan Corbet > Cc: Leo Yan > Cc: Mark Rutland > Cc: Mickaël Salaün > Cc: Mike Leach > Cc: Namhyung Kim > Cc: Palmer Dabbelt > Cc: Paul Walmsley > Cc: Peter Zijlstra > Cc: Will Deacon > Link: http://lore.kernel.org/lkml/None > Signed-off-by: Arnaldo Carvalho de Melo > > diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build > index 5fb3fb3d97e0fd11..e710ed67a1b49d9f 100644 > --- a/tools/build/Makefile.build > +++ b/tools/build/Makefile.build > @@ -12,26 +12,6 @@ > PHONY := __build > __build: > > -ifeq ($(V),1) > - quiet = > - Q = > -else > - quiet=quiet_ > - Q=@ > -endif > - > -# If the user is running make -s (silent mode), suppress echoing of commands > -# make-4.0 (and later) keep single letter options in the 1st word of MAKEFLAGS. > -ifeq ($(filter 3.%,$(MAKE_VERSION)),) > -short-opts := $(firstword -$(MAKEFLAGS)) > -else > -short-opts := $(filter-out --%,$(MAKEFLAGS)) > -endif > - > -ifneq ($(findstring s,$(short-opts)),) > - quiet=silent_ > -endif > - > build-dir := $(srctree)/tools/build > > # Define $(fixdep) for dep-cmd function > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index a449d00155364422..55d6ce9ea52fb2a5 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -161,12 +161,47 @@ export VPATH > SOURCE := $(shell ln -sf $(srctree)/tools/perf $(OUTPUT)/source) > endif > > +# Beautify output > +# --------------------------------------------------------------------------- > +# > +# Most of build commands in Kbuild start with "cmd_". You can optionally define > +# "quiet_cmd_*". If defined, the short log is printed. Otherwise, no log from > +# that command is printed by default. > +# > +# e.g.) > +# quiet_cmd_depmod = DEPMOD $(MODLIB) > +# cmd_depmod = $(srctree)/scripts/depmod.sh $(DEPMOD) $(KERNELRELEASE) > +# > +# A simple variant is to prefix commands with $(Q) - that's useful > +# for commands that shall be hidden in non-verbose mode. > +# > +# $(Q)$(MAKE) $(build)=scripts/basic > +# > +# To put more focus on warnings, be less verbose as default > +# Use 'make V=1' to see the full commands > + > ifeq ($(V),1) > + quiet = > Q = > else > - Q = @ > + quiet=quiet_ > + Q=@ > endif > > +# If the user is running make -s (silent mode), suppress echoing of commands > +# make-4.0 (and later) keep single letter options in the 1st word of MAKEFLAGS. > +ifeq ($(filter 3.%,$(MAKE_VERSION)),) > +short-opts := $(firstword -$(MAKEFLAGS)) > +else > +short-opts := $(filter-out --%,$(MAKEFLAGS)) > +endif > + > +ifneq ($(findstring s,$(short-opts)),) > + quiet=silent_ > +endif > + > +export quiet Q > + > # Do not use make's built-in rules > # (this improves performance and avoids hard-to-debug behaviour); > MAKEFLAGS += -r