From: Pranjal Shrivastava <praan@google.com>
To: Robert Marko <robert.marko@sartura.hr>
Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
jgg@ziepe.ca, nicolinc@nvidia.com,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, luka.perkov@sartura.hr,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iommu/arm-smmu-v3: add missing header
Date: Thu, 16 Jan 2025 03:09:13 +0000 [thread overview]
Message-ID: <Z4h4WePiB7G0BZj-@google.com> (raw)
In-Reply-To: <20250114160630.1122885-1-robert.marko@sartura.hr>
On Tue, Jan 14, 2025 at 05:05:56PM +0100, Robert Marko wrote:
> str_read_write is currently undeclared and thus compilation will fail with:
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:1911:25: error: implicit declaration of function ‘str_read_write’; did you mean ‘sb_end_write’? [-Wimplicit-function-declaration]
>
> So include the missing linux/string_choices.h header to fix compilation.
>
> Fixes: f2c77f6e41e6 ("iommu/arm-smmu-v3: Use str_read_write helper w/ logs")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202501111926.qOpnlK9J-lkp@intel.com/
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> index 0e4cbb2c64d7..a0e395da8a88 100644
> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> @@ -26,6 +26,7 @@
> #include <linux/pci.h>
> #include <linux/pci-ats.h>
> #include <linux/platform_device.h>
> +#include <linux/string_choices.h>
> #include <kunit/visibility.h>
> #include <uapi/linux/iommufd.h>
Hi Robert,
This fix has already been merged to the arm/smmu/updates branch [1]
which should appear in -next when Joerg next rebuilds the branch.
Thanks,
Praan
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/iommu/linux.git/commit/?h=arm/smmu/updates
>
> --
> 2.47.1
>
>
next prev parent reply other threads:[~2025-01-16 3:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 16:05 [PATCH] iommu/arm-smmu-v3: add missing header Robert Marko
2025-01-16 3:09 ` Pranjal Shrivastava [this message]
2025-01-16 9:13 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4h4WePiB7G0BZj-@google.com \
--to=praan@google.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luka.perkov@sartura.hr \
--cc=nicolinc@nvidia.com \
--cc=robert.marko@sartura.hr \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).