From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Yuntao Liu <liuyuntao12@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, ruanjinjie@huawei.com,
kees@kernel.org, masahiroy@kernel.org, ardb@kernel.org
Subject: Re: [PATCH -next] arm32/boot/compressed: Force hidden visibility for all symbol references
Date: Fri, 24 Jan 2025 15:25:53 +0000 [thread overview]
Message-ID: <Z5OxAfyKq-d7YPSp@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250124082030.764417-1-liuyuntao12@huawei.com>
On Fri, Jan 24, 2025 at 08:20:30AM +0000, Yuntao Liu wrote:
> Eliminate all GOT entries in the decompressor binary, by forcing hidden
> visibility for all symbol references, which informs the compiler that
> such references will be resolved at link time without the need for
> allocating GOT entries.
One question. Why.
I don't think this is desirable. We don't want the linker to fully
resolve references at link time - we specifically want a GOT so that
at run time the decompressor can resolve the references irrespective
of where the decompressor is loaded - in other words, allowing the
decompressor to be loaded anywhere in memory.
We do not link the decompressor for any specific address, and thus
the only way the decompressor can work is by fixing up the GOT.
Unless you can demonstrate that the GOT is no longer required, then
based on your commit description... hard NAK.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2025-01-24 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 8:20 [PATCH -next] arm32/boot/compressed: Force hidden visibility for all symbol references Yuntao Liu
2025-01-24 14:00 ` Ard Biesheuvel
2025-01-24 15:32 ` Russell King (Oracle)
2025-01-24 15:25 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5OxAfyKq-d7YPSp@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ardb@kernel.org \
--cc=kees@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyuntao12@huawei.com \
--cc=masahiroy@kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).