From: Vinod Koul <vkoul@kernel.org>
To: Christian Bruel <christian.bruel@foss.st.com>
Cc: kishon@kernel.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@foss.st.com, arnd@arndb.de,
fabrice.gasnier@foss.st.com, linux-phy@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Fixes: 2de679ecd724 ("phy: stm32: work around constant-value overflow assertion")
Date: Fri, 14 Feb 2025 18:23:14 +0530 [thread overview]
Message-ID: <Z688unKfcSeFE5X/@vaman> (raw)
In-Reply-To: <20250117140514.3614314-1-christian.bruel@foss.st.com>
On 17-01-25, 15:05, Christian Bruel wrote:
> This patch replaces the workaround with fixes for two issues leading to
> constant-value overflow assertion:
>
> - Guard against false positives with a WARN_ON check to make the compiler
> happy: This should not happen because the offset range is checked against
> the sorted imp_lookup_table values.
>
> - Guard against a true warning found for the max_vswing, as a given
> vswing value can be 802000 or 803000 depending on the current impedance
Patch looks fine, the fixes line should go here and subject needs
revision
--
~Vinod
next prev parent reply other threads:[~2025-02-14 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 14:05 [PATCH] Fixes: 2de679ecd724 ("phy: stm32: work around constant-value overflow assertion") Christian Bruel
2025-02-14 12:53 ` Vinod Koul [this message]
2025-02-14 14:44 ` Christian Bruel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z688unKfcSeFE5X/@vaman \
--to=vkoul@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=arnd@arndb.de \
--cc=christian.bruel@foss.st.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).