From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6628CC83F2C for ; Mon, 4 Sep 2023 20:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Cc:To :Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tucHJjsIvnDt49OC0j7wQCTdzqLEyJn8SUlDA/TpRcw=; b=MXp1RB+EhuJOP8l8f9RfxchvbL 6b/f8z43aVOusrB67lZFcvuNa1iOz6iGQ7wlW8YlqnGr0FNBOz1TustFXT09FTe+lYp/3KSo8v4xB 7HsKvI4LxUIwuRTrIX5FHhTDbDmc8K5LeqcySKtN4NYOew4oI4MnwqXLuKgyIB/tp5Xfl4rAbD8HU Lwysfxu/TLG7q/qINzR2lwMb+78wP3M07NvA0Gxz46b5Cznn4sK2Rgefa1baoZ3f0Y47yJcJC3xmB AYoXm/iUCceM3hf2spkd1gZ9PVBFJnvgH7Yo9XHyq2qU0dokJCrkTtjEoXWKBmK7his1VVSRo8TFU w7v/RgEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdFqV-004jcU-36; Mon, 04 Sep 2023 20:06:51 +0000 Received: from relay07.th.seeweb.it ([5.144.164.168]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdFqS-004jc6-0x for linux-arm-kernel@lists.infradead.org; Mon, 04 Sep 2023 20:06:49 +0000 Received: from [192.168.2.144] (bband-dyn191.178-41-225.t-com.sk [178.41.225.191]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id C2BF03F261; Mon, 4 Sep 2023 22:06:41 +0200 (CEST) Date: Mon, 04 Sep 2023 22:06:35 +0200 From: Martin Botka Subject: Re: [PATCH 3/6] dt-bindings: opp: Add compatible for H616 To: Krzysztof Kozlowski Cc: Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , "Rafael J. Wysocki" , Viresh Kumar , Yangtao Li , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, Andre Przywara , Alan Ma , Luke Harrison , Marijn Suijten , AngeloGioacchino Del Regno , Konrad Dybcio , Rogerio Goncalves , Martin Botka Message-Id: In-Reply-To: <6e4cd0a1-43d0-e2e8-7281-e20ae653eae6@linaro.org> References: <20230904-cpufreq-h616-v1-0-b8842e525c43@somainline.org> <20230904-cpufreq-h616-v1-3-b8842e525c43@somainline.org> <2C8H0S.90380B1U7TPP3@somainline.org> <6e4cd0a1-43d0-e2e8-7281-e20ae653eae6@linaro.org> X-Mailer: geary/43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230904_130648_496965_0F488971 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 4 2023 at 09:53:05 PM +02:00:00, Krzysztof Kozlowski wrote: > On 04/09/2023 21:48, Martin Botka wrote: >> >> >> On Mon, Sep 4 2023 at 09:32:44 PM +02:00:00, Krzysztof Kozlowski >> wrote: >>> On 04/09/2023 21:31, Krzysztof Kozlowski wrote: >>>> On 04/09/2023 17:57, Martin Botka wrote: >>>>> We need to add compatible for H616 to H6 cpufreq driver >>>>> bindings. >>>> >>>> Please describe the hardware, not what is needed for drivers. >>>> >>>>> >>>>> Also enable opp_supported_hw property that will be needed for >>>>> H616. >>>>> >>>>> Signed-off-by: Martin Botka >>>>> --- >>>>> .../bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>>> | 6 +++++- >>>>> 1 file changed, 5 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git >>>>> >>>>> a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>>> >>>>> b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>>> index 51f62c3ae194..2fa1199f2d23 100644 >>>>> --- >>>>> >>>>> a/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>>> +++ >>>>> >>>>> b/Documentation/devicetree/bindings/opp/allwinner,sun50i-h6-operating-points.yaml >>>>> @@ -23,7 +23,10 @@ allOf: >>>>> >>>>> properties: >>>>> compatible: >>>>> - const: allwinner,sun50i-h6-operating-points >>>>> + contains: >>>> >>>> This does not look like part of allOf, so contains is no correct >>>> here. >>>> This must be specific, so drop contains. >>> >>> BTW, I also do no see it used by the driver at all. >> Function sun50i_cpufreq_get_efuse uses it. It checks for H6 >> compatible >> and if that fails we check for H616 compatible. > > Such code does no scale. It also does not look reasonable - you cannot > have different compatible there. Device binds to h6 or h616, so you > cannot have OPP table from other devices. > Heya. I checked how qcom nvmem driver does it. And yea this indeed does not scale. matchlist should have SoC compatible and driver needs to have single compatible. Thus also dropping this patch :) Will do in V2. Thanks Krzystof for pointing me to the right way of doing it :) Cheers, Martin > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel