Re: [PATCH FOR-NEXT] perf tools: Expose quiet/verbose variables in Makefile.perf

[Namhyung Kim <namhyung@kernel.org>]

Hello,

On Mon, Feb 03, 2025 at 10:56:48AM -0800, Charlie Jenkins wrote:
> On Mon, Feb 03, 2025 at 10:29:39AM +0100, Jiri Olsa wrote:
> > On Tue, Jan 14, 2025 at 11:35:44AM -0800, Charlie Jenkins wrote:
> > > The variables to make builds silent/verbose live inside
> > > tools/build/Makefile.build. Move those variables to the top-level
> > > Makefile.perf to be generally available.
> > > 
> > > Committer testing:
> > > 
> > > See the SYSCALL lines, now they are consistent with the other
> > > operations in other lines:
> > >   SYSTBL  /tmp/build/perf-tools-next/arch/x86/include/generated/asm/syscalls_32.h
> > >   SYSTBL  /tmp/build/perf-tools-next/arch/x86/include/generated/asm/syscalls_64.h
> > >   GEN     /tmp/build/perf-tools-next/common-cmds.h
> > >   GEN     /tmp/build/perf-tools-next/arch/arm64/include/generated/asm/sysreg-defs.h
> > >   PERF_VERSION = 6.13.rc2.g3d94bb6ed1d0
> > >   GEN     perf-archive
> > >   MKDIR   /tmp/build/perf-tools-next/jvmti/
> > >   MKDIR   /tmp/build/perf-tools-next/jvmti/
> > >   MKDIR   /tmp/build/perf-tools-next/jvmti/
> > >   MKDIR   /tmp/build/perf-tools-next/jvmti/
> > >   GEN     perf-iostat
> > >   CC      /tmp/build/perf-tools-next/jvmti/libjvmti.o
> > > 
> > > Reported-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> > > Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > > ---
> > >  tools/build/Makefile.build                | 20 -----------------
> > >  tools/perf/Makefile.perf                  | 37 ++++++++++++++++++++++++++++++-
> > >  tools/perf/tests/shell/coresight/Makefile |  2 +-
> > >  3 files changed, 37 insertions(+), 22 deletions(-)
> > > 
> > > diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> > > index 5fb3fb3d97e0fd114e245805809e4fc926b4343e..e710ed67a1b49d9fda11db02821bbd8d36066b44 100644
> > > --- a/tools/build/Makefile.build
> > > +++ b/tools/build/Makefile.build
> > > @@ -12,26 +12,6 @@
> > >  PHONY := __build
> > >  __build:
> > >  
> > > -ifeq ($(V),1)
> > > -  quiet =
> > > -  Q =
> > > -else
> > > -  quiet=quiet_
> > > -  Q=@
> > > -endif
> > > -
> > > -# If the user is running make -s (silent mode), suppress echoing of commands
> > > -# make-4.0 (and later) keep single letter options in the 1st word of MAKEFLAGS.
> > > -ifeq ($(filter 3.%,$(MAKE_VERSION)),)
> > > -short-opts := $(firstword -$(MAKEFLAGS))
> > > -else
> > > -short-opts := $(filter-out --%,$(MAKEFLAGS))
> > > -endif
> > > -
> > > -ifneq ($(findstring s,$(short-opts)),)
> > > -  quiet=silent_
> > > -endif
> > > -
> > >  build-dir := $(srctree)/tools/build
> > 
> > hi,
> > if we move this out of here, we need to fix other tools that rely on that,
> > bpftool and resolve_btfids do not build quietly now

Sorry about the trouble.  I should've checked other builds.

> > 
> > but not sure what was the reason of moving it out, the code in Makefile.perf
> > seems same as the one above
> 
> perf/Makefile.syscalls wanted to support quiet building. Makefile.perf
> imports both Makefile.syscalls and Makefile.build, so I moved this quiet
> infrastructure into Makefile.perf so that both of these files could use
> it.
> 
> I was trying to move the quiet infrastructure higher up in the callchain
> so that the code did not need to be duplicated. Perhaps it is better to
> move this into a separate file that exports "quiet" and "Q" and then can
> be imported from bpf/Makefile, perf/Makefile.perf, and any other tool
> that wants to have quiet builds?

Makes sense.  Can you please send a patch for that?

Thanks,
Namhyung