public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: William Breathitt Gray <wbg@kernel.org>
To: "Bence Csókás" <csokas.bence@prolan.hu>
Cc: linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Kamel Bouhara <kamel.bouhara@bootlin.com>
Subject: Re: [PATCH v2 1/2] counter: microchip-tcb-capture: Add IRQ handling
Date: Wed, 5 Feb 2025 09:00:43 +0900	[thread overview]
Message-ID: <Z6KqKz3YDQypxgok@ishi> (raw)
In-Reply-To: <20250203162955.102559-1-csokas.bence@prolan.hu>

[-- Attachment #1: Type: text/plain, Size: 822 bytes --]

On Mon, Feb 03, 2025 at 05:29:52PM +0100, Bence Csókás wrote:
> Add interrupt servicing to allow userspace to wait for a trigger event.
> 
> Signed-off-by: Bence Csókás <csokas.bence@prolan.hu>

Hi Bence,

Thank you for the patches. When you submit the next revision, please
include a cover letter as that will make it easier for us to separate
high-level discussions about the entire patchset from any individual
patch in particular.

Regarding this particular patch, update the description to mention the
specific types of events supported by this (i.e. Change-of-state and
Overflow events). Even though you expose the capture data in a
subsequent patch, you can push the Capture events in this patch so that
we introduce all the supported interrupt events at once.

Thanks,

William Breathitt Gray

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      parent reply	other threads:[~2025-02-05  0:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-03 16:29 [PATCH v2 1/2] counter: microchip-tcb-capture: Add IRQ handling Bence Csókás
2025-02-03 16:29 ` [PATCH v2 2/2] counter: microchip-tcb-capture: Add capture extensions for registers RA-RC Bence Csókás
2025-02-05  0:11   ` William Breathitt Gray
2025-02-05  8:57     ` Csókás Bence
2025-02-05  0:00 ` William Breathitt Gray [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6KqKz3YDQypxgok@ishi \
    --to=wbg@kernel.org \
    --cc=csokas.bence@prolan.hu \
    --cc=kamel.bouhara@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox