From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CA46C02196 for ; Wed, 5 Feb 2025 20:56:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XTbIzhwV3ZjAl5OwLbJohLrJDizqbdTCfNzNYP89Ar4=; b=r6XXD/olU43U7rJp0QPehyFKlq vdb4D6aWLdkzEZdH0lym/Tsyd9QGQrgfWtu4lfNFVQA2SqMpGBI08v7qIyLxrVMVBoqCcpIiWGNLy eCPZCcb3n0u8yj6yorPN9t2i9CzsePWjX3vPRh+pyF2PCQjZci7RbQuAkdBm2I+M4zOYFFzBBUTfv gzg/fBXsbtKdYvR6tpUajXpsBNOVVOj0T024hN5eZodGcEPOMb6d15jo++6bBu1/8UJTIzpHOwX/5 GCCQfDAfx9EYuDZN39dlthObzRVLUcFIznApl1H44rlObLJvf0ybv2XTlwwogEo0nMWOvbCLyJ8uc uwSCCt2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfmR7-00000004aw9-2Azm; Wed, 05 Feb 2025 20:55:53 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfmPj-00000004aa1-3HMb for linux-arm-kernel@lists.infradead.org; Wed, 05 Feb 2025 20:54:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738788856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XTbIzhwV3ZjAl5OwLbJohLrJDizqbdTCfNzNYP89Ar4=; b=fHmNQM1oyFFSySK2+/DYfXGugYKHEpzgMOuMdljQyM8hEY9ghzmzmS1qHWzeR10ON9nZVJ 3BKfEZfqfIT7WIaVikz68ULhAucnV9QTnk5ASMVD4MwaDYXnBZgh+vohnAZIUsG5jWC6f0 B3u8WzgSncn9GJJY4r21Xo8f22JN5fo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-187-6-oT6DyRMTig58v7DgXcNQ-1; Wed, 05 Feb 2025 15:52:17 -0500 X-MC-Unique: 6-oT6DyRMTig58v7DgXcNQ-1 X-Mimecast-MFC-AGG-ID: 6-oT6DyRMTig58v7DgXcNQ Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38dafe1699cso84037f8f.3 for ; Wed, 05 Feb 2025 12:52:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738788736; x=1739393536; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XTbIzhwV3ZjAl5OwLbJohLrJDizqbdTCfNzNYP89Ar4=; b=IGT1iJgcshlr44acIYp02XH7QLz/y6UMC2al2Yj26SP08jFkc4JeCuU/m7S33A11hP DzFL7KFT7ujsT6svm2GT6L7FTDP4ZkZZhQAeHIRK/u19WW6P3TwzyEXFgbu/t9NVu9r6 arKhRmu1zJS4HUO88fnAXHq1U92n47MH3X8mhI9ZPKYTvOHBjMFpHjGrnkJWVj+2Vm/4 uA+FDBBBfCu7XjHirNQeNC4G2GKIx+jwOzNfyfN1/LxK6ERZ3Y2ZtqpqvoSV3eaaQ71x JnletSEzmdPqN506yX6pGuHR4muOG7uuGkMcApgriuzQkEUMVfARNN2mnr/BDWw8ZU6m ruMw== X-Forwarded-Encrypted: i=1; AJvYcCXcYVgmF7CAOZUyvu+cRci5dB41o/USs6/kDkkTNssR1bW7KeQSmVMwSmkTKw0N4+Oi6G0NSYgF7Iy2tT0eX+CY@lists.infradead.org X-Gm-Message-State: AOJu0Yw9f9VB0bdbfO1+BrgCIRXTsoh+6fgCFY4FeqzUn2nEn6QpY1b/ 8qsTv1h+izfex29kbplXrIlk1cjkbhRQ5GQu3a0ws7MiTxS2qoZpvc/HJKHfhIVvWD9C0mG1sv6 CYXz1+9a2wJxwMc6rbaP8OJexe/UIXG8m7IplTreNhp5LFqwBEVCXQxsWj4G0bwPlEYehPNuR X-Gm-Gg: ASbGnctaaqn8vBmpigssyLF/30Mc3qDqsaA0h7RoK88ctexlY52dPDe2j2kUZmz+BIW DTSG33WXfAtRy+QFl3yKXDXsMKKmt7E6X1uA8lHnQ5KgpHYYmi6HdUvmVibNOLZlq0TzB0IO9eR zq3JWTEXC2S87eXIwyYzYMNTErcgWzJK4ZHxbmLUqKK8SdpTIY7nWF4yYAny3yILbSuVc7L7H8P Gv2RzljjiMcdR1Qe0iVge6u21SByU9r7bclSJA8QgZ5Nl4NdrRb2I2eHetmZ4GnJvAqB+aZijSe 06P9QOTxIyedGBY2d9Rsr8N0lRKL3lZOT+JMR1IVimYnIvlgkBlk X-Received: by 2002:a5d:47cb:0:b0:38d:adcd:a083 with SMTP id ffacd0b85a97d-38db49004bamr3522245f8f.42.1738788736425; Wed, 05 Feb 2025 12:52:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IFM8eo/awV4xrN7DNOWWlAj/RbtCWXcBZTqZRKq5/GMKRr+GILL69JKkMFHkF5J39xi9HCwvA== X-Received: by 2002:a5d:47cb:0:b0:38d:adcd:a083 with SMTP id ffacd0b85a97d-38db49004bamr3522229f8f.42.1738788735924; Wed, 05 Feb 2025 12:52:15 -0800 (PST) Received: from localhost (net-93-146-37-148.cust.vodafonedsl.it. [93.146.37.148]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c102f7dsm20073668f8f.30.2025.02.05.12.52.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 12:52:15 -0800 (PST) Date: Wed, 5 Feb 2025 21:52:14 +0100 From: Lorenzo Bianconi To: Conor Dooley Cc: Lorenzo Bianconi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Felix Fietkau , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, upstream@airoha.com Subject: Re: [PATCH net-next 09/13] dt-bindings: net: airoha: Add airoha,npu phandle property Message-ID: References: <20250205-airoha-en7581-flowtable-offload-v1-0-d362cfa97b01@kernel.org> <20250205-airoha-en7581-flowtable-offload-v1-9-d362cfa97b01@kernel.org> <20250205-cleaver-evaluator-648c8f0b99bb@spud> <20250205-disagree-motive-517efca2b90c@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TdZwv0UXFrq47/Kl" Content-Disposition: inline In-Reply-To: <20250205-disagree-motive-517efca2b90c@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250205_125427_946074_234CCCE5 X-CRM114-Status: GOOD ( 29.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --TdZwv0UXFrq47/Kl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Wed, Feb 05, 2025 at 08:33:13PM +0100, Lorenzo Bianconi wrote: > > > On Wed, Feb 05, 2025 at 07:21:28PM +0100, Lorenzo Bianconi wrote: > > > > Introduce the airoha,npu property for the npu syscon node available= on > > > > EN7581 SoC. The airoha Network Processor Unit (NPU) is used to offl= oad > > > > network traffic forwarded between Packet Switch Engine (PSE) ports. > > > >=20 > > > > Signed-off-by: Lorenzo Bianconi > > > > --- > > > > Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml | 8 += +++++++ > > > > 1 file changed, 8 insertions(+) > > > >=20 > > > > diff --git a/Documentation/devicetree/bindings/net/airoha,en7581-et= h.yaml b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml > > > > index c578637c5826db4bf470a4d01ac6f3133976ae1a..6388afff64e990a2023= 0b0c4e58534aa61f984da 100644 > > > > --- a/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml > > > > +++ b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml > > > > @@ -63,6 +63,12 @@ properties: > > > > "#size-cells": > > > > const: 0 > > > > =20 > > > > + airoha,npu: > > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > > + description: > > > > + Phandle to the syscon node used to configure the NPU module > > > > + used for traffic offloading. > > >=20 > > > Why do you need a phandle for this, instead of a lookup by compatible? > > > Do you have multiple instances of this ethernet controller on the > > > device, that each need to look up a different npu? > >=20 > > actually not, but looking up via the compatible string has been naked by > > Krzysztof on a different series [0]. >=20 > Hmm, I disagree with adding phandles that are not needed. I don't agree > that there's no reuse, if you can treat the phandle identically on a new > device, in all likelihood, that node should have a fallback to the > existing one. honestly I do not have a strong opinion about it, I am fine both ways. >=20 > That said, the bigger problem in what you link is the ABI break caused by > requiring the presence of a new node. I'd NAK that patch too. there is no PCIe support in dts for this device upstream yet, so I guess th= ere is no ABI break, right? Regards, Lorenzo >=20 > >=20 > > Regards, > > Lorenzo > >=20 > > [0] https://patchwork.kernel.org/project/linux-pci/patch/20250115-en758= 1-pcie-pbus-csr-v1-2-40d8fcb9360f@kernel.org/ > >=20 > > >=20 > > > > + > > > > patternProperties: > > > > "^ethernet@[1-4]$": > > > > type: object > > > > @@ -132,6 +138,8 @@ examples: > > > > , > > > > ; > > > > =20 > > > > + airoha,npu =3D <&npu>; > > > > + > > > > #address-cells =3D <1>; > > > > #size-cells =3D <0>; > > > > =20 > > > >=20 > > > > --=20 > > > > 2.48.1 > > > >=20 > >=20 > >=20 >=20 >=20 --TdZwv0UXFrq47/Kl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZ6PPfgAKCRA6cBh0uS2t rK1jAQCoE/zFHyySfuiJYIFTCuCPIfmrdKBiqfqc+4K/Y8PULQD/Wjs5AX8by6zR MX1/3RRgW7eVpvl15xDcvLxNAoGm9w0= =dcMi -----END PGP SIGNATURE----- --TdZwv0UXFrq47/Kl--