From: Herbert Xu <herbert@gondor.apana.org.au>
To: Martin Kaiser <martin@kaiser.cx>
Cc: linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Kamlesh Gurudasani <kamlesh@ti.com>
Subject: Re: [PATCH v2] hwrng: imx-rngc - add runtime pm
Date: Sun, 9 Feb 2025 18:25:35 +0800 [thread overview]
Message-ID: <Z6iCn97oKQuXZd-Y@gondor.apana.org.au> (raw)
In-Reply-To: <20250201183907.82570-1-martin@kaiser.cx>
On Sat, Feb 01, 2025 at 07:39:07PM +0100, Martin Kaiser wrote:
> Add runtime power management to the imx-rngc driver. Disable the
> peripheral clock when the rngc is idle.
>
> The callback functions from struct hwrng wake the rngc up when they're
> called and set it to idle on exit. Helper functions which are invoked
> from the callbacks assume that the rngc is active.
>
> Device init and probe are done before runtime pm is enabled. The
> peripheral clock will be handled manually during these steps. Do not use
> devres any more to enable/disable the peripheral clock, this conflicts
> with runtime pm.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> v2:
> - remove unnecessary err = 0; assignment
>
> drivers/char/hw_random/imx-rngc.c | 69 +++++++++++++++++++++++--------
> 1 file changed, 52 insertions(+), 17 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2025-02-09 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-18 16:07 [PATCH] hwrng: imx-rngc - add runtime pm Martin Kaiser
2025-01-27 16:42 ` Kamlesh Gurudasani
2025-02-01 18:39 ` [PATCH v2] " Martin Kaiser
2025-02-09 10:25 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6iCn97oKQuXZd-Y@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=kamlesh@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox