Re: [PATCH 1/2] dt-bindings: display: bridge: ldb: Implement simple Freescale i.MX91/93 DPI bridge

[Frank Li <Frank.li@nxp.com>]

On Tue, Feb 11, 2025 at 09:41:18AM +0100, Alexander Stein wrote:
> The i.MX91/93 contains a single syscon registers which is responsible
> for configuring DPI output format. Add DT binding which represents
> this configuration as a bridge.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  .../bridge/fsl,imx9-parallel-disp-fmt.yaml    | 78 +++++++++++++++++++
>  1 file changed, 78 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/bridge/fsl,imx9-parallel-disp-fmt.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,imx9-parallel-disp-fmt.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,imx9-parallel-disp-fmt.yaml
> new file mode 100644
> index 0000000000000..54cb73b59b1eb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/fsl,imx9-parallel-disp-fmt.yaml
> @@ -0,0 +1,78 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/bridge/fsl,imx9-parallel-disp-fmt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX91/93 DPI bridge
> +
> +maintainers:
> +  - Alexander Stein <alexander.stein@ew.tq-group.com>
> +
> +description: |

Needn't |

> +  The i.MX91/93 mediamix contains a single register which is responsible
> +  for configuring the parallel display output format. This describes
> +  this registers as bridge within the DT.
> +
> +properties:
> +  compatible:
> +    const: fsl,imx9-parallel-display-format


look like it should belong a property in fsl,imx8mm-disp-blk-ctrl.yaml.

Rob provide similar suggestion at
https://lore.kernel.org/imx/20250203220655.GA123074-robh@kernel.org/

Or at least, uplayer mfd yaml should link to this file.

Frank
> +
> +  reg:
> +    maxItems: 1
> +
> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +
> +    properties:
> +      port@0:
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description: Video port for DPI input.
> +
> +      port@1:
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description: Video port for DPI output (panel or bridge).
> +
> +    required:
> +      - port@0
> +      - port@1
> +
> +required:
> +  - compatible
> +  - reg
> +  - ports
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    blk-ctrl {
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +
> +        bridge@60 {
> +            compatible = "fsl,imx9-parallel-display-format";
> +            reg = <0x60 0x4>;
> +            status = "disabled";
> +
> +            ports {
> +                #address-cells = <1>;
> +                #size-cells = <0>;
> +
> +                port@0 {
> +                    reg = <0>;
> +
> +                    dpi_from_lcdif: endpoint {
> +                        remote-endpoint = <&lcdif_to_dpi>;
> +                    };
> +                };
> +
> +                port@1 {
> +                    reg = <1>;
> +
> +                    dpi_out: endpoint {
> +                    };
> +                };
> +            };
> +        };
> +    };
> --
> 2.34.1
>