From: Sudeep Holla <sudeep.holla@arm.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Saravana Kannan <saravanak@google.com>,
Linus Walleij <linus.walleij@linaro.org>,
Dong Aisheng <aisheng.dong@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
imx@lists.linux.dev, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 1/4] firmware: arm_scmi: bus: Bypass setting fwnode for scmi cpufreq
Date: Tue, 11 Feb 2025 17:13:21 +0000 [thread overview]
Message-ID: <Z6uFMW94QNpFxQLK@bogus> (raw)
In-Reply-To: <20241225-scmi-fwdevlink-v1-1-e9a3a5341362@nxp.com>
On Wed, Dec 25, 2024 at 04:20:44PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Two drivers scmi_cpufreq.c and scmi_perf_domain.c both use
> SCMI_PROTCOL_PERF protocol, but with different name, so two scmi devices
> will be created. But the fwnode->dev could only point to one device.
>
> If scmi cpufreq device created earlier, the fwnode->dev will point to
> the scmi cpufreq device. Then the fw_devlink will link performance
> domain user device(consumer) to the scmi cpufreq device(supplier).
> But actually the performance domain user device, such as GPU, should use
> the scmi perf device as supplier. Also if 'cpufreq.off=1' in bootargs,
> the GPU driver will defer probe always, because of the scmi cpufreq
> device not ready.
>
> Because for cpufreq, no need use fw_devlink. So bypass setting fwnode
> for scmi cpufreq device.
>
Not 100% sure if above is correct. See:
Commit 8410e7f3b31e ("cpufreq: scmi: Fix OPP addition failure with a dummy clock provider")
Am I missing something ?
--
Regards,
Sudeep
next prev parent reply other threads:[~2025-02-11 17:15 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-25 8:20 [PATCH 0/4] scmi: Bypass set fwnode to address devlink issue Peng Fan (OSS)
2024-12-25 8:20 ` [PATCH 1/4] firmware: arm_scmi: bus: Bypass setting fwnode for scmi cpufreq Peng Fan (OSS)
2024-12-27 15:13 ` Sudeep Holla
2024-12-30 2:05 ` Peng Fan
2024-12-31 18:07 ` Cristian Marussi
2025-01-02 7:38 ` Peng Fan
2025-01-02 17:06 ` Cristian Marussi
2025-01-06 4:37 ` Peng Fan
2025-02-11 17:13 ` Sudeep Holla [this message]
2025-02-12 7:01 ` Peng Fan
2025-02-12 10:48 ` Sudeep Holla
2025-02-13 8:03 ` Saravana Kannan
2025-02-13 20:23 ` Cristian Marussi
2025-02-18 1:09 ` Peng Fan
2025-02-18 10:24 ` Sudeep Holla
2025-02-18 13:36 ` Peng Fan
2025-02-19 10:17 ` Sudeep Holla
2025-02-20 0:59 ` Peng Fan
2025-03-10 9:29 ` Sudeep Holla
2025-03-10 10:45 ` Peng Fan
2025-03-10 11:59 ` Sudeep Holla
2025-03-10 13:41 ` Sudeep Holla
2025-03-11 8:36 ` Peng Fan
2025-03-11 11:12 ` Peng Fan
2025-03-11 11:23 ` Sudeep Holla
2025-03-12 10:52 ` Sudeep Holla
2025-03-12 11:28 ` Sudeep Holla
2025-03-13 5:23 ` Peng Fan
2025-04-09 3:50 ` Peng Fan
2025-04-09 11:14 ` Sudeep Holla
2025-04-17 14:26 ` Sudeep Holla
2025-04-20 14:09 ` Peng Fan
2025-04-22 10:16 ` Sudeep Holla
2025-06-20 3:58 ` Peng Fan
2024-12-25 8:20 ` [PATCH 2/4] firmware: arm_scmi: bus: Bypass setting fwnode for pinctrl Peng Fan (OSS)
2024-12-27 15:28 ` Sudeep Holla
2024-12-30 2:08 ` Peng Fan
2024-12-31 18:16 ` Cristian Marussi
2025-01-06 4:41 ` Peng Fan
2025-01-14 8:31 ` Peng Fan
2025-01-14 10:07 ` Cristian Marussi
2025-01-15 7:22 ` Peng Fan
2024-12-31 18:13 ` Cristian Marussi
2024-12-25 8:20 ` [PATCH 3/4] pinctrl: scmi: Check fwnode instead of machine compatible Peng Fan (OSS)
2024-12-27 15:30 ` Sudeep Holla
2024-12-31 18:18 ` Cristian Marussi
2025-01-02 7:11 ` Peng Fan
2024-12-25 8:20 ` [PATCH 4/4] pinctrl: freescale: " Peng Fan (OSS)
2024-12-27 17:06 ` [PATCH 0/4] scmi: Bypass set fwnode to address devlink issue Linus Walleij
2024-12-30 2:12 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6uFMW94QNpFxQLK@bogus \
--to=sudeep.holla@arm.com \
--cc=aisheng.dong@nxp.com \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=ping.bai@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=saravanak@google.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).