From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 975F5C0219B for ; Tue, 11 Feb 2025 18:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dROJ93SmGf9kZKqyuSupEaRXlVxtcG3/R9t0NyoM3J0=; b=I3UH6IJwqi2FvW0+sP4hcQ9zrr 6MMcq0lQfUV2Be12GfO2cSoifrZ5cUqS/G4gUBDsp3zP3BqwXdIv8EYPUWfuZ0d6G/o6eMUkf0GGI jCcSTty5G87zXl7KAkIDhuN6n3NLGE68ZVyGuYC7OZZuGFBvHGyVlPvcj1BXsZ/rMM/kjJb14c9qO ES62apVzqheFcxjiVBlqc0zBSkmtgR7waoXWKOv0SdHCkPn6E1jIT3e1CcEjsmDZUlA+8hbaw49zf xjUQ6AI4btb0MPh62xVdA/L/5KXgn0AlaXfuT4lMnpHaDzuz1gWk8Nw8gBSsNopvQ5g3T6j0PLmep HzSp58bA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thvId-00000004tvf-0XED; Tue, 11 Feb 2025 18:47:59 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thv9M-00000004ryY-1NJX; Tue, 11 Feb 2025 18:38:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id EC50B5C4949; Tue, 11 Feb 2025 18:37:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79CCFC4CEDD; Tue, 11 Feb 2025 18:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739299103; bh=9d6jju/AIBaHpo4CcHOAS0x1UR/bdfVSyRx15+juWkY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KM4EUBoMjRN48xcaieQjd0BFqnOJuWcuSbQtEJHC5hn90/M9bzWaCsy+NfatKadD5 wzYebE/Daz96X02ZYwZO/u7UA4Isg1XE8pzUej0EpmicEW9MSn2gMzR83dOlOXLcJy jPOZ9OIahCPBkd2d1KDBubdKO8twfNjmRdEDCEhgFtxI69ad9Ea3KTzxSlFmMjlpaQ kDrL8M5vH5HJwy0kQRYDH8KUIvntS7ecZNLjcdd6AfWNc+ROBuLTIBeYJbccI9ym/z 4T1hXfsOtpEP6QOMa1EsLNq5QoYiZohM1tlVvKkW70jVhc7kOx0PqYSWsstrLu4bTz 58+lRzskHQbDA== Date: Tue, 11 Feb 2025 11:38:20 -0700 From: Keith Busch To: Alyssa Rosenzweig Cc: Hector Martin , Sven Peter , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Philipp Zabel , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] apple-nvme: bug and perf fixes Message-ID: References: <20250211-nvme-fixes-v1-0-6958b3aa49fe@rosenzweig.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250211-nvme-fixes-v1-0-6958b3aa49fe@rosenzweig.io> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250211_103824_410189_C76061D4 X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 11, 2025 at 01:25:56PM -0500, Alyssa Rosenzweig wrote: > This small series fixes three unrelated issues with the Apple NVMe > driver. > > * fix NVMe on firmware/machine > * fix a power domain leak > * fix pathological driver performance with random writes > > The first two are strict bug fixes, the last is technically an > optimization but given the measured 200x performance difference I do > consider to be a fix ;-) The last two patches look good to me. I don't know anyone qualified to review the first patch, so I'll take your word for it if no one replies in the next few days. :)