From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 107E0C021B8 for ; Tue, 25 Feb 2025 16:44:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5RsOOvv4/v4k8q1hK8YiYnK0f9T2HxNOpQanU6J/Cfc=; b=PcT4oe5M97rujPwycYs9FZcpRL APdFu7mJad9L4a+RLtTiVqerFjAQXVkbR8lsR2MG2jFxSzUJ+F6/ysenQjAwowk9YIU5+AWNQIa8a k+mFtOhE2GGAVpFZBZQwaLzPQfifYICzgKtfrJKm0f13uOB8pEG9TlefazZyVMxrGq+ZYMoulp/XI UBNRApsvMZwQptmw9JQ3s0aQX8yR/CLF89U4DLluC0rApGvx25UrfbSArHFieOM7k6ytjDtNUAf1r aQhO1Dph9l6Q56tVNISlis54c+3Ten87OM5RF9pv4t62BY00Cvs+lrpXqi1u5lcnetp1UouStesUo PHJcgzpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tmy2J-00000000NcU-2c4T; Tue, 25 Feb 2025 16:43:59 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tmwzr-000000005mG-3zMN for linux-arm-kernel@lists.infradead.org; Tue, 25 Feb 2025 15:37:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E4CF85C71D4; Tue, 25 Feb 2025 15:36:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2BD3C4CEDD; Tue, 25 Feb 2025 15:37:19 +0000 (UTC) Date: Tue, 25 Feb 2025 15:37:17 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Pasha Tatashin , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Alexandre Ghiti , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 11/14] mm/vmalloc: Batch arch_sync_kernel_mappings() more efficiently Message-ID: References: <20250217140809.1702789-1-ryan.roberts@arm.com> <20250217140809.1702789-12-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250217140809.1702789-12-ryan.roberts@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250225_073724_029436_DF23047F X-CRM114-Status: UNSURE ( 8.37 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 17, 2025 at 02:08:03PM +0000, Ryan Roberts wrote: > When page_shift is greater than PAGE_SIZE, __vmap_pages_range_noflush() s/PAGE_SIZE/PAGE_SHIFT/ Otherwise it looks fine. Reviewed-by: Catalin Marinas