From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CEB8C021AD for ; Thu, 20 Feb 2025 05:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+XrtN4ek0pzutsbp2inBsEfI7MYyoOgN/8WvmNLs0lU=; b=LoPNg9cPe3xm6mF+mU2GE2zPxR PmY7VTgn6LB7JJ4VZatUJAgtt/CywbdQl1+lsf9vHSihe0nyXipQdQjM/XW/1QYNoIumsS/S8EDUD IzegCyB/vd5ojn34dSowF1sNwMofYK2s14s4JxD56BR1qWXxomszaI+nojuschwiN3Z52YvCv2v7a D3521j2/8ZsksXTYF69M3WFaMbpSOMPsG6OqVmWvfKw2NoN7Z37csiobxnNlB/NTJdA8oRO4+xGZs dHGeeByB6oLUbu3jBBKDlo0pnlDUEuTtwxxSaFdj0590M7MoVnYT5H41BfuVM38SuQkgJ8qYWZIoq RyWGTPnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tkyyK-0000000GmvN-0oII; Thu, 20 Feb 2025 05:19:40 +0000 Received: from mail-bn8nam12on20623.outbound.protection.outlook.com ([2a01:111:f403:2418::623] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tkywq-0000000Gmpb-1hPU for linux-arm-kernel@lists.infradead.org; Thu, 20 Feb 2025 05:18:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VRPCaGCFkLb1r4RqyMuHP0IAmPiOgmcjeZsmVJHCDx5Zq23+ztTjt7CKGVeWNgI7XV9Ls4I2dsPrccmM1KI+UVoqUBzAJATNNzAItZR4sg5hhuXQjYog8W071bpD9r+yy1r7+EbEnzak8S8sIxuk/KWnmoZqmNCbOKKgZTo4iugsZvks44gNAgzBILa8S5h37kSGLu3hlgOpdxnWzNqhp+xEgymmk14aP3k2suO/r0/saSr9FNsJAj8i98VlYUCqGb5aQftoIaQNZVXjhet8pXuBUcf0nQidgcRCgVlAi9Ii8l3D2s3qJjS9xK+oHvReMSqOjCpwxZXP/FRC1u4jMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+XrtN4ek0pzutsbp2inBsEfI7MYyoOgN/8WvmNLs0lU=; b=reNZDClBm/kk6/Ea7VK3LXfqJK239gvErINGKOUeI532WULP2lKEL/wDndlxtZmESt4H7ouKyh2u/y7TA3SNkUkOvPac3nCTwX8HTBChqE0c4gceOvL2EImrjGxllbr8LhG+MC+VM25EKcFHCgShLZfDuLQD9EH8uhvor31r1Kg/VOVD/txKndVcldGP7dWqjfN1r6C5o2ui7PgvoITqr74rQnyIl2iJboGS0uWm2lb3QCLQjJOw/qyoFrpxTwDiEjnYU+g4IGNzmpowAdO+u5GYZnFHymrBZoQUO3dhZV/iveyIBfQ2bAWN3hIpym3t41f5uz+kdSYuwS2EApA55A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+XrtN4ek0pzutsbp2inBsEfI7MYyoOgN/8WvmNLs0lU=; b=BPbTqO5ahHdsrX1QNJ3ZMt1Yb2diIj1yNWzU4fYUoG96Cyd/D7inSB2cymoD7D2abqkIJx9J3DRjpPrus7xbl0rRRpMwOCdwvpawoLXn9Xq51/RnXvEpmj6zWt06E79Isdaq68A+uQ86MJrpzYWkx1LmlAEjnTCEm8wYq+zaJvA7hlosqBIoyouxY2ZnE9kwYNwHO3Gl9JsSYgdTbDAylrJd7yN8QVCFcpBz1zt1yAEEamaMaVZFAtNA75QZpuf1y9IXOHFG3nmXBcrsutCvdQCL6i9a142dQKpntKHyoe7vPeYVFzrfNNjMXrey/AbGriOE5Dn7QWl0JmZ9KPMUAA== Received: from BN9P221CA0002.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::9) by BL3PR12MB6425.namprd12.prod.outlook.com (2603:10b6:208:3b4::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Thu, 20 Feb 2025 05:17:39 +0000 Received: from MN1PEPF0000F0E0.namprd04.prod.outlook.com (2603:10b6:408:10a:cafe::c9) by BN9P221CA0002.outlook.office365.com (2603:10b6:408:10a::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8466.16 via Frontend Transport; Thu, 20 Feb 2025 05:17:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by MN1PEPF0000F0E0.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.11 via Frontend Transport; Thu, 20 Feb 2025 05:17:38 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 19 Feb 2025 21:17:21 -0800 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Wed, 19 Feb 2025 21:17:21 -0800 Received: from Asurada-Nvidia (10.127.8.10) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Wed, 19 Feb 2025 21:17:20 -0800 Date: Wed, 19 Feb 2025 21:17:18 -0800 From: Nicolin Chen To: Jason Gunthorpe CC: , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v6 06/14] iommufd/viommu: Add iommufd_viommu_get_vdev_id helper Message-ID: References: <313a27d92bd63e9571bf0f053eabfc3bfe4bfbae.1737754129.git.nicolinc@nvidia.com> <20250218153154.GC4099685@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250218153154.GC4099685@nvidia.com> X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0E0:EE_|BL3PR12MB6425:EE_ X-MS-Office365-Filtering-Correlation-Id: 2cd45115-548b-4434-6ebd-08dd516de4e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|7416014|82310400026|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?IhGLYdkrFrj374HfnvWPcqTVukFyxRi/PcaTG5dE7n/Z4f59VJ043o7H7eoI?= =?us-ascii?Q?LFqwCvy6aDPJXlFMm89T42hn8LDIAGOP7k7uTaVGazyzWJNDMGn+CGJLMeGo?= =?us-ascii?Q?0IUHufVoSU6vXPwy53dT/kM4GU7r60iMS1UypXhybAii5h4raw8jo5oWW1KO?= =?us-ascii?Q?YVpT6D6EHWQAclYlnaWOvXeuwOU+BNYadWcwfubX/MH6BzW3afQgeybOEs5O?= =?us-ascii?Q?dRTApAQV2DioqcPuGh9DMYSzgfZAX1ayqiRKVu9ss+yjwubTu5J/uxv0wKpy?= =?us-ascii?Q?7PIbaXah2UN3kTL4ICQUwm3rQP92DyTynkmSK7vMBy41ZarBF90NMugN80X0?= =?us-ascii?Q?VOhcHIN6j6lwFhLqmGluDEpgrLNm6u2RvtWc/Tpz6W/l17xwnX8i6bD0TsiM?= =?us-ascii?Q?2WgKm4RGceQHmTKhPRfjX8CI3amcUcQfg1gqyfEWlqLtG1mf24Rgx/pKDizo?= =?us-ascii?Q?o5y6vjCOvhCcLTSs4KEQA6n80AHjsbJv8Ws7iw4ej2t216muQbwxN+BmhQHk?= =?us-ascii?Q?ukKnaGsG7WAhysSuLkCgN0kDzgH0+JWOvwVjVQC15JLn5unw5nKRPMkdIW0o?= =?us-ascii?Q?E9PUdZy2I475zwtJyObQ4B18huZ1r/ypHCpxW6GTw5MgMwOAcMp6AgT9SKR6?= =?us-ascii?Q?1dZEdpv8/EzMwuEaYLJ5TroC6UTwDwRP0DcLResSspZy+Ob64VKJbCL5s47a?= =?us-ascii?Q?/J6Ri0rtm8JqBd/hKWYt6WZQEuNcNMf/306ftGmDXd/DYX0U9nsj3ck8ChxF?= =?us-ascii?Q?iUyTBXhhd+z5XpEMcSfix9x9kMHjFklNhNcVAeGBYbvXQC8Vy5WEeNpdhO7G?= =?us-ascii?Q?UcGQDxYqlc46hPpq8BmdgfS0G4FHhseBbNZRGeRKHDDqtoYl7yKsqIh3W6qY?= =?us-ascii?Q?88wQ7EQrt+zjLkMJXq7CLM2YLbYjH926rSubXPUy/87vxEGBq7ScENpRPvrI?= =?us-ascii?Q?e46foPEOto+E2SCb/yK5kBg+KG5iIFY5xA6uO4acCk0OC9MJdgTa1hvmyFoA?= =?us-ascii?Q?W1y2RjyOdmNi/V3KJMwbZXSl1pB4M9XWwkZPYTf5BIntYT4Rager2gS1BQpx?= =?us-ascii?Q?R1HlS8u+2kXK0cNXXxRVgcT5fHqYxi2lcGAa4y0IqghGA4uWu2R8rXzB9s/t?= =?us-ascii?Q?ZCA2sE6/bxMpL6Ebx5FecEFr048yEJgpZ0CYBdetmX8At/ZunY8hMsjHxbFs?= =?us-ascii?Q?8BLnqisp6v9LjfHmP1w5+FrITESbzjW/s+VEeaMdXfEFKLm9LPvBGE1kg5mA?= =?us-ascii?Q?rkxf7DrxBojG/YJHXA+noNrTbgv4MoN8OYrKBD3KP2K6gQ1XxpQqhy/5U7Vb?= =?us-ascii?Q?bzBEyaDdk3X+jfczOsKdNmpT7e2sMb6lwSxXzOzpxG8+zXYNsJsQ+dJTEo9C?= =?us-ascii?Q?J44CXLuura7V0CocWe31TpvGlhA59sAJIbqsSE03G+52+6Y6deOIyCAxjm+W?= =?us-ascii?Q?KyAtq8wc1ENBWfdYlSxlwvXl1B7786q6sQUuIzjFr4V7iUD5Swc2qaZNDZou?= =?us-ascii?Q?vF/Tn/kW5tvQWPc=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(7416014)(82310400026)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2025 05:17:38.7882 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2cd45115-548b-4434-6ebd-08dd516de4e6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000F0E0.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6425 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250219_211808_464126_35E3711B X-CRM114-Status: GOOD ( 16.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 18, 2025 at 11:31:54AM -0400, Jason Gunthorpe wrote: > On Fri, Jan 24, 2025 at 04:30:35PM -0800, Nicolin Chen wrote: > > This is a reverse search v.s. iommufd_viommu_find_dev, as drivers may want > > to convert a struct device pointer (physical) to its virtual device ID for > > an event injection to the user space VM. > > > > Again, this avoids exposing more core structures to the drivers, than the > > iommufd_viommu alone. > > > > Reviewed-by: Lu Baolu > > Reviewed-by: Kevin Tian > > Signed-off-by: Nicolin Chen > > --- > > include/linux/iommufd.h | 9 +++++++++ > > drivers/iommu/iommufd/driver.c | 24 ++++++++++++++++++++++++ > > 2 files changed, 33 insertions(+) > > Reviewed-by: Jason Gunthorpe > > > + xa_lock(&viommu->vdevs); > > + xa_for_each(&viommu->vdevs, index, vdev) { > > + if (vdev->dev == dev) { > > + *vdev_id = (unsigned long)vdev->id; > > I don't think we need this cast The left side is ulong for xarray index, while the right side is __aligned_u64 for uAPI. Could there be a gcc warning when somebody builds the kernel having a BITS_PER_LONG=32? iommufd_vdevice_alloc_ioctl() does test vdev->id against ULONG_MAX though.. Thanks Nicolin