[PATCH] ARM: dts: imx28-sps1: Fix GPIO LEDs description

[PATCH] ARM: dts: imx28-sps1: Fix GPIO LEDs description

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

According to leds-gpio.yaml, the LED nodes should not contain
unit addresses. Remove them.

Also, 'default-trigger' is not a valid property. Change it to
'linux,default-trigger'.

These changes fix the following dt-schema warnings: 

led@1: Unevaluated properties are not allowed ('reg' was unexpected)
led@2: Unevaluated properties are not allowed ('reg' was unexpected)
led@3: Unevaluated properties are not allowed ('default-trigger', 'reg' were unexpected)
leds: '#address-cells', '#size-cells' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/mxs/imx28-sps1.dts | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-sps1.dts b/arch/arm/boot/dts/nxp/mxs/imx28-sps1.dts
index 0f01dded4e3d..ca62e7933116 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx28-sps1.dts
+++ b/arch/arm/boot/dts/nxp/mxs/imx28-sps1.dts
@@ -24,30 +24,25 @@ reg_usb0_vbus: regulator-0 {
 	};
 
 	leds {
-		#address-cells = <1>;
-		#size-cells = <0>;
 		compatible = "gpio-leds";
 		status = "okay";
 
-		led@1 {
+		led-1 {
 			label = "sps1-1:yellow:user";
 			gpios = <&gpio0 6 0>;
 			linux,default-trigger = "heartbeat";
-			reg = <0>;
 		};
 
-		led@2 {
+		led-2 {
 			label = "sps1-2:red:user";
 			gpios = <&gpio0 3 0>;
 			linux,default-trigger = "heartbeat";
-			reg = <1>;
 		};
 
-		led@3 {
+		led-3 {
 			label = "sps1-3:red:user";
 			gpios = <&gpio0 0 0>;
-			default-trigger = "heartbeat";
-			reg = <2>;
+			linux,default-trigger = "heartbeat";
 		};
 
 	};
-- 
2.34.1

Re: [PATCH] ARM: dts: imx28-sps1: Fix GPIO LEDs description

[Shawn Guo]

On Mon, Feb 03, 2025 at 02:30:20PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> According to leds-gpio.yaml, the LED nodes should not contain
> unit addresses. Remove them.
> 
> Also, 'default-trigger' is not a valid property. Change it to
> 'linux,default-trigger'.
> 
> These changes fix the following dt-schema warnings: 
> 
> led@1: Unevaluated properties are not allowed ('reg' was unexpected)
> led@2: Unevaluated properties are not allowed ('reg' was unexpected)
> led@3: Unevaluated properties are not allowed ('default-trigger', 'reg' were unexpected)
> leds: '#address-cells', '#size-cells' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!