Re: [PATCH 5/5] arm64: dts: mba8xx: Add PCIe support

Alexander Stein
2025-02-25T11:39:02Z

Hi Frank,

Am Montag, 24. Februar 2025, 20:04:40 CET schrieb Frank Li:
> On Tue, Jan 07, 2025 at 03:01:10PM +0100, Alexander Stein wrote:
> > Add PCIe support for TQMa8Xx on MBa8Xx board.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > arch/arm64/boot/dts/freescale/mba8xx.dtsi | 32 +++++++++++++++++++----
> > 1 file changed, 27 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> > index 276d1683b03bb..117f657283191 100644
> > --- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> > @@ -36,6 +36,13 @@ chosen {
> > stdout-path = &lpuart1;
> > };
> >
> > + /* Non-controllable PCIe reference clock generator */
> > + pcie_refclk: clock-pcie-ref {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <100000000>;
> > + };
> > +
> > gpio-keys {
> > compatible = "gpio-keys";
> > pinctrl-names = "default";
> > @@ -208,6 +215,12 @@ &flexcan2 {
> > status = "okay";
> > };
> >
> > +&hsio_phy {
> > + fsl,hsio-cfg = "pciea-x2-pcieb";
> > + fsl,refclk-pad-mode = "input";
> > + status = "okay";
> > +};
> > +
> > &i2c1 {
> > tlv320aic3x04: audio-codec@18 {
> > compatible = "ti,tlv320aic32x4";
> > @@ -309,7 +322,16 @@ &lsio_gpio3 {
> > "", "", "", "";
> > };
> >
> > -/* TODO: Mini-PCIe */
> > +&pcieb {
> > + phys = <&hsio_phy 0 PHY_TYPE_PCIE 0>;
> > + phy-names = "pcie-phy";
> > + pinctrl-0 = <&pinctrl_pcieb>;
> > + pinctrl-names = "default";
> > + reset-gpios = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
> > + disable-gpio = <&expander 7 GPIO_ACTIVE_LOW>;
>
> "disable-gpio" is undocument property.

Thanks for noticing, old downstream property slipped through. Will remove it.

Best regards
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider