From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8D2FC28B2E for ; Mon, 10 Mar 2025 07:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4gu523b1wXNt4CE9jHyiDRqe61VWjDoVz4cMOvjxGE8=; b=c4QtfdO71mKr2Tq+HK5eBTxqYY lE28M8tle+CMzNvBwECdhdSv5YPQQPG6hWFQr4bUCq11TKx6fXlU1bvl1fk5avOtVWUx6QvvL1OGu OwSUMeQCAFgQHUn1EoVS26vXceIh1WrKAHyjMkm6KHlJftYGz3yqE1riVS08Nuu36gnV/7msklP7R HXrXDx9TNPqwHtKN0k16ST/InB4Zhx47+HL7J0hqoOYb+xMfGqJOhh6l+WoqQNECPwanrAv3Lp8Z7 G8T82+FLjo1UXos6EmlxEwuwpgiYwuRZTQhOg/1e0TSpEDOvldDAfZn+40NISZXV1RH3GH1zJmrhs YS70i8RA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1trXXl-00000001kWg-1vOW; Mon, 10 Mar 2025 07:27:21 +0000 Received: from layka.disroot.org ([178.21.23.139]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1trXTa-00000001jnX-2OPL; Mon, 10 Mar 2025 07:23:03 +0000 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 2F03425BCC; Mon, 10 Mar 2025 08:22:59 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ZMGQERGogw6S; Mon, 10 Mar 2025 08:22:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1741591378; bh=ernuOloDM88O4OqBSQAmgvrlP6Ekdag/9GbGQz9YjjE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Yj/q1LrQrDqhoAQxcFGJitqVJn0Wd0MC2+TfDG2DkygRosf9vfRzzLbO12hs34tDP 23dnklqB4edGqqxDfIFDuTC01YosBXfFK/Cq8TRJHsxhtVrGZxmtmBCVGK5DZKVtwr ujhWSayOid/kDRa9mHIG0lZZqaDpVecLmmRnLpVt59Wn9Wm3CMbmp9LSacLPUW445m 0DFwI0SfuCbs8gKtMptl08ovavQZsiJWrjxRBGMwLdhfS9XEJwQ2RPPJGRXnuSOTo+ Vtrt4etL/rqP57sDrUC+CIo2cvW6kAP2F+2rFcCDcqB5f4e0gVILarRn2GNlpOgX8V o833i3xp+NRcA== Date: Mon, 10 Mar 2025 07:22:45 +0000 From: Yao Zi To: Chukun Pan Cc: andi.shyti@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, heiko@sntech.de, jonas@kwiboo.se, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 2/3] arm64: dts: rockchip: Add I2C controllers for RK3528 Message-ID: References: <20250309070603.35254-3-ziyao@disroot.org> <20250309080025.15825-1-amadeus@jmu.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250309080025.15825-1-amadeus@jmu.edu.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250310_002302_744487_B5F93C46 X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 09, 2025 at 04:00:25PM +0800, Chukun Pan wrote: > Hi, > > > + i2c0: i2c@ffa50000 { > > + compatible = "rockchip,rk3528-i2c", > > + "rockchip,rk3399-i2c"; > > + reg = <0x0 0xffa50000 0x0 0x1000>; > > + clocks = <&cru CLK_I2C0>, <&cru PCLK_I2C0>; > > + clock-names = "i2c", "pclk"; > > + interrupts = ; > > It would be better to add default pinctrl for all i2c nodes > using m0 group. (Only 1 group of pinctrl for i2c4 and i2c7) Seems i2c2, i2c4 and i2c7 could be assigned to only one set of pins, for them I'll add default pinctrls. For the other controllers, I prefer to keep pinctrls in board-level devicetree, which is easier to read. Other Rockchip SoCs (like rk3588) seem to provide default pinctrls even for those capable of multiple groups of pins, so I'm not sure whether it's necessary to keep the style synchronized. Will add if the maintainer considers it's better. > Thanks, > Chukun > > -- > 2.25.1 > Thanks, Yao Zi