From: Vinod Koul <vkoul@kernel.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] dmaengine: Add Arm DMA-350 driver
Date: Tue, 11 Mar 2025 02:17:31 +0530 [thread overview]
Message-ID: <Z89P461+Y6kQDOCX@vaman> (raw)
In-Reply-To: <55e084dd2b5720bdddf503ffac560d111032aa96.1740762136.git.robin.murphy@arm.com>
On 28-02-25, 17:26, Robin Murphy wrote:
> +static u32 d350_get_residue(struct d350_chan *dch)
> +{
> + u32 res, xsize, xsizehi, hi_new;
> +
> + hi_new = readl_relaxed(dch->base + CH_XSIZEHI);
> + do {
> + xsizehi = hi_new;
> + xsize = readl_relaxed(dch->base + CH_XSIZE);
> + hi_new = readl_relaxed(dch->base + CH_XSIZEHI);
> + } while (xsizehi != hi_new);
This can go forever, lets have some limits to this loop please
> +static int d350_alloc_chan_resources(struct dma_chan *chan)
> +{
> + struct d350_chan *dch = to_d350_chan(chan);
> + int ret = request_irq(dch->irq, d350_irq, IRQF_SHARED,
> + dev_name(&dch->vc.chan.dev->device), dch);
This is interesting, any reason why the irq is allocated here? Would it
be not better to do that in probe...
--
~Vinod
next prev parent reply other threads:[~2025-03-10 20:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 17:26 [PATCH 0/2] dmaengine: Add Arm DMA-350 driver Robin Murphy
2025-02-28 17:26 ` [PATCH 1/2] dt-bindings: dma: Add Arm DMA-350 Robin Murphy
2025-02-28 18:40 ` Rob Herring (Arm)
2025-02-28 17:26 ` [PATCH 2/2] dmaengine: Add Arm DMA-350 driver Robin Murphy
2025-03-01 18:49 ` kernel test robot
2025-03-01 20:09 ` kernel test robot
2025-03-06 11:33 ` kernel test robot
2025-03-10 20:47 ` Vinod Koul [this message]
2025-03-11 12:48 ` Robin Murphy
2025-03-12 9:18 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z89P461+Y6kQDOCX@vaman \
--to=vkoul@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).