From: Alyssa Rosenzweig <alyssa@rosenzweig.io>
To: fnkl.kernel@gmail.com
Cc: Sven Peter <sven@svenpeter.dev>, Janne Grunau <j@jannau.net>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Hector Martin <marcan@marcan.st>
Subject: Re: [PATCH 2/2] iommu: apple-dart: Allow mismatched bypass support
Date: Thu, 27 Feb 2025 12:01:47 -0500 [thread overview]
Message-ID: <Z8Cae58jLqcGwF8S@blossom> (raw)
In-Reply-To: <20250227-isp-dart-v1-2-161e91ef4f46@gmail.com>
> + /* Will be ANDed with DART capabilities */
> + cfg->supports_bypass = true;
...
> + if (!dart->supports_bypass)
> + cfg->supports_bypass = false;
Probably better to write
cfg->supports_bypass &= dart->supports_bypass;
To match what's in the comment!
prev parent reply other threads:[~2025-02-27 19:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 16:56 [PATCH 0/2] iommu: apple-dart: Support the ISP DART Sasha Finkelstein via B4 Relay
2025-02-27 16:56 ` [PATCH 1/2] iommu: apple-dart: Increase MAX_DARTS_PER_DEVICE to 3 Sasha Finkelstein via B4 Relay
2025-02-27 17:02 ` Alyssa Rosenzweig
2025-02-27 16:56 ` [PATCH 2/2] iommu: apple-dart: Allow mismatched bypass support Sasha Finkelstein via B4 Relay
2025-02-27 17:01 ` Alyssa Rosenzweig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8Cae58jLqcGwF8S@blossom \
--to=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=fnkl.kernel@gmail.com \
--cc=iommu@lists.linux.dev \
--cc=j@jannau.net \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=robin.murphy@arm.com \
--cc=sven@svenpeter.dev \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).