From: Sebastian Ene <sebastianene@google.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: catalin.marinas@arm.com, joey.gouly@arm.com, maz@kernel.org,
oliver.upton@linux.dev, snehalreddy@google.com,
suzuki.poulose@arm.com, vdonnefort@google.com, will@kernel.org,
yuzenghui@huawei.com, kvmarm@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH 2/3] KVM: arm64: Map the hypervisor FF-A buffers on ffa init
Date: Thu, 27 Feb 2025 17:58:22 +0000 [thread overview]
Message-ID: <Z8CnvkUwGKxcz2hj@google.com> (raw)
In-Reply-To: <Z8A3RLoZxVxcz3wj@bogus>
On Thu, Feb 27, 2025 at 09:58:28AM +0000, Sudeep Holla wrote:
> On Wed, Feb 26, 2025 at 09:48:52PM +0000, Sebastian Ene wrote:
> > Map the hypervisor's buffers irrespective to the host and return
> > a linux error code from the FF-A error code on failure. Remove
> > the unmap ff-a buffers calls from the hypervisor as it will
> > never be called and move the definition of the
> > ffa_to_linux_error map in the header where it should belong to.
> > Prevent the host from using FF-A if the hypervisor could not
> > map its own buffers with Trustzone.
> >
> > Signed-off-by: Sebastian Ene <sebastianene@google.com>
> > ---
> > arch/arm64/kvm/hyp/nvhe/ffa.c | 46 ++++++++++++-------------------
> > drivers/firmware/arm_ffa/driver.c | 24 ----------------
> > include/linux/arm_ffa.h | 24 ++++++++++++++++
Hi Sudeep,
>
> Can you post the code movement from driver to the header as separate patch
> so that I can take it separately to avoid conflicts with the other changes
> I have. It could be just fine but I see no reason as why it can't be a
> separate change or why it needs to be bundled here.
Yes, let me do that and I will spin up a v2.
Thanks,
Sebastian
>
> --
> Regards,
> Sudeep
next prev parent reply other threads:[~2025-02-27 19:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 21:48 [PATCH 0/3] KVM: arm64: Separate the hyp FF-A buffers init from the host Sebastian Ene
2025-02-26 21:48 ` [PATCH 1/3] KVM: arm64: Use the static initializer for the vesion lock Sebastian Ene
2025-02-26 21:48 ` [PATCH 2/3] KVM: arm64: Map the hypervisor FF-A buffers on ffa init Sebastian Ene
2025-02-27 9:58 ` Sudeep Holla
2025-02-27 17:58 ` Sebastian Ene [this message]
2025-02-26 21:48 ` [PATCH 3/3] KVM: arm64: Release the ownership of the hyp rx buffer to Trustzone Sebastian Ene
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8CnvkUwGKxcz2hj@google.com \
--to=sebastianene@google.com \
--cc=catalin.marinas@arm.com \
--cc=joey.gouly@arm.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=snehalreddy@google.com \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=vdonnefort@google.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).