Re: [PATCH] clk: rockchip: Add reset lookup table for RK3528

[Yao Zi <ziyao@disroot.org>]

On Thu, Feb 27, 2025 at 05:52:57PM +0000, Jonas Karlman wrote:
> In the commit 5d0eb375e685 ("clk: rockchip: Add clock controller driver
> for RK3528 SoC") only the dt-binding header was added for the reset
> controller for the RK3528 SoC.
> 
> Add a reset lookup table generated from the SRST symbols used by vendor
> linux-6.1-stan-rkr5 kernel to complete support for the reset controller.
> 

Thanks for completing the reset part! The patch looks good to me, but

> Fixes: 5d0eb375e685 ("clk: rockchip: Add clock controller driver for RK3528 SoC")

I wonder whether it deserves a Fix tag: to me it's more like a new
feature. Please correct me if I'm wrong.

> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
> ---
>  drivers/clk/rockchip/Makefile     |   2 +-
>  drivers/clk/rockchip/clk-rk3528.c |   2 +
>  drivers/clk/rockchip/clk.h        |   1 +
>  drivers/clk/rockchip/rst-rk3528.c | 306 ++++++++++++++++++++++++++++++
>  4 files changed, 310 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/clk/rockchip/rst-rk3528.c
> 

Thanks,
Yao Zi