From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C219C282C6 for ; Mon, 3 Mar 2025 22:01:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1aTUAwKXUg9/Tgo4S4zYcikDxnpI32rMeKfY9HP7IQ4=; b=WByVh2Jp8sG6Dj6le83khqB26U K/sBMykITcGqenngo9X917/SM+uF5CKEvZP5mM8rnz6Dm0RGQ/a0hwNNUEMWe34uzZNgrPqideBrY Hv3bQElkRIYNWz+ebFXhClPfDilI0XTqs2RUWflb+TNHuEl8WX+lIgnoJHwpKZsltZwJlNBj/QThe Sq9jdBNGnlTty8puOVilneuK7ja8V4HU+Nb4HF4GRqOHf5Y6dSTSyoo9I5iZqdZbE+MB8Py/TEao8 NZFVUP1oeBglQUVonbXAH3nKBze/9RSuTdj7Be92IiYbZ0sU92utAn32mmsIWBeOmYLBNU2vMkZp1 EI6FKfHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpDqr-00000002Q60-1Pg9; Mon, 03 Mar 2025 22:01:29 +0000 Received: from mail-northeuropeazlp170120003.outbound.protection.outlook.com ([2a01:111:f403:c200::3] helo=DU2PR03CU002.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpDoZ-00000002Pjs-1ZxD for linux-arm-kernel@lists.infradead.org; Mon, 03 Mar 2025 21:59:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MGsuK8M6mI0wRtf724ErKJDtjCvc1NpZYxA6m+OFUhUb2aAjcLJOM2j7J4/vyLwdxuKoqiFGB/IcucYvu1RBJMx5nBZpVdYK5vktYTMyF0QufjfAmqo7NvJ2T3LVOkahWPSUjXihE5VbJkpw1hRApt6rRYlMmZLEiqJqGDmtAlYfxnLSujGUntuwxUkslUf+WKCJPQayUo1ANZYO0sSmIFBzpvOOMDuPuW7KxQsqxpUqzIXeIQSa4Drd64U8DNHObWreP6DGkRWjoG+7SRXw+UugJ2XZVKJqEfyGVU8PR7wzybr2yfTHHV9OQ50VfwQhyv4ju6xdveX5CCk6YDFiRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1aTUAwKXUg9/Tgo4S4zYcikDxnpI32rMeKfY9HP7IQ4=; b=sNp9cme+OhY8jy7Ess5S8hkrJEKxVnvPcArHpeydilRSyWl/pA2eGH3TLsxEM/ZkT9w/88bYSO3Xaa1nTs8dIyfMHutQvyUmfOfE5KKCbqAyucAegXL+QYKjU9BHYN5ezlKPs9yhMEFmGvg8wwwfUFqomVpY3bmP95y0ckRT0DiEgrHdKIIIGZvFYewCQIik3/EOobm86oLbCQb0ufXLlQR2HdKCE1ZHRcj9yC3kg169sfITjfU8bQHHaBWEPUl2ibgaHsWAd9puxaXtB5QXps/ukZXu7UIeSm0pMtKGz06K98ddE2YIPkA6LiZg4UwP3BtZKeFQwstdKKpgIKYyDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1aTUAwKXUg9/Tgo4S4zYcikDxnpI32rMeKfY9HP7IQ4=; b=XiLUKuWIz169gPWQaJoRdNnnTNDoO1RjUdHW7wP+gJxINSiH85SlRWQzWw6sRUimFw2dCLXolUduYmQtRqFDg9Gh4uTlGbQWXTCliOPtumU0Zea+7fqpNvdu9ItUMRfWjk9LWAXcjJ8gmxx0ZKSEKSctkWtyhm+IH2SjUiJ53GUJYleXLWhAOvWp5USW7UgOm6zwmdxWZa3q5Kyu3NFyzjZAZoDhtk70lXzg4hAoTm8SrYHUNh0RotSyB5d60TwuCeRC9ZQBv5xmrdrqVG15nWp03RUxX0RZC8brMjk8t8E45kHuvpJ1zLoLlDDqNhmA/Zldko1aWELrjTY9MfdWuQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PAWPR04MB9910.eurprd04.prod.outlook.com (2603:10a6:102:380::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.28; Mon, 3 Mar 2025 21:59:04 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%5]) with mapi id 15.20.8489.019; Mon, 3 Mar 2025 21:59:04 +0000 Date: Mon, 3 Mar 2025 16:58:56 -0500 From: Frank Li To: Bjorn Helgaas Cc: Rob Herring , Saravana Kannan , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Niklas Cassel Subject: Re: [PATCH v9 4/7] PCI: dwc: Use devicetree 'ranges' property to get rid of cpu_addr_fixup() callback Message-ID: References: <20250128-pci_fixup_addr-v9-4-3c4bb506f665@nxp.com> <20250226233339.GA562682@bhelgaas> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250226233339.GA562682@bhelgaas> X-ClientProxiedBy: PH7P220CA0048.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:32b::19) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PAWPR04MB9910:EE_ X-MS-Office365-Filtering-Correlation-Id: 51d6234e-adc4-4bcd-d0d4-08dd5a9e9d2c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|7416014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?q0hWO6YQ8nbvCN4gfLL3wO+FUoAgk//JFVLAOd9sfhSBWDkYATulFtrzSvKJ?= =?us-ascii?Q?a47U1JLv34IGKq8lw5Tvd84Z7iidaa9hTXAAfTLsNIfsgyf7I6pQYJnPcMn4?= =?us-ascii?Q?Ab2xBHvpe4BnImTexmNfftaKMet0yqiGFWv9IbsmHXK2bHUtX9blg1FZ8JKC?= =?us-ascii?Q?/Rv2ww0GMC5jdtVDezuKnZHWcB5rxy23qulSXGYfY7DY2Hxesuyy9ScP1iiN?= =?us-ascii?Q?kjhgLsMOjml4TceldIxamtizIuZO5HQObpge5m2KVxGB2k0CvHO8q24YJZb0?= =?us-ascii?Q?PjtpCkpct8GdYFCnBjCFznVyvegs5lZZS4hMisSFvtwQH5y6sq1khics+p9b?= =?us-ascii?Q?RXRiMwChjdp8cpKM56fR4D4ATY4qbxpzvYsaOsMr9gKjvtApdlpPrDRq/pp3?= =?us-ascii?Q?Rp1DdTNHDGodz+CQwGPJch43zHzBrk+sA3WBr1EptklNC96FXsWlJZNgjQV7?= =?us-ascii?Q?ExzwuaiqRA2lJhyIJgHtP9XvDg8Uj8Heguw/ZbL2gFy5JUIgMhP53rPFujny?= =?us-ascii?Q?3FeE8esD+rTErcuLONklKWhJnXIisrjo6++eVoFRjSoP3mGnlzhCw4b3LqDm?= =?us-ascii?Q?/lDDHsNtgstDtAzJLfLimKjpVD1jvoNpjGcEQtkBIwk1vg0bsXw+QL4/5ZHr?= =?us-ascii?Q?Z5ytDpaDszCbSHX6uW5NzhFD+qvgPbvm86lj2QjV0sr0Zw2u5mrvn+UdiDlS?= =?us-ascii?Q?4xDidkJBgZ4Sk6qHTZBplEy6sWRI7H4diwT2oxanJzhnV4R4t926cuwvctJA?= =?us-ascii?Q?T3Z6FrBidCJuN/IzcJ3X7eVjCODcU6//2A/VmAL8wL/fNPZbLFelNPdsVtcL?= =?us-ascii?Q?7bm6eJ972uDkVRJdgCT0J9zdifRWEJCqKZR0NyXMJuqMpa15IPYV+zA2nbDK?= =?us-ascii?Q?GveNOZjZn8qeVGEmH6XxuqzHTH3CBzemQoKlLzstQQxLCwaw1gnPkCtJNOHW?= =?us-ascii?Q?WYxP98R5YLH9MsJa0R6D/G+Phb5DkiJVcDK4Tbb+vctUbfeQ3E70VE487qaG?= =?us-ascii?Q?jkiMLiAtURj6bpymxRlR3crL/Eb/9ehY+UmmNrzvjxr9sFs2ai2sFEuVxx5n?= =?us-ascii?Q?0fQJyVefFi1KLj+3+tKktuXNl+VMT0lSF1+6+2t4q2EopyKy/ZRYowfFU758?= =?us-ascii?Q?ONSuKUB3Su1fw+9nguOn+efNF6IFcJL8clkzbLL/Z145OnuBOeysCWtCsKQO?= =?us-ascii?Q?gj0faCR7uzfGf5uBzefdRD+6ZX383QK5/XzesHLSKs87dPOsn8NjeNVAuVUB?= =?us-ascii?Q?Pqc0THkNFfwnEX9Ds+pQrEFyDXNKkS3ZQvMMkZKoWj5Z2t3217hwUmAKAVS+?= =?us-ascii?Q?gokXFTaEkrd9ijV+yazy5fltn3Et15rqOccxzKeKdVFHxdY2iEaGQG2qwSLI?= =?us-ascii?Q?ua2k5wG4gEaOCMkizaRiVt/t6ztIfEG8Lg3+8AFuh2i6BvX8jQYN5WkAFtNa?= =?us-ascii?Q?IoDYsn0Pz8CmNdHkodkL3fzsyCEkpykF?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(7416014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rLLPPO/CFV37ELDTgPJ+4MNrrinFQtWj4Rn3llDlKBuiLEEX0ao/EEV3I/8n?= =?us-ascii?Q?sT8d3iAimU9gJ0TpeyabxBR94KffC05c5wfq/SVAE4uPNmExv73P8EAH97cc?= =?us-ascii?Q?Q80asQDfAN8ysvM2sI7E0j8d+hJJY9JoD491qDReDZKqvfFL4SznKX8vK8+F?= =?us-ascii?Q?g65eEQ17NKDqEm/x/YKIn9FlTVT1mLif4CGUcvc3f48r1g7x0R6fnScokUbD?= =?us-ascii?Q?Ay4iniVqYHRUyJo10I3bVpRtfpM2s4rHTtd/F8bPG5t08pFHc13tEDJHbFYg?= =?us-ascii?Q?bCjcpdzvYW4FTVaSDoy9GPB57CwuvgMpr081PO8NYd5lV0R7nEnQVklxGgSU?= =?us-ascii?Q?lRMgqlt0dB/mLZJmHJq0CTutkW0HWAFmuGG8cz6QuDDobZ4+9ek76hVQBHKp?= =?us-ascii?Q?v0fIEUVkv1L72HdEalvpmkoUVszIem7WmzNeoDJT0K6eQWeXSAsyMzwlYtV8?= =?us-ascii?Q?YsHkHqU4khrhyxhyprzqxfN9HyfJ+v+EtffWJtd8Qu3tVEh/8pAQS5B3jei/?= =?us-ascii?Q?Z+QmO2Pmpfo7f2XeTXrRvJ1JTooQrDSrvUWWaHdOFUcL4yvkQ9qwaGcQkKZU?= =?us-ascii?Q?tyK/7yBXitDg8i+3c1H2xgJNDAI9G5ixOY6D4kkZJHyycMo84+ga5DmPPSSV?= =?us-ascii?Q?HttmGKuHuKwzLdi+z/U/FT2o0AeYENYASOKOuOq6glagCUOQM93ou5PNOPTh?= =?us-ascii?Q?Q4OXMpEvewvnY2Ck7Ps9YoYvDJiCp81OqrxUTFjWjYWTzXRCKlINo26Uh3c/?= =?us-ascii?Q?xGMtVa6LnagVEAiWRUvwUZwVSI2cIrV+RoQ12z4jXg1tC7RkVzgycR1rzXiE?= =?us-ascii?Q?cvXMG0tVxgWwT7YrggjChj3ie6KqP2AoBuyJ6qmZSfDUZ2iVUuFMrAkaOs3t?= =?us-ascii?Q?ltcdhnDJO5nsHSu7uRqZuURaUNc0WXJcdYcN+kvZgGnqWzw6JFG62WnGE3Zt?= =?us-ascii?Q?Xyf3uQ5B4sYfoIHaQLuZaNqeNBZWx4mQhYsu1H+3SQk71C5EAFom93lWcCT0?= =?us-ascii?Q?4dy9orfPNiiaKvMZTSdYtCjEiLl6w8OJVzjigcHF+iW1+aqUd1NczxcTB5bY?= =?us-ascii?Q?p86Stj0uY1UlRlD4dQtpmuqtgoRtFHRfj9cc2rzH8EIAztq0CFJHSGOQlXpm?= =?us-ascii?Q?i7/Z0mqw2qSJCTFGO5/40BXBkG1SN+NfyV7/E0NUMdiw3BWLiSz4Dltoz7cl?= =?us-ascii?Q?41lAzfP9Ny6iwf4QGfS3zVTnrPn0uCRo6qp69dmtig32EMu5qjCMlpYBgvXJ?= =?us-ascii?Q?N0D/KxCEvQH3LgOHKERO6GMGxPuwQHApmcT0JDZ2oDm+MYi6OdrJirdBGSgz?= =?us-ascii?Q?v82l/1+RtP1b+OpwpLro8cciQughaji4pQyOrzc0MWSP9S2wOJNULNCNYSFa?= =?us-ascii?Q?IyuDTGBHHIK1WdW0AWg5d/jfUrXGMOfyt3ofQoXROuVzt7sf8zjphJXTaIFN?= =?us-ascii?Q?gvbDFn0LsTn0v5YfMclFCixpSpJVKQPKuGoHGhRQjVZXnmF2IFWdkGT5aBXD?= =?us-ascii?Q?pz2zMEbFWQ9c5n92jO3jLdwkHN5BNqXYu3PNUzfZdnHUgtpTHE9bJNIo+NUh?= =?us-ascii?Q?0uLWLQfUK/Kr8aCCorvYMorvzYYjVhpLVw1UWjrm?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51d6234e-adc4-4bcd-d0d4-08dd5a9e9d2c X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2025 21:59:04.6052 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e4/gblCtvDGd4ogdnfgEiis5j6LZl63LDXOLzfKMUl/4gq2MqtN7Q+0X7sO2lS3wNbx53mMCEKGPr11d9qjrvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB9910 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250303_135907_414987_82E5D1D4 X-CRM114-Status: GOOD ( 26.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 26, 2025 at 05:33:39PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 28, 2025 at 05:07:37PM -0500, Frank Li wrote: > > parent_bus_offset in resource_entry can indicate address information just > > ahead of PCIe controller. Most system's bus fabric use 1:1 map between > > input and output address. but some hardware like i.MX8QXP doesn't use 1:1 > > map. See below diagram: > > ... > > > @@ -448,6 +451,26 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) > > if (IS_ERR(pp->va_cfg0_base)) > > return PTR_ERR(pp->va_cfg0_base); > > > > + if (pci->use_parent_dt_ranges) { > > + if (pci->ops->cpu_addr_fixup) { > > + dev_err(dev, "Use parent bus DT ranges, cpu_addr_fixup() must be removed\n"); > > + return -EINVAL; > > + } > > + > > + index = of_property_match_string(np, "reg-names", "config"); > > + if (index < 0) > > + return -EINVAL; > > + > > + /* > > + * Retrieve the parent bus address of PCI config space. > > + * If the parent bus ranges in the device tree provide > > + * the correct address conversion information, set > > + * 'use_parent_dt_ranges' to true, The > > + * 'cpu_addr_fixup()' can be eliminated. > > + */ > > + of_property_read_reg(np, index, &pp->cfg0_base, NULL); > > + } > > I think all this code dealing with the "config" resource could go in a > helper function. It's kind of a lot of clutter in > dw_pcie_host_init(). > > It would be nice to assign pp->cfg0_base once, not assign res->start > to it and then possibly overwrite it later. > > > @@ -841,6 +841,15 @@ void dw_pcie_iatu_detect(struct dw_pcie *pci) > > pci->region_align = 1 << fls(min); > > pci->region_limit = (max << 32) | (SZ_4G - 1); > > > > + if (pci->ops && pci->ops->cpu_addr_fixup) { > > + /* > > + * If the parent 'ranges' property in DT correctly describes > > + * the address translation, cpu_addr_fixup() callback is not > > + * needed. > > + */ > > + dev_warn_once(pci->dev, "cpu_addr_fixup() usage detected. Please fix DT!\n"); > > + } > > Can you split the warnings out to a separate patch? I think we should > warn once in every initialization path where .cpu_addr_fixup() could > be used, i.e., > > dw_pcie_host_init() > dw_pcie_ep_init() > cdns_pcie_host_setup() > cdns_pcie_ep_setup() > > IMO these should warn if .cpu_addr_fixup() is implemented, regardless > of use_parent_dt_ranges. > > I'm still puzzling over some of the rest of this, so no need to post a > revised series yet. Do you have additional comments, so I can post a revised series? Frank > > Bjorn