From: Sudeep Holla <sudeep.holla@arm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Hugues KAMBA MPIANA <hugues.kambampiana@arm.com>,
conor+dt@kernel.org, Sudeep Holla <sudeep.holla@arm.com>,
devicetree@vger.kernel.org, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, liviu.dudau@arm.com,
lpieralisi@kernel.org, robh@kernel.org
Subject: Re: [PATCH v2] arm64: dts: corstone1000: Add definitions for secondary CPU cores
Date: Tue, 4 Mar 2025 10:30:24 +0000 [thread overview]
Message-ID: <Z8bWQDVebIehuftS@bogus> (raw)
In-Reply-To: <f6c7feb3-e003-4bbc-8179-3a3df533d2d5@kernel.org>
On Tue, Mar 04, 2025 at 11:12:57AM +0100, Krzysztof Kozlowski wrote:
> On 04/03/2025 11:08, Sudeep Holla wrote:
> > On Mon, 03 Mar 2025 17:00:12 +0000, Hugues KAMBA MPIANA wrote:
> >> Add `cpu1`, `cpu2` and `cpu3` nodes to the Corstone1000 device tree to
> >> enable support for secondary CPU cores.
> >>
> >> This update facilitates symmetric multiprocessing (SMP) support on
> >> the Corstone1000 Fixed Virtual Platform (FVP), allowing the
> >> secondary cores to be properly initialised and utilised.
> >>
> >> [...]
> >
> > Applied to sudeep.holla/linux (for-next/juno/updates), thanks!
> >
> > [1/1] arm64: dts: corstone1000: Add definitions for secondary CPU cores
> > https://git.kernel.org/sudeep.holla/c/21b9f56cec8f
>
> Why? Nothing improved here comparing to v1.
>
> Your comment are still valid and the patch is still not correct.
>
It was not marked clearly or noted as change. I agree that is confusing.
However the following was added:
"Only FVP platform will have SMP support and hence the secondary cpu
definitions are not added to corstone1000.dtsi"
Hugues pinged me in private to explain why it is done in that way and I
asked him to add the reasoning in the commit message which he did but
failed to capture in the v1->v2 changelog. I mentioned it in private
again as he is new contributor to the kernel, I was less strict on him 😉.
--
Regards,
Sudeep
next prev parent reply other threads:[~2025-03-04 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 15:37 [PATCH] arm64: dts: corstone1000: Add definitions for secondary CPU cores Hugues KAMBA MPIANA
2025-03-03 16:00 ` Sudeep Holla
2025-03-03 17:00 ` [PATCH v2] " Hugues KAMBA MPIANA
2025-03-04 10:08 ` Sudeep Holla
2025-03-04 10:12 ` Krzysztof Kozlowski
2025-03-04 10:30 ` Sudeep Holla [this message]
2025-03-04 10:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8bWQDVebIehuftS@bogus \
--to=sudeep.holla@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hugues.kambampiana@arm.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).