From: Sudeep Holla <sudeep.holla@arm.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
soc@lists.linux.dev, Sudeep Holla <sudeep.holla@arm.com>,
Arnd Bergmann <arnd@arndb.de>, Luke Parkin <luke.parkin@arm.com>,
Peng Fan <peng.fan@nxp.com>,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: use ioread64() instead of ioread64_hi_lo()
Date: Tue, 4 Mar 2025 15:28:32 +0000 [thread overview]
Message-ID: <Z8ccIBTgn6n7CYXh@bogus> (raw)
In-Reply-To: <20250304144346.1025658-1-arnd@kernel.org>
Hi Arnd,
On Tue, Mar 04, 2025 at 03:43:34PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The scmi_common_fastchannel_db_ring() function calls either ioread64()
> or ioread64_hi_lo() depending on whether it is compiler for 32-bit
> or 64-bit architectures.
>
> The same logic is used to define ioread64() itself in the
> linux/io-64-nonatomic-hi-lo.h header file, so the special case
> is not really needed.
>
> The behavior here should not change at all.
LGTM. I just sent PR for v6.15 this morning. Either I can redo PR with
this included or you can just apply this directly. I am fine either way.
If you go for the latter approach,
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
If you prefer me to send updated PR, let me know. I don't want to create
confusion by recalling by PR and sending an updated one without consulting
you.
--
Regards,
Sudeep
prev parent reply other threads:[~2025-03-04 16:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 14:43 [PATCH] firmware: arm_scmi: use ioread64() instead of ioread64_hi_lo() Arnd Bergmann
2025-03-04 15:28 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8ccIBTgn6n7CYXh@bogus \
--to=sudeep.holla@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke.parkin@arm.com \
--cc=peng.fan@nxp.com \
--cc=soc@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).