* [PATCH v7 0/5] Driver for pre-DCP apple display controller.
@ 2025-02-17 11:39 Sasha Finkelstein via B4 Relay
2025-02-17 11:39 ` [PATCH v7 1/5] dt-bindings: display: Add Apple pre-DCP " Sasha Finkelstein via B4 Relay
` (7 more replies)
0 siblings, 8 replies; 19+ messages in thread
From: Sasha Finkelstein via B4 Relay @ 2025-02-17 11:39 UTC (permalink / raw)
To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Jessica Zhang, asahi, Janne Grunau
Cc: linux-arm-kernel, dri-devel, devicetree, linux-kernel,
Alyssa Ross, Sasha Finkelstein, Krzysztof Kozlowski, Neal Gompa,
Dmitry Baryshkov, Nick Chan
Hi.
This patch series adds support for a secondary display controller
present on Apple M1/M2 chips and used to drive the display of the
"touchbar" touch panel present on those.
Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
---
Changes in v7:
- No changes aside from adding r-b trailers, effectively a resend.
- Link to v6: https://lore.kernel.org/r/20250206-adpdrm-v6-0-c8ab9348b853@gmail.com
Changes in v6:
- Use the drm_connector_helper_get_modes_fixed helper.
- Split out into a separate MAINTAINERS entry
- Link to v5: https://lore.kernel.org/r/20250205-adpdrm-v5-0-4e4ec979bbf2@gmail.com
Changes in v5:
- Moved to using the component framework.
- Other lifetime fixes
- Link to v4: https://lore.kernel.org/r/20250114-adpdrm-v4-0-e9b5260a39f1@gmail.com
Changes in v4:
- Fixed dt bindings.
- Link to v3: https://lore.kernel.org/r/20250112-adpdrm-v3-0-c674dc19fa7f@gmail.com
Changes in v3:
- Fixed building as module after splitting out mipi block
- Addressing the review feedback.
- Link to v2: https://lore.kernel.org/r/20241126-adpdrm-v2-0-c90485336c09@gmail.com
Changes in v2:
- Addressing the review feedback.
- Split out the mipi part of the display controller into a separate device
- Link to v1: https://lore.kernel.org/r/20241124-adpdrm-v1-0-3191d8e6e49a@gmail.com
---
Sasha Finkelstein (5):
dt-bindings: display: Add Apple pre-DCP display controller
drm: adp: Add Apple Display Pipe driver
drm: panel: Add a panel driver for the Summit display
arm64: dts: apple: Add touchbar screen nodes
MAINTAINERS: Add entries for touchbar display driver
.../display/apple,h7-display-pipe-mipi.yaml | 83 +++
.../bindings/display/apple,h7-display-pipe.yaml | 88 +++
.../bindings/display/panel/apple,summit.yaml | 58 ++
MAINTAINERS | 16 +
arch/arm64/boot/dts/apple/t8103-j293.dts | 31 ++
arch/arm64/boot/dts/apple/t8103.dtsi | 61 ++
arch/arm64/boot/dts/apple/t8112-j493.dts | 31 ++
arch/arm64/boot/dts/apple/t8112.dtsi | 61 ++
drivers/gpu/drm/Kconfig | 2 +
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/drm/adp/Kconfig | 17 +
drivers/gpu/drm/adp/Makefile | 5 +
drivers/gpu/drm/adp/adp-mipi.c | 276 +++++++++
drivers/gpu/drm/adp/adp_drv.c | 617 +++++++++++++++++++++
drivers/gpu/drm/panel/Kconfig | 9 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-summit.c | 132 +++++
17 files changed, 1489 insertions(+)
---
base-commit: b62cef9a5c673f1b8083159f5dc03c1c5daced2f
change-id: 20241124-adpdrm-25fce3dd8a71
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH v7 1/5] dt-bindings: display: Add Apple pre-DCP display controller 2025-02-17 11:39 [PATCH v7 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay @ 2025-02-17 11:39 ` Sasha Finkelstein via B4 Relay 2025-02-17 11:39 ` [PATCH v7 2/5] drm: adp: Add Apple Display Pipe driver Sasha Finkelstein via B4 Relay ` (6 subsequent siblings) 7 siblings, 0 replies; 19+ messages in thread From: Sasha Finkelstein via B4 Relay @ 2025-02-17 11:39 UTC (permalink / raw) To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jessica Zhang, asahi, Janne Grunau Cc: linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Sasha Finkelstein, Krzysztof Kozlowski, Neal Gompa From: Sasha Finkelstein <fnkl.kernel@gmail.com> Add bindings for a secondary display controller present on certain Apple laptops. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Neal Gompa <neal@gompa.dev> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> --- .../display/apple,h7-display-pipe-mipi.yaml | 83 ++++++++++++++++++++ .../bindings/display/apple,h7-display-pipe.yaml | 88 ++++++++++++++++++++++ .../bindings/display/panel/apple,summit.yaml | 58 ++++++++++++++ 3 files changed, 229 insertions(+) diff --git a/Documentation/devicetree/bindings/display/apple,h7-display-pipe-mipi.yaml b/Documentation/devicetree/bindings/display/apple,h7-display-pipe-mipi.yaml new file mode 100644 index 0000000000000000000000000000000000000000..5e6da66499a508c001670f68fa00d6bab13591d6 --- /dev/null +++ b/Documentation/devicetree/bindings/display/apple,h7-display-pipe-mipi.yaml @@ -0,0 +1,83 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/apple,h7-display-pipe-mipi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple pre-DCP display controller MIPI interface + +maintainers: + - Sasha Finkelstein <fnkl.kernel@gmail.com> + +description: + The MIPI controller part of the pre-DCP Apple display controller + +allOf: + - $ref: dsi-controller.yaml# + +properties: + compatible: + items: + - enum: + - apple,t8112-display-pipe-mipi + - apple,t8103-display-pipe-mipi + - const: apple,h7-display-pipe-mipi + + reg: + maxItems: 1 + + power-domains: + maxItems: 1 + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: Input port. Always connected to the primary controller + + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: Output MIPI DSI port to the panel + + required: + - port@0 + - port@1 + +required: + - compatible + - reg + - ports + +unevaluatedProperties: false + +examples: + - | + dsi@28200000 { + compatible = "apple,t8103-display-pipe-mipi", "apple,h7-display-pipe-mipi"; + reg = <0x28200000 0xc000>; + power-domains = <&ps_dispdfr_mipi>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + dfr_adp_out_mipi: endpoint { + remote-endpoint = <&dfr_adp_out_mipi>; + }; + }; + + port@1 { + reg = <1>; + + dfr_panel_in: endpoint { + remote-endpoint = <&dfr_mipi_out_panel>; + }; + }; + }; + }; +... diff --git a/Documentation/devicetree/bindings/display/apple,h7-display-pipe.yaml b/Documentation/devicetree/bindings/display/apple,h7-display-pipe.yaml new file mode 100644 index 0000000000000000000000000000000000000000..102fb1804c0c0b84f590e507ca2d526948e98f68 --- /dev/null +++ b/Documentation/devicetree/bindings/display/apple,h7-display-pipe.yaml @@ -0,0 +1,88 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/apple,h7-display-pipe.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple pre-DCP display controller + +maintainers: + - Sasha Finkelstein <fnkl.kernel@gmail.com> + +description: + A secondary display controller used to drive the "touchbar" on + certain Apple laptops. + +properties: + compatible: + items: + - enum: + - apple,t8112-display-pipe + - apple,t8103-display-pipe + - const: apple,h7-display-pipe + + reg: + items: + - description: Primary register block, controls planes and blending + - description: + Contains other configuration registers like interrupt + and FIFO control + + reg-names: + items: + - const: be + - const: fe + + power-domains: + description: + Phandles to pmgr entries that are needed for this controller to turn on. + Aside from that, their specific functions are unknown + maxItems: 2 + + interrupts: + items: + - description: Unknown function + - description: Primary interrupt. Vsync events are reported via it + + interrupt-names: + items: + - const: be + - const: fe + + iommus: + maxItems: 1 + + port: + $ref: /schemas/graph.yaml#/properties/port + description: Output port. Always connected to apple,h7-display-pipe-mipi + +required: + - compatible + - reg + - interrupts + - port + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/apple-aic.h> + display-pipe@28200000 { + compatible = "apple,t8103-display-pipe", "apple,h7-display-pipe"; + reg = <0x28200000 0xc000>, + <0x28400000 0x4000>; + reg-names = "be", "fe"; + power-domains = <&ps_dispdfr_fe>, <&ps_dispdfr_be>; + interrupt-parent = <&aic>; + interrupts = <AIC_IRQ 502 IRQ_TYPE_LEVEL_HIGH>, + <AIC_IRQ 506 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "be", "fe"; + iommus = <&displaydfr_dart 0>; + + port { + dfr_adp_out_mipi: endpoint { + remote-endpoint = <&dfr_mipi_in_adp>; + }; + }; + }; +... diff --git a/Documentation/devicetree/bindings/display/panel/apple,summit.yaml b/Documentation/devicetree/bindings/display/panel/apple,summit.yaml new file mode 100644 index 0000000000000000000000000000000000000000..f081755325e97ad58b831893b84082cc10f8d5e3 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/apple,summit.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/apple,summit.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple "Summit" display panel + +maintainers: + - Sasha Finkelstein <fnkl.kernel@gmail.com> + +description: + An OLED panel used as a touchbar on certain Apple laptops. + Contains a backlight device, which controls brightness of the panel itself. + The backlight common properties are included for this reason + +allOf: + - $ref: panel-common.yaml# + - $ref: /schemas/leds/backlight/common.yaml# + +properties: + compatible: + items: + - enum: + - apple,j293-summit + - apple,j493-summit + - const: apple,summit + + reg: + maxItems: 1 + +required: + - compatible + - reg + - max-brightness + - port + +unevaluatedProperties: false + +examples: + - | + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "apple,j293-summit", "apple,summit"; + reg = <0>; + max-brightness = <255>; + + port { + endpoint { + remote-endpoint = <&dfr_bridge_out>; + }; + }; + }; + }; +... -- 2.48.1 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v7 2/5] drm: adp: Add Apple Display Pipe driver 2025-02-17 11:39 [PATCH v7 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay 2025-02-17 11:39 ` [PATCH v7 1/5] dt-bindings: display: Add Apple pre-DCP " Sasha Finkelstein via B4 Relay @ 2025-02-17 11:39 ` Sasha Finkelstein via B4 Relay 2025-02-17 13:22 ` Thomas Zimmermann 2025-02-17 11:39 ` [PATCH v7 3/5] drm: panel: Add a panel driver for the Summit display Sasha Finkelstein via B4 Relay ` (5 subsequent siblings) 7 siblings, 1 reply; 19+ messages in thread From: Sasha Finkelstein via B4 Relay @ 2025-02-17 11:39 UTC (permalink / raw) To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jessica Zhang, asahi, Janne Grunau Cc: linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Sasha Finkelstein, Dmitry Baryshkov, Neal Gompa From: Sasha Finkelstein <fnkl.kernel@gmail.com> This display controller is present on M-series chips and is used to drive the touchbar display. Co-developed-by: Janne Grunau <j@jannau.net> Signed-off-by: Janne Grunau <j@jannau.net> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Neal Gompa <neal@gompa.dev> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/adp/Kconfig | 17 ++ drivers/gpu/drm/adp/Makefile | 5 + drivers/gpu/drm/adp/adp-mipi.c | 276 ++++++++++++++++++ drivers/gpu/drm/adp/adp_drv.c | 617 +++++++++++++++++++++++++++++++++++++++++ 6 files changed, 918 insertions(+) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 772fc7625639de07de873afa0e5e0c37bf4f4420..bba7a9c1f1d213c9cf0418a388646da7a8504f4f 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -503,6 +503,8 @@ source "drivers/gpu/drm/mcde/Kconfig" source "drivers/gpu/drm/tidss/Kconfig" +source "drivers/gpu/drm/adp/Kconfig" + source "drivers/gpu/drm/xlnx/Kconfig" source "drivers/gpu/drm/gud/Kconfig" diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 463afad1b5ca6275e61223adc8ca036c3d4d6b03..acd8d8943ef2bf85c80db7c218c59a7ec2df56da 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -213,6 +213,7 @@ obj-y += mxsfb/ obj-y += tiny/ obj-$(CONFIG_DRM_PL111) += pl111/ obj-$(CONFIG_DRM_TVE200) += tve200/ +obj-$(CONFIG_DRM_ADP) += adp/ obj-$(CONFIG_DRM_XEN) += xen/ obj-$(CONFIG_DRM_VBOXVIDEO) += vboxvideo/ obj-$(CONFIG_DRM_LIMA) += lima/ diff --git a/drivers/gpu/drm/adp/Kconfig b/drivers/gpu/drm/adp/Kconfig new file mode 100644 index 0000000000000000000000000000000000000000..9fcc27eb200dbc5c3005d732b937b45e2dde66ac --- /dev/null +++ b/drivers/gpu/drm/adp/Kconfig @@ -0,0 +1,17 @@ +# SPDX-License-Identifier: GPL-2.0-only OR MIT +config DRM_ADP + tristate "DRM Support for pre-DCP Apple display controllers" + depends on DRM && OF && ARM64 + depends on ARCH_APPLE || COMPILE_TEST + select DRM_KMS_HELPER + select DRM_BRIDGE_CONNECTOR + select DRM_DISPLAY_HELPER + select DRM_KMS_DMA_HELPER + select DRM_GEM_DMA_HELPER + select DRM_PANEL_BRIDGE + select VIDEOMODE_HELPERS + select DRM_MIPI_DSI + help + Chose this option if you have an Apple Arm laptop with a touchbar. + + If M is selected, this module will be called adpdrm. diff --git a/drivers/gpu/drm/adp/Makefile b/drivers/gpu/drm/adp/Makefile new file mode 100644 index 0000000000000000000000000000000000000000..8e7b618edd35591ce9b480a8fd3819cce41557f5 --- /dev/null +++ b/drivers/gpu/drm/adp/Makefile @@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-only OR MIT + +adpdrm-y := adp_drv.o +adpdrm-mipi-y := adp-mipi.o +obj-$(CONFIG_DRM_ADP) += adpdrm.o adpdrm-mipi.o diff --git a/drivers/gpu/drm/adp/adp-mipi.c b/drivers/gpu/drm/adp/adp-mipi.c new file mode 100644 index 0000000000000000000000000000000000000000..ad80542b60ed6de3fe76a4d134b87d20df98ee33 --- /dev/null +++ b/drivers/gpu/drm/adp/adp-mipi.c @@ -0,0 +1,276 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include <linux/component.h> +#include <linux/iopoll.h> +#include <linux/of.h> +#include <linux/platform_device.h> + +#include <drm/drm_bridge.h> +#include <drm/drm_mipi_dsi.h> + +#define DSI_GEN_HDR 0x6c +#define DSI_GEN_PLD_DATA 0x70 + +#define DSI_CMD_PKT_STATUS 0x74 + +#define GEN_PLD_R_EMPTY BIT(4) +#define GEN_PLD_W_FULL BIT(3) +#define GEN_PLD_W_EMPTY BIT(2) +#define GEN_CMD_FULL BIT(1) +#define GEN_CMD_EMPTY BIT(0) +#define GEN_RD_CMD_BUSY BIT(6) +#define CMD_PKT_STATUS_TIMEOUT_US 20000 + +struct adp_mipi_drv_private { + struct mipi_dsi_host dsi; + struct drm_bridge bridge; + struct drm_bridge *next_bridge; + void __iomem *mipi; +}; + +#define mipi_to_adp(x) container_of(x, struct adp_mipi_drv_private, dsi) + +static int adp_dsi_gen_pkt_hdr_write(struct adp_mipi_drv_private *adp, u32 hdr_val) +{ + int ret; + u32 val, mask; + + ret = readl_poll_timeout(adp->mipi + DSI_CMD_PKT_STATUS, + val, !(val & GEN_CMD_FULL), 1000, + CMD_PKT_STATUS_TIMEOUT_US); + if (ret) { + dev_err(adp->dsi.dev, "failed to get available command FIFO\n"); + return ret; + } + + writel(hdr_val, adp->mipi + DSI_GEN_HDR); + + mask = GEN_CMD_EMPTY | GEN_PLD_W_EMPTY; + ret = readl_poll_timeout(adp->mipi + DSI_CMD_PKT_STATUS, + val, (val & mask) == mask, + 1000, CMD_PKT_STATUS_TIMEOUT_US); + if (ret) { + dev_err(adp->dsi.dev, "failed to write command FIFO\n"); + return ret; + } + + return 0; +} + +static int adp_dsi_write(struct adp_mipi_drv_private *adp, + const struct mipi_dsi_packet *packet) +{ + const u8 *tx_buf = packet->payload; + int len = packet->payload_length, pld_data_bytes = sizeof(u32), ret; + __le32 word; + u32 val; + + while (len) { + if (len < pld_data_bytes) { + word = 0; + memcpy(&word, tx_buf, len); + writel(le32_to_cpu(word), adp->mipi + DSI_GEN_PLD_DATA); + len = 0; + } else { + memcpy(&word, tx_buf, pld_data_bytes); + writel(le32_to_cpu(word), adp->mipi + DSI_GEN_PLD_DATA); + tx_buf += pld_data_bytes; + len -= pld_data_bytes; + } + + ret = readl_poll_timeout(adp->mipi + DSI_CMD_PKT_STATUS, + val, !(val & GEN_PLD_W_FULL), 1000, + CMD_PKT_STATUS_TIMEOUT_US); + if (ret) { + dev_err(adp->dsi.dev, + "failed to get available write payload FIFO\n"); + return ret; + } + } + + word = 0; + memcpy(&word, packet->header, sizeof(packet->header)); + return adp_dsi_gen_pkt_hdr_write(adp, le32_to_cpu(word)); +} + +static int adp_dsi_read(struct adp_mipi_drv_private *adp, + const struct mipi_dsi_msg *msg) +{ + int i, j, ret, len = msg->rx_len; + u8 *buf = msg->rx_buf; + u32 val; + + /* Wait end of the read operation */ + ret = readl_poll_timeout(adp->mipi + DSI_CMD_PKT_STATUS, + val, !(val & GEN_RD_CMD_BUSY), + 1000, CMD_PKT_STATUS_TIMEOUT_US); + if (ret) { + dev_err(adp->dsi.dev, "Timeout during read operation\n"); + return ret; + } + + for (i = 0; i < len; i += 4) { + /* Read fifo must not be empty before all bytes are read */ + ret = readl_poll_timeout(adp->mipi + DSI_CMD_PKT_STATUS, + val, !(val & GEN_PLD_R_EMPTY), + 1000, CMD_PKT_STATUS_TIMEOUT_US); + if (ret) { + dev_err(adp->dsi.dev, "Read payload FIFO is empty\n"); + return ret; + } + + val = readl(adp->mipi + DSI_GEN_PLD_DATA); + for (j = 0; j < 4 && j + i < len; j++) + buf[i + j] = val >> (8 * j); + } + + return ret; +} + +static ssize_t adp_dsi_host_transfer(struct mipi_dsi_host *host, + const struct mipi_dsi_msg *msg) +{ + struct adp_mipi_drv_private *adp = mipi_to_adp(host); + struct mipi_dsi_packet packet; + int ret, nb_bytes; + + ret = mipi_dsi_create_packet(&packet, msg); + if (ret) { + dev_err(adp->dsi.dev, "failed to create packet: %d\n", ret); + return ret; + } + + ret = adp_dsi_write(adp, &packet); + if (ret) + return ret; + + if (msg->rx_buf && msg->rx_len) { + ret = adp_dsi_read(adp, msg); + if (ret) + return ret; + nb_bytes = msg->rx_len; + } else { + nb_bytes = packet.size; + } + + return nb_bytes; +} + +static int adp_dsi_bind(struct device *dev, struct device *master, void *data) +{ + return 0; +} + +static void adp_dsi_unbind(struct device *dev, struct device *master, void *data) +{ +} + +static const struct component_ops adp_dsi_component_ops = { + .bind = adp_dsi_bind, + .unbind = adp_dsi_unbind, +}; + +static int adp_dsi_host_attach(struct mipi_dsi_host *host, + struct mipi_dsi_device *dev) +{ + struct adp_mipi_drv_private *adp = mipi_to_adp(host); + struct drm_bridge *next; + int ret; + + next = devm_drm_of_get_bridge(adp->dsi.dev, adp->dsi.dev->of_node, 1, 0); + if (IS_ERR(next)) + return PTR_ERR(next); + + adp->next_bridge = next; + + drm_bridge_add(&adp->bridge); + + ret = component_add(host->dev, &adp_dsi_component_ops); + if (ret) { + pr_err("failed to add dsi_host component: %d\n", ret); + drm_bridge_remove(&adp->bridge); + return ret; + } + + return 0; +} + +static int adp_dsi_host_detach(struct mipi_dsi_host *host, + struct mipi_dsi_device *dev) +{ + struct adp_mipi_drv_private *adp = mipi_to_adp(host); + + component_del(host->dev, &adp_dsi_component_ops); + drm_bridge_remove(&adp->bridge); + return 0; +} + +static const struct mipi_dsi_host_ops adp_dsi_host_ops = { + .transfer = adp_dsi_host_transfer, + .attach = adp_dsi_host_attach, + .detach = adp_dsi_host_detach, +}; + +static int adp_dsi_bridge_attach(struct drm_bridge *bridge, + enum drm_bridge_attach_flags flags) +{ + struct adp_mipi_drv_private *adp = + container_of(bridge, struct adp_mipi_drv_private, bridge); + + return drm_bridge_attach(bridge->encoder, adp->next_bridge, bridge, flags); +} + +static const struct drm_bridge_funcs adp_dsi_bridge_funcs = { + .attach = adp_dsi_bridge_attach, +}; + +static int adp_mipi_probe(struct platform_device *pdev) +{ + struct adp_mipi_drv_private *adp; + + adp = devm_kzalloc(&pdev->dev, sizeof(*adp), GFP_KERNEL); + if (!adp) + return -ENOMEM; + + adp->mipi = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(adp->mipi)) { + dev_err(&pdev->dev, "failed to map mipi mmio"); + return PTR_ERR(adp->mipi); + } + + adp->dsi.dev = &pdev->dev; + adp->dsi.ops = &adp_dsi_host_ops; + adp->bridge.funcs = &adp_dsi_bridge_funcs; + adp->bridge.of_node = pdev->dev.of_node; + adp->bridge.type = DRM_MODE_CONNECTOR_DSI; + dev_set_drvdata(&pdev->dev, adp); + return mipi_dsi_host_register(&adp->dsi); +} + +static void adp_mipi_remove(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct adp_mipi_drv_private *adp = dev_get_drvdata(dev); + + mipi_dsi_host_unregister(&adp->dsi); +} + +static const struct of_device_id adp_mipi_of_match[] = { + { .compatible = "apple,h7-display-pipe-mipi", }, + { }, +}; +MODULE_DEVICE_TABLE(of, adp_mipi_of_match); + +static struct platform_driver adp_mipi_platform_driver = { + .driver = { + .name = "adp-mipi", + .of_match_table = adp_mipi_of_match, + }, + .probe = adp_mipi_probe, + .remove = adp_mipi_remove, +}; + +module_platform_driver(adp_mipi_platform_driver); + +MODULE_DESCRIPTION("Apple Display Pipe MIPI driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/gpu/drm/adp/adp_drv.c b/drivers/gpu/drm/adp/adp_drv.c new file mode 100644 index 0000000000000000000000000000000000000000..33fad8ee3331c681d1c10757e4dd17ba5f8f9904 --- /dev/null +++ b/drivers/gpu/drm/adp/adp_drv.c @@ -0,0 +1,617 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include <linux/component.h> +#include <linux/iopoll.h> +#include <linux/of.h> +#include <linux/platform_device.h> + +#include <drm/drm_atomic.h> +#include <drm/drm_atomic_helper.h> +#include <drm/drm_bridge.h> +#include <drm/drm_bridge_connector.h> +#include <drm/drm_drv.h> +#include <drm/drm_fb_dma_helper.h> +#include <drm/drm_framebuffer.h> +#include <drm/drm_gem_atomic_helper.h> +#include <drm/drm_gem_dma_helper.h> +#include <drm/drm_gem_framebuffer_helper.h> +#include <drm/drm_of.h> +#include <drm/drm_probe_helper.h> +#include <drm/drm_vblank.h> + +#define ADP_INT_STATUS 0x34 +#define ADP_INT_STATUS_INT_MASK 0x7 +#define ADP_INT_STATUS_VBLANK 0x1 +#define ADP_CTRL 0x100 +#define ADP_CTRL_VBLANK_ON 0x12 +#define ADP_CTRL_FIFO_ON 0x601 +#define ADP_SCREEN_SIZE 0x0c +#define ADP_SCREEN_HSIZE GENMASK(15, 0) +#define ADP_SCREEN_VSIZE GENMASK(31, 16) + +#define ADBE_FIFO 0x10c0 +#define ADBE_FIFO_SYNC 0xc0000000 + +#define ADBE_BLEND_BYPASS 0x2020 +#define ADBE_BLEND_EN1 0x2028 +#define ADBE_BLEND_EN2 0x2074 +#define ADBE_BLEND_EN3 0x202c +#define ADBE_BLEND_EN4 0x2034 +#define ADBE_MASK_BUF 0x2200 + +#define ADBE_SRC_START 0x4040 +#define ADBE_SRC_SIZE 0x4048 +#define ADBE_DST_START 0x4050 +#define ADBE_DST_SIZE 0x4054 +#define ADBE_STRIDE 0x4038 +#define ADBE_FB_BASE 0x4030 + +#define ADBE_LAYER_EN1 0x4020 +#define ADBE_LAYER_EN2 0x4068 +#define ADBE_LAYER_EN3 0x40b4 +#define ADBE_LAYER_EN4 0x40f4 +#define ADBE_SCALE_CTL 0x40ac +#define ADBE_SCALE_CTL_BYPASS 0x100000 + +#define ADBE_LAYER_CTL 0x1038 +#define ADBE_LAYER_CTL_ENABLE 0x10000 + +#define ADBE_PIX_FMT 0x402c +#define ADBE_PIX_FMT_XRGB32 0x53e4001 + +static int adp_open(struct inode *inode, struct file *filp) +{ + /* + * The modesetting driver does not check the non-desktop connector + * property and keeps the device open and locked. If the touchbar daemon + * opens the device first modesetting breaks the whole X session. + * Simply refuse to open the device for X11 server processes as + * workaround. + */ + if (current->comm[0] == 'X') + return -EBUSY; + + return drm_open(inode, filp); +} + +static const struct file_operations adp_fops = { + .owner = THIS_MODULE, + .open = adp_open, + .release = drm_release, + .unlocked_ioctl = drm_ioctl, + .compat_ioctl = drm_compat_ioctl, + .poll = drm_poll, + .read = drm_read, + .llseek = noop_llseek, + .mmap = drm_gem_mmap, + .fop_flags = FOP_UNSIGNED_OFFSET, + DRM_GEM_DMA_UNMAPPED_AREA_FOPS +}; + +static int adp_drm_gem_dumb_create(struct drm_file *file_priv, + struct drm_device *drm, + struct drm_mode_create_dumb *args) +{ + args->height = ALIGN(args->height, 64); + args->size = args->pitch * args->height; + + return drm_gem_dma_dumb_create_internal(file_priv, drm, args); +} + +static const struct drm_driver adp_driver = { + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, + .fops = &adp_fops, + DRM_GEM_DMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(adp_drm_gem_dumb_create), + .name = "adp", + .desc = "Apple Display Pipe DRM Driver", + .date = "20230412", + .major = 0, + .minor = 1, +}; + +struct adp_drv_private { + struct drm_device drm; + struct drm_crtc crtc; + struct drm_encoder *encoder; + struct drm_connector *connector; + struct drm_bridge *next_bridge; + void __iomem *be; + void __iomem *fe; + u32 *mask_buf; + u64 mask_buf_size; + dma_addr_t mask_iova; + int be_irq; + int fe_irq; + spinlock_t irq_lock; + struct drm_pending_vblank_event *event; +}; + +#define to_adp(x) container_of(x, struct adp_drv_private, drm) +#define crtc_to_adp(x) container_of(x, struct adp_drv_private, crtc) + +static int adp_plane_atomic_check(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct drm_plane_state *new_plane_state; + struct drm_crtc_state *crtc_state; + + new_plane_state = drm_atomic_get_new_plane_state(state, plane); + + if (!new_plane_state->crtc) + return 0; + + crtc_state = drm_atomic_get_crtc_state(state, new_plane_state->crtc); + if (IS_ERR(crtc_state)) + return PTR_ERR(crtc_state); + + return drm_atomic_helper_check_plane_state(new_plane_state, + crtc_state, + DRM_PLANE_NO_SCALING, + DRM_PLANE_NO_SCALING, + true, true); +} + +static void adp_plane_atomic_update(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct adp_drv_private *adp; + struct drm_rect src_rect; + struct drm_gem_dma_object *obj; + struct drm_framebuffer *fb; + struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, plane); + u32 src_pos, src_size, dst_pos, dst_size; + + if (!plane || !new_state) + return; + + fb = new_state->fb; + if (!fb) + return; + adp = to_adp(plane->dev); + + drm_rect_fp_to_int(&src_rect, &new_state->src); + src_pos = src_rect.x1 << 16 | src_rect.y1; + dst_pos = new_state->dst.x1 << 16 | new_state->dst.y1; + src_size = drm_rect_width(&src_rect) << 16 | drm_rect_height(&src_rect); + dst_size = drm_rect_width(&new_state->dst) << 16 | + drm_rect_height(&new_state->dst); + writel(src_pos, adp->be + ADBE_SRC_START); + writel(src_size, adp->be + ADBE_SRC_SIZE); + writel(dst_pos, adp->be + ADBE_DST_START); + writel(dst_size, adp->be + ADBE_DST_SIZE); + writel(fb->pitches[0], adp->be + ADBE_STRIDE); + obj = drm_fb_dma_get_gem_obj(fb, 0); + if (obj) + writel(obj->dma_addr + fb->offsets[0], adp->be + ADBE_FB_BASE); + + writel(BIT(0), adp->be + ADBE_LAYER_EN1); + writel(BIT(0), adp->be + ADBE_LAYER_EN2); + writel(BIT(0), adp->be + ADBE_LAYER_EN3); + writel(BIT(0), adp->be + ADBE_LAYER_EN4); + writel(ADBE_SCALE_CTL_BYPASS, adp->be + ADBE_SCALE_CTL); + writel(ADBE_LAYER_CTL_ENABLE | BIT(0), adp->be + ADBE_LAYER_CTL); + writel(ADBE_PIX_FMT_XRGB32, adp->be + ADBE_PIX_FMT); +} + +static void adp_plane_atomic_disable(struct drm_plane *plane, + struct drm_atomic_state *state) +{ + struct adp_drv_private *adp = to_adp(plane->dev); + + writel(0x0, adp->be + ADBE_LAYER_EN1); + writel(0x0, adp->be + ADBE_LAYER_EN2); + writel(0x0, adp->be + ADBE_LAYER_EN3); + writel(0x0, adp->be + ADBE_LAYER_EN4); + writel(ADBE_LAYER_CTL_ENABLE, adp->be + ADBE_LAYER_CTL); +} + +static const struct drm_plane_helper_funcs adp_plane_helper_funcs = { + .atomic_check = adp_plane_atomic_check, + .atomic_update = adp_plane_atomic_update, + .atomic_disable = adp_plane_atomic_disable, + DRM_GEM_SHADOW_PLANE_HELPER_FUNCS +}; + +static const struct drm_plane_funcs adp_plane_funcs = { + .update_plane = drm_atomic_helper_update_plane, + .disable_plane = drm_atomic_helper_disable_plane, + DRM_GEM_SHADOW_PLANE_FUNCS +}; + +static const u32 plane_formats[] = { + DRM_FORMAT_XRGB8888, +}; + +#define ALL_CRTCS 1 + +static struct drm_plane *adp_plane_new(struct adp_drv_private *adp) +{ + struct drm_device *drm = &adp->drm; + struct drm_plane *plane; + + plane = __drmm_universal_plane_alloc(drm, sizeof(struct drm_plane), 0, + ALL_CRTCS, &adp_plane_funcs, + plane_formats, ARRAY_SIZE(plane_formats), + NULL, DRM_PLANE_TYPE_PRIMARY, "plane"); + if (!plane) { + drm_err(drm, "failed to allocate plane"); + return ERR_PTR(-ENOMEM); + } + + drm_plane_helper_add(plane, &adp_plane_helper_funcs); + return plane; +} + +static void adp_enable_vblank(struct adp_drv_private *adp) +{ + u32 cur_ctrl; + + writel(ADP_INT_STATUS_INT_MASK, adp->fe + ADP_INT_STATUS); + + cur_ctrl = readl(adp->fe + ADP_CTRL); + writel(cur_ctrl | ADP_CTRL_VBLANK_ON, adp->fe + ADP_CTRL); +} + +static int adp_crtc_enable_vblank(struct drm_crtc *crtc) +{ + struct drm_device *dev = crtc->dev; + struct adp_drv_private *adp = to_adp(dev); + + adp_enable_vblank(adp); + + return 0; +} + +static void adp_disable_vblank(struct adp_drv_private *adp) +{ + u32 cur_ctrl; + + cur_ctrl = readl(adp->fe + ADP_CTRL); + writel(cur_ctrl & ~ADP_CTRL_VBLANK_ON, adp->fe + ADP_CTRL); + writel(ADP_INT_STATUS_INT_MASK, adp->fe + ADP_INT_STATUS); +} + +static void adp_crtc_disable_vblank(struct drm_crtc *crtc) +{ + struct drm_device *dev = crtc->dev; + struct adp_drv_private *adp = to_adp(dev); + + adp_disable_vblank(adp); +} + +static void adp_crtc_atomic_enable(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + struct adp_drv_private *adp = crtc_to_adp(crtc); + + writel(BIT(0), adp->be + ADBE_BLEND_EN2); + writel(BIT(4), adp->be + ADBE_BLEND_EN1); + writel(BIT(0), adp->be + ADBE_BLEND_EN3); + writel(BIT(0), adp->be + ADBE_BLEND_BYPASS); + writel(BIT(0), adp->be + ADBE_BLEND_EN4); +} + +static void adp_crtc_atomic_disable(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + struct adp_drv_private *adp = crtc_to_adp(crtc); + struct drm_crtc_state *old_state = drm_atomic_get_old_crtc_state(state, crtc); + + drm_atomic_helper_disable_planes_on_crtc(old_state, false); + + writel(0x0, adp->be + ADBE_BLEND_EN2); + writel(0x0, adp->be + ADBE_BLEND_EN1); + writel(0x0, adp->be + ADBE_BLEND_EN3); + writel(0x0, adp->be + ADBE_BLEND_BYPASS); + writel(0x0, adp->be + ADBE_BLEND_EN4); + drm_crtc_vblank_off(crtc); +} + +static void adp_crtc_atomic_flush(struct drm_crtc *crtc, + struct drm_atomic_state *state) +{ + u32 frame_num = 1; + struct adp_drv_private *adp = crtc_to_adp(crtc); + struct drm_crtc_state *new_state = drm_atomic_get_new_crtc_state(state, crtc); + u64 new_size = ALIGN(new_state->mode.hdisplay * + new_state->mode.vdisplay * 4, PAGE_SIZE); + + if (new_size != adp->mask_buf_size) { + if (adp->mask_buf) + dma_free_coherent(crtc->dev->dev, adp->mask_buf_size, + adp->mask_buf, adp->mask_iova); + adp->mask_buf = NULL; + if (new_size != 0) { + adp->mask_buf = dma_alloc_coherent(crtc->dev->dev, new_size, + &adp->mask_iova, GFP_KERNEL); + memset(adp->mask_buf, 0xFF, new_size); + writel(adp->mask_iova, adp->be + ADBE_MASK_BUF); + } + adp->mask_buf_size = new_size; + } + writel(ADBE_FIFO_SYNC | frame_num, adp->be + ADBE_FIFO); + //FIXME: use adbe flush interrupt + spin_lock_irq(&crtc->dev->event_lock); + if (crtc->state->event) { + drm_crtc_vblank_get(crtc); + adp->event = crtc->state->event; + } + crtc->state->event = NULL; + spin_unlock_irq(&crtc->dev->event_lock); +} + +static const struct drm_crtc_funcs adp_crtc_funcs = { + .destroy = drm_crtc_cleanup, + .set_config = drm_atomic_helper_set_config, + .page_flip = drm_atomic_helper_page_flip, + .reset = drm_atomic_helper_crtc_reset, + .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state, + .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state, + .enable_vblank = adp_crtc_enable_vblank, + .disable_vblank = adp_crtc_disable_vblank, +}; + + +static const struct drm_crtc_helper_funcs adp_crtc_helper_funcs = { + .atomic_enable = adp_crtc_atomic_enable, + .atomic_disable = adp_crtc_atomic_disable, + .atomic_flush = adp_crtc_atomic_flush, +}; + +static int adp_setup_crtc(struct adp_drv_private *adp) +{ + struct drm_device *drm = &adp->drm; + struct drm_plane *primary; + int ret; + + primary = adp_plane_new(adp); + if (IS_ERR(primary)) + return PTR_ERR(primary); + + ret = drm_crtc_init_with_planes(drm, &adp->crtc, primary, + NULL, &adp_crtc_funcs, NULL); + if (ret) + return ret; + + drm_crtc_helper_add(&adp->crtc, &adp_crtc_helper_funcs); + return 0; +} + +static const struct drm_mode_config_funcs adp_mode_config_funcs = { + .fb_create = drm_gem_fb_create_with_dirty, + .atomic_check = drm_atomic_helper_check, + .atomic_commit = drm_atomic_helper_commit, +}; + +static int adp_setup_mode_config(struct adp_drv_private *adp) +{ + struct drm_device *drm = &adp->drm; + int ret; + u32 size; + + ret = drmm_mode_config_init(drm); + if (ret) + return ret; + + /* + * Query screen size restrict the frame buffer size to the screen size + * aligned to the next multiple of 64. This is not necessary but can be + * used as simple check for non-desktop devices. + * Xorg's modesetting driver does not care about the connector + * "non-desktop" property. The max frame buffer width or height can be + * easily checked and a device can be reject if the max width/height is + * smaller than 120 for example. + * Any touchbar daemon is not limited by this small framebuffer size. + */ + size = readl(adp->fe + ADP_SCREEN_SIZE); + + drm->mode_config.min_width = 32; + drm->mode_config.min_height = 32; + drm->mode_config.max_width = ALIGN(FIELD_GET(ADP_SCREEN_HSIZE, size), 64); + drm->mode_config.max_height = ALIGN(FIELD_GET(ADP_SCREEN_VSIZE, size), 64); + drm->mode_config.preferred_depth = 24; + drm->mode_config.prefer_shadow = 0; + drm->mode_config.funcs = &adp_mode_config_funcs; + + ret = adp_setup_crtc(adp); + if (ret) { + drm_err(drm, "failed to create crtc"); + return ret; + } + + adp->encoder = drmm_plain_encoder_alloc(drm, NULL, DRM_MODE_ENCODER_DSI, NULL); + if (IS_ERR(adp->encoder)) { + drm_err(drm, "failed to init encoder"); + return PTR_ERR(adp->encoder); + } + adp->encoder->possible_crtcs = ALL_CRTCS; + + ret = drm_bridge_attach(adp->encoder, adp->next_bridge, NULL, + DRM_BRIDGE_ATTACH_NO_CONNECTOR); + if (ret) { + drm_err(drm, "failed to init bridge chain"); + return ret; + } + + adp->connector = drm_bridge_connector_init(drm, adp->encoder); + if (IS_ERR(adp->connector)) + return PTR_ERR(adp->connector); + + drm_connector_attach_encoder(adp->connector, adp->encoder); + + ret = drm_vblank_init(drm, drm->mode_config.num_crtc); + if (ret < 0) { + drm_err(drm, "failed to initialize vblank"); + return ret; + } + + drm_mode_config_reset(drm); + + return 0; +} + +static int adp_parse_of(struct platform_device *pdev, struct adp_drv_private *adp) +{ + struct device *dev = &pdev->dev; + + adp->be = devm_platform_ioremap_resource_byname(pdev, "be"); + if (IS_ERR(adp->be)) { + dev_err(dev, "failed to map display backend mmio"); + return PTR_ERR(adp->be); + } + + adp->fe = devm_platform_ioremap_resource_byname(pdev, "fe"); + if (IS_ERR(adp->fe)) { + dev_err(dev, "failed to map display pipe mmio"); + return PTR_ERR(adp->fe); + } + + adp->be_irq = platform_get_irq_byname(pdev, "be"); + if (adp->be_irq < 0) { + dev_err(dev, "failed to find be irq"); + return adp->be_irq; + } + + adp->fe_irq = platform_get_irq_byname(pdev, "fe"); + if (adp->fe_irq < 0) { + dev_err(dev, "failed to find fe irq"); + return adp->fe_irq; + } + + return 0; +} + +static irqreturn_t adp_fe_irq(int irq, void *arg) +{ + struct adp_drv_private *adp = (struct adp_drv_private *)arg; + u32 int_status; + u32 int_ctl; + + spin_lock(&adp->irq_lock); + + int_status = readl(adp->fe + ADP_INT_STATUS); + if (int_status & ADP_INT_STATUS_VBLANK) { + drm_crtc_handle_vblank(&adp->crtc); + spin_lock(&adp->crtc.dev->event_lock); + if (adp->event) { + int_ctl = readl(adp->fe + ADP_CTRL); + if ((int_ctl & 0xF00) == 0x600) { + drm_crtc_send_vblank_event(&adp->crtc, adp->event); + adp->event = NULL; + drm_crtc_vblank_put(&adp->crtc); + } + } + spin_unlock(&adp->crtc.dev->event_lock); + } + + writel(int_status, adp->fe + ADP_INT_STATUS); + + spin_unlock(&adp->irq_lock); + + return IRQ_HANDLED; +} + +static int adp_drm_bind(struct device *dev) +{ + struct drm_device *drm = dev_get_drvdata(dev); + struct adp_drv_private *adp = to_adp(drm); + int err; + + adp_disable_vblank(adp); + writel(ADP_CTRL_FIFO_ON | ADP_CTRL_VBLANK_ON, adp->fe + ADP_CTRL); + + adp->next_bridge = drmm_of_get_bridge(&adp->drm, dev->of_node, 0, 0); + if (IS_ERR(adp->next_bridge)) { + dev_err(dev, "failed to find next bridge"); + return PTR_ERR(adp->next_bridge); + } + + err = adp_setup_mode_config(adp); + if (err < 0) + return err; + + err = request_irq(adp->fe_irq, adp_fe_irq, 0, "adp-fe", adp); + if (err) + return err; + + err = drm_dev_register(&adp->drm, 0); + if (err) + return err; + + return 0; +} + +static void adp_drm_unbind(struct device *dev) +{ + struct drm_device *drm = dev_get_drvdata(dev); + struct adp_drv_private *adp = to_adp(drm); + + drm_dev_unregister(drm); + drm_atomic_helper_shutdown(drm); + free_irq(adp->fe_irq, adp); +} + +static const struct component_master_ops adp_master_ops = { + .bind = adp_drm_bind, + .unbind = adp_drm_unbind, +}; + +static int compare_dev(struct device *dev, void *data) +{ + return dev->of_node == data; +} + +static int adp_probe(struct platform_device *pdev) +{ + struct device_node *port; + struct component_match *match = NULL; + struct adp_drv_private *adp; + int err; + + adp = devm_drm_dev_alloc(&pdev->dev, &adp_driver, struct adp_drv_private, drm); + if (IS_ERR(adp)) + return PTR_ERR(adp); + + spin_lock_init(&adp->irq_lock); + + dev_set_drvdata(&pdev->dev, &adp->drm); + + err = adp_parse_of(pdev, adp); + if (err < 0) + return err; + + port = of_graph_get_remote_node(pdev->dev.of_node, 0, 0); + if (!port) + return -ENODEV; + + drm_of_component_match_add(&pdev->dev, &match, compare_dev, port); + of_node_put(port); + + return component_master_add_with_match(&pdev->dev, &adp_master_ops, match); +} + +static void adp_remove(struct platform_device *pdev) +{ + component_master_del(&pdev->dev, &adp_master_ops); + dev_set_drvdata(&pdev->dev, NULL); +} + +static const struct of_device_id adp_of_match[] = { + { .compatible = "apple,h7-display-pipe", }, + { }, +}; +MODULE_DEVICE_TABLE(of, adp_of_match); + +static struct platform_driver adp_platform_driver = { + .driver = { + .name = "adp", + .of_match_table = adp_of_match, + }, + .probe = adp_probe, + .remove = adp_remove, +}; + +module_platform_driver(adp_platform_driver); + +MODULE_DESCRIPTION("Apple Display Pipe DRM driver"); +MODULE_LICENSE("GPL"); -- 2.48.1 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v7 2/5] drm: adp: Add Apple Display Pipe driver 2025-02-17 11:39 ` [PATCH v7 2/5] drm: adp: Add Apple Display Pipe driver Sasha Finkelstein via B4 Relay @ 2025-02-17 13:22 ` Thomas Zimmermann 2025-02-17 13:30 ` Sasha Finkelstein 0 siblings, 1 reply; 19+ messages in thread From: Thomas Zimmermann @ 2025-02-17 13:22 UTC (permalink / raw) To: fnkl.kernel, Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jessica Zhang, asahi, Janne Grunau Cc: linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Dmitry Baryshkov, Neal Gompa Hi Am 17.02.25 um 12:39 schrieb Sasha Finkelstein via B4 Relay: [...] > + > +static int adp_open(struct inode *inode, struct file *filp) > +{ > + /* > + * The modesetting driver does not check the non-desktop connector > + * property and keeps the device open and locked. If the touchbar daemon > + * opens the device first modesetting breaks the whole X session. I find this sentence hard to understand. Should there be a comma after 'first' for better readability? > + * Simply refuse to open the device for X11 server processes as > + * workaround. This is a platform device, so Xorg will not use it automatically. There exists a list of acceptable DRM drivers in the Xorg source code. [1] You'd have to add adp there. Unless the described problem really happens in practice, I'd drop this workaround. There's no point in working around legacy userspace in modern drivers. Best regards Thomas [1] https://gitlab.freedesktop.org/xorg/xserver/-/blob/master/hw/xfree86/common/xf86platformBus.c#L582 > + */ > + if (current->comm[0] == 'X') > + return -EBUSY; > + > + return drm_open(inode, filp); > +} > + > +static const struct file_operations adp_fops = { > + .owner = THIS_MODULE, > + .open = adp_open, > + .release = drm_release, > + .unlocked_ioctl = drm_ioctl, > + .compat_ioctl = drm_compat_ioctl, > + .poll = drm_poll, > + .read = drm_read, > + .llseek = noop_llseek, > + .mmap = drm_gem_mmap, > + .fop_flags = FOP_UNSIGNED_OFFSET, > + DRM_GEM_DMA_UNMAPPED_AREA_FOPS > +}; > + > +static int adp_drm_gem_dumb_create(struct drm_file *file_priv, > + struct drm_device *drm, > + struct drm_mode_create_dumb *args) > +{ > + args->height = ALIGN(args->height, 64); > + args->size = args->pitch * args->height; > + > + return drm_gem_dma_dumb_create_internal(file_priv, drm, args); > +} > + > +static const struct drm_driver adp_driver = { > + .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_ATOMIC, > + .fops = &adp_fops, > + DRM_GEM_DMA_DRIVER_OPS_VMAP_WITH_DUMB_CREATE(adp_drm_gem_dumb_create), > + .name = "adp", > + .desc = "Apple Display Pipe DRM Driver", > + .date = "20230412", > + .major = 0, > + .minor = 1, > +}; > + > +struct adp_drv_private { > + struct drm_device drm; > + struct drm_crtc crtc; > + struct drm_encoder *encoder; > + struct drm_connector *connector; > + struct drm_bridge *next_bridge; > + void __iomem *be; > + void __iomem *fe; > + u32 *mask_buf; > + u64 mask_buf_size; > + dma_addr_t mask_iova; > + int be_irq; > + int fe_irq; > + spinlock_t irq_lock; > + struct drm_pending_vblank_event *event; > +}; > + > +#define to_adp(x) container_of(x, struct adp_drv_private, drm) > +#define crtc_to_adp(x) container_of(x, struct adp_drv_private, crtc) > + > +static int adp_plane_atomic_check(struct drm_plane *plane, > + struct drm_atomic_state *state) > +{ > + struct drm_plane_state *new_plane_state; > + struct drm_crtc_state *crtc_state; > + > + new_plane_state = drm_atomic_get_new_plane_state(state, plane); > + > + if (!new_plane_state->crtc) > + return 0; > + > + crtc_state = drm_atomic_get_crtc_state(state, new_plane_state->crtc); > + if (IS_ERR(crtc_state)) > + return PTR_ERR(crtc_state); > + > + return drm_atomic_helper_check_plane_state(new_plane_state, > + crtc_state, > + DRM_PLANE_NO_SCALING, > + DRM_PLANE_NO_SCALING, > + true, true); > +} > + > +static void adp_plane_atomic_update(struct drm_plane *plane, > + struct drm_atomic_state *state) > +{ > + struct adp_drv_private *adp; > + struct drm_rect src_rect; > + struct drm_gem_dma_object *obj; > + struct drm_framebuffer *fb; > + struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, plane); > + u32 src_pos, src_size, dst_pos, dst_size; > + > + if (!plane || !new_state) > + return; > + > + fb = new_state->fb; > + if (!fb) > + return; > + adp = to_adp(plane->dev); > + > + drm_rect_fp_to_int(&src_rect, &new_state->src); > + src_pos = src_rect.x1 << 16 | src_rect.y1; > + dst_pos = new_state->dst.x1 << 16 | new_state->dst.y1; > + src_size = drm_rect_width(&src_rect) << 16 | drm_rect_height(&src_rect); > + dst_size = drm_rect_width(&new_state->dst) << 16 | > + drm_rect_height(&new_state->dst); > + writel(src_pos, adp->be + ADBE_SRC_START); > + writel(src_size, adp->be + ADBE_SRC_SIZE); > + writel(dst_pos, adp->be + ADBE_DST_START); > + writel(dst_size, adp->be + ADBE_DST_SIZE); > + writel(fb->pitches[0], adp->be + ADBE_STRIDE); > + obj = drm_fb_dma_get_gem_obj(fb, 0); > + if (obj) > + writel(obj->dma_addr + fb->offsets[0], adp->be + ADBE_FB_BASE); > + > + writel(BIT(0), adp->be + ADBE_LAYER_EN1); > + writel(BIT(0), adp->be + ADBE_LAYER_EN2); > + writel(BIT(0), adp->be + ADBE_LAYER_EN3); > + writel(BIT(0), adp->be + ADBE_LAYER_EN4); > + writel(ADBE_SCALE_CTL_BYPASS, adp->be + ADBE_SCALE_CTL); > + writel(ADBE_LAYER_CTL_ENABLE | BIT(0), adp->be + ADBE_LAYER_CTL); > + writel(ADBE_PIX_FMT_XRGB32, adp->be + ADBE_PIX_FMT); > +} > + > +static void adp_plane_atomic_disable(struct drm_plane *plane, > + struct drm_atomic_state *state) > +{ > + struct adp_drv_private *adp = to_adp(plane->dev); > + > + writel(0x0, adp->be + ADBE_LAYER_EN1); > + writel(0x0, adp->be + ADBE_LAYER_EN2); > + writel(0x0, adp->be + ADBE_LAYER_EN3); > + writel(0x0, adp->be + ADBE_LAYER_EN4); > + writel(ADBE_LAYER_CTL_ENABLE, adp->be + ADBE_LAYER_CTL); > +} > + > +static const struct drm_plane_helper_funcs adp_plane_helper_funcs = { > + .atomic_check = adp_plane_atomic_check, > + .atomic_update = adp_plane_atomic_update, > + .atomic_disable = adp_plane_atomic_disable, > + DRM_GEM_SHADOW_PLANE_HELPER_FUNCS > +}; > + > +static const struct drm_plane_funcs adp_plane_funcs = { > + .update_plane = drm_atomic_helper_update_plane, > + .disable_plane = drm_atomic_helper_disable_plane, > + DRM_GEM_SHADOW_PLANE_FUNCS > +}; > + > +static const u32 plane_formats[] = { > + DRM_FORMAT_XRGB8888, > +}; > + > +#define ALL_CRTCS 1 > + > +static struct drm_plane *adp_plane_new(struct adp_drv_private *adp) > +{ > + struct drm_device *drm = &adp->drm; > + struct drm_plane *plane; > + > + plane = __drmm_universal_plane_alloc(drm, sizeof(struct drm_plane), 0, > + ALL_CRTCS, &adp_plane_funcs, > + plane_formats, ARRAY_SIZE(plane_formats), > + NULL, DRM_PLANE_TYPE_PRIMARY, "plane"); > + if (!plane) { > + drm_err(drm, "failed to allocate plane"); > + return ERR_PTR(-ENOMEM); > + } > + > + drm_plane_helper_add(plane, &adp_plane_helper_funcs); > + return plane; > +} > + > +static void adp_enable_vblank(struct adp_drv_private *adp) > +{ > + u32 cur_ctrl; > + > + writel(ADP_INT_STATUS_INT_MASK, adp->fe + ADP_INT_STATUS); > + > + cur_ctrl = readl(adp->fe + ADP_CTRL); > + writel(cur_ctrl | ADP_CTRL_VBLANK_ON, adp->fe + ADP_CTRL); > +} > + > +static int adp_crtc_enable_vblank(struct drm_crtc *crtc) > +{ > + struct drm_device *dev = crtc->dev; > + struct adp_drv_private *adp = to_adp(dev); > + > + adp_enable_vblank(adp); > + > + return 0; > +} > + > +static void adp_disable_vblank(struct adp_drv_private *adp) > +{ > + u32 cur_ctrl; > + > + cur_ctrl = readl(adp->fe + ADP_CTRL); > + writel(cur_ctrl & ~ADP_CTRL_VBLANK_ON, adp->fe + ADP_CTRL); > + writel(ADP_INT_STATUS_INT_MASK, adp->fe + ADP_INT_STATUS); > +} > + > +static void adp_crtc_disable_vblank(struct drm_crtc *crtc) > +{ > + struct drm_device *dev = crtc->dev; > + struct adp_drv_private *adp = to_adp(dev); > + > + adp_disable_vblank(adp); > +} > + > +static void adp_crtc_atomic_enable(struct drm_crtc *crtc, > + struct drm_atomic_state *state) > +{ > + struct adp_drv_private *adp = crtc_to_adp(crtc); > + > + writel(BIT(0), adp->be + ADBE_BLEND_EN2); > + writel(BIT(4), adp->be + ADBE_BLEND_EN1); > + writel(BIT(0), adp->be + ADBE_BLEND_EN3); > + writel(BIT(0), adp->be + ADBE_BLEND_BYPASS); > + writel(BIT(0), adp->be + ADBE_BLEND_EN4); > +} > + > +static void adp_crtc_atomic_disable(struct drm_crtc *crtc, > + struct drm_atomic_state *state) > +{ > + struct adp_drv_private *adp = crtc_to_adp(crtc); > + struct drm_crtc_state *old_state = drm_atomic_get_old_crtc_state(state, crtc); > + > + drm_atomic_helper_disable_planes_on_crtc(old_state, false); > + > + writel(0x0, adp->be + ADBE_BLEND_EN2); > + writel(0x0, adp->be + ADBE_BLEND_EN1); > + writel(0x0, adp->be + ADBE_BLEND_EN3); > + writel(0x0, adp->be + ADBE_BLEND_BYPASS); > + writel(0x0, adp->be + ADBE_BLEND_EN4); > + drm_crtc_vblank_off(crtc); > +} > + > +static void adp_crtc_atomic_flush(struct drm_crtc *crtc, > + struct drm_atomic_state *state) > +{ > + u32 frame_num = 1; > + struct adp_drv_private *adp = crtc_to_adp(crtc); > + struct drm_crtc_state *new_state = drm_atomic_get_new_crtc_state(state, crtc); > + u64 new_size = ALIGN(new_state->mode.hdisplay * > + new_state->mode.vdisplay * 4, PAGE_SIZE); > + > + if (new_size != adp->mask_buf_size) { > + if (adp->mask_buf) > + dma_free_coherent(crtc->dev->dev, adp->mask_buf_size, > + adp->mask_buf, adp->mask_iova); > + adp->mask_buf = NULL; > + if (new_size != 0) { > + adp->mask_buf = dma_alloc_coherent(crtc->dev->dev, new_size, > + &adp->mask_iova, GFP_KERNEL); > + memset(adp->mask_buf, 0xFF, new_size); > + writel(adp->mask_iova, adp->be + ADBE_MASK_BUF); > + } > + adp->mask_buf_size = new_size; > + } > + writel(ADBE_FIFO_SYNC | frame_num, adp->be + ADBE_FIFO); > + //FIXME: use adbe flush interrupt > + spin_lock_irq(&crtc->dev->event_lock); > + if (crtc->state->event) { > + drm_crtc_vblank_get(crtc); > + adp->event = crtc->state->event; > + } > + crtc->state->event = NULL; > + spin_unlock_irq(&crtc->dev->event_lock); > +} > + > +static const struct drm_crtc_funcs adp_crtc_funcs = { > + .destroy = drm_crtc_cleanup, > + .set_config = drm_atomic_helper_set_config, > + .page_flip = drm_atomic_helper_page_flip, > + .reset = drm_atomic_helper_crtc_reset, > + .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state, > + .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state, > + .enable_vblank = adp_crtc_enable_vblank, > + .disable_vblank = adp_crtc_disable_vblank, > +}; > + > + > +static const struct drm_crtc_helper_funcs adp_crtc_helper_funcs = { > + .atomic_enable = adp_crtc_atomic_enable, > + .atomic_disable = adp_crtc_atomic_disable, > + .atomic_flush = adp_crtc_atomic_flush, > +}; > + > +static int adp_setup_crtc(struct adp_drv_private *adp) > +{ > + struct drm_device *drm = &adp->drm; > + struct drm_plane *primary; > + int ret; > + > + primary = adp_plane_new(adp); > + if (IS_ERR(primary)) > + return PTR_ERR(primary); > + > + ret = drm_crtc_init_with_planes(drm, &adp->crtc, primary, > + NULL, &adp_crtc_funcs, NULL); > + if (ret) > + return ret; > + > + drm_crtc_helper_add(&adp->crtc, &adp_crtc_helper_funcs); > + return 0; > +} > + > +static const struct drm_mode_config_funcs adp_mode_config_funcs = { > + .fb_create = drm_gem_fb_create_with_dirty, > + .atomic_check = drm_atomic_helper_check, > + .atomic_commit = drm_atomic_helper_commit, > +}; > + > +static int adp_setup_mode_config(struct adp_drv_private *adp) > +{ > + struct drm_device *drm = &adp->drm; > + int ret; > + u32 size; > + > + ret = drmm_mode_config_init(drm); > + if (ret) > + return ret; > + > + /* > + * Query screen size restrict the frame buffer size to the screen size > + * aligned to the next multiple of 64. This is not necessary but can be > + * used as simple check for non-desktop devices. > + * Xorg's modesetting driver does not care about the connector > + * "non-desktop" property. The max frame buffer width or height can be > + * easily checked and a device can be reject if the max width/height is > + * smaller than 120 for example. > + * Any touchbar daemon is not limited by this small framebuffer size. > + */ > + size = readl(adp->fe + ADP_SCREEN_SIZE); > + > + drm->mode_config.min_width = 32; > + drm->mode_config.min_height = 32; > + drm->mode_config.max_width = ALIGN(FIELD_GET(ADP_SCREEN_HSIZE, size), 64); > + drm->mode_config.max_height = ALIGN(FIELD_GET(ADP_SCREEN_VSIZE, size), 64); > + drm->mode_config.preferred_depth = 24; > + drm->mode_config.prefer_shadow = 0; > + drm->mode_config.funcs = &adp_mode_config_funcs; > + > + ret = adp_setup_crtc(adp); > + if (ret) { > + drm_err(drm, "failed to create crtc"); > + return ret; > + } > + > + adp->encoder = drmm_plain_encoder_alloc(drm, NULL, DRM_MODE_ENCODER_DSI, NULL); > + if (IS_ERR(adp->encoder)) { > + drm_err(drm, "failed to init encoder"); > + return PTR_ERR(adp->encoder); > + } > + adp->encoder->possible_crtcs = ALL_CRTCS; > + > + ret = drm_bridge_attach(adp->encoder, adp->next_bridge, NULL, > + DRM_BRIDGE_ATTACH_NO_CONNECTOR); > + if (ret) { > + drm_err(drm, "failed to init bridge chain"); > + return ret; > + } > + > + adp->connector = drm_bridge_connector_init(drm, adp->encoder); > + if (IS_ERR(adp->connector)) > + return PTR_ERR(adp->connector); > + > + drm_connector_attach_encoder(adp->connector, adp->encoder); > + > + ret = drm_vblank_init(drm, drm->mode_config.num_crtc); > + if (ret < 0) { > + drm_err(drm, "failed to initialize vblank"); > + return ret; > + } > + > + drm_mode_config_reset(drm); > + > + return 0; > +} > + > +static int adp_parse_of(struct platform_device *pdev, struct adp_drv_private *adp) > +{ > + struct device *dev = &pdev->dev; > + > + adp->be = devm_platform_ioremap_resource_byname(pdev, "be"); > + if (IS_ERR(adp->be)) { > + dev_err(dev, "failed to map display backend mmio"); > + return PTR_ERR(adp->be); > + } > + > + adp->fe = devm_platform_ioremap_resource_byname(pdev, "fe"); > + if (IS_ERR(adp->fe)) { > + dev_err(dev, "failed to map display pipe mmio"); > + return PTR_ERR(adp->fe); > + } > + > + adp->be_irq = platform_get_irq_byname(pdev, "be"); > + if (adp->be_irq < 0) { > + dev_err(dev, "failed to find be irq"); > + return adp->be_irq; > + } > + > + adp->fe_irq = platform_get_irq_byname(pdev, "fe"); > + if (adp->fe_irq < 0) { > + dev_err(dev, "failed to find fe irq"); > + return adp->fe_irq; > + } > + > + return 0; > +} > + > +static irqreturn_t adp_fe_irq(int irq, void *arg) > +{ > + struct adp_drv_private *adp = (struct adp_drv_private *)arg; > + u32 int_status; > + u32 int_ctl; > + > + spin_lock(&adp->irq_lock); > + > + int_status = readl(adp->fe + ADP_INT_STATUS); > + if (int_status & ADP_INT_STATUS_VBLANK) { > + drm_crtc_handle_vblank(&adp->crtc); > + spin_lock(&adp->crtc.dev->event_lock); > + if (adp->event) { > + int_ctl = readl(adp->fe + ADP_CTRL); > + if ((int_ctl & 0xF00) == 0x600) { > + drm_crtc_send_vblank_event(&adp->crtc, adp->event); > + adp->event = NULL; > + drm_crtc_vblank_put(&adp->crtc); > + } > + } > + spin_unlock(&adp->crtc.dev->event_lock); > + } > + > + writel(int_status, adp->fe + ADP_INT_STATUS); > + > + spin_unlock(&adp->irq_lock); > + > + return IRQ_HANDLED; > +} > + > +static int adp_drm_bind(struct device *dev) > +{ > + struct drm_device *drm = dev_get_drvdata(dev); > + struct adp_drv_private *adp = to_adp(drm); > + int err; > + > + adp_disable_vblank(adp); > + writel(ADP_CTRL_FIFO_ON | ADP_CTRL_VBLANK_ON, adp->fe + ADP_CTRL); > + > + adp->next_bridge = drmm_of_get_bridge(&adp->drm, dev->of_node, 0, 0); > + if (IS_ERR(adp->next_bridge)) { > + dev_err(dev, "failed to find next bridge"); > + return PTR_ERR(adp->next_bridge); > + } > + > + err = adp_setup_mode_config(adp); > + if (err < 0) > + return err; > + > + err = request_irq(adp->fe_irq, adp_fe_irq, 0, "adp-fe", adp); > + if (err) > + return err; > + > + err = drm_dev_register(&adp->drm, 0); > + if (err) > + return err; > + > + return 0; > +} > + > +static void adp_drm_unbind(struct device *dev) > +{ > + struct drm_device *drm = dev_get_drvdata(dev); > + struct adp_drv_private *adp = to_adp(drm); > + > + drm_dev_unregister(drm); > + drm_atomic_helper_shutdown(drm); > + free_irq(adp->fe_irq, adp); > +} > + > +static const struct component_master_ops adp_master_ops = { > + .bind = adp_drm_bind, > + .unbind = adp_drm_unbind, > +}; > + > +static int compare_dev(struct device *dev, void *data) > +{ > + return dev->of_node == data; > +} > + > +static int adp_probe(struct platform_device *pdev) > +{ > + struct device_node *port; > + struct component_match *match = NULL; > + struct adp_drv_private *adp; > + int err; > + > + adp = devm_drm_dev_alloc(&pdev->dev, &adp_driver, struct adp_drv_private, drm); > + if (IS_ERR(adp)) > + return PTR_ERR(adp); > + > + spin_lock_init(&adp->irq_lock); > + > + dev_set_drvdata(&pdev->dev, &adp->drm); > + > + err = adp_parse_of(pdev, adp); > + if (err < 0) > + return err; > + > + port = of_graph_get_remote_node(pdev->dev.of_node, 0, 0); > + if (!port) > + return -ENODEV; > + > + drm_of_component_match_add(&pdev->dev, &match, compare_dev, port); > + of_node_put(port); > + > + return component_master_add_with_match(&pdev->dev, &adp_master_ops, match); > +} > + > +static void adp_remove(struct platform_device *pdev) > +{ > + component_master_del(&pdev->dev, &adp_master_ops); > + dev_set_drvdata(&pdev->dev, NULL); > +} > + > +static const struct of_device_id adp_of_match[] = { > + { .compatible = "apple,h7-display-pipe", }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, adp_of_match); > + > +static struct platform_driver adp_platform_driver = { > + .driver = { > + .name = "adp", > + .of_match_table = adp_of_match, > + }, > + .probe = adp_probe, > + .remove = adp_remove, > +}; > + > +module_platform_driver(adp_platform_driver); > + > +MODULE_DESCRIPTION("Apple Display Pipe DRM driver"); > +MODULE_LICENSE("GPL"); > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg) ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v7 2/5] drm: adp: Add Apple Display Pipe driver 2025-02-17 13:22 ` Thomas Zimmermann @ 2025-02-17 13:30 ` Sasha Finkelstein 0 siblings, 0 replies; 19+ messages in thread From: Sasha Finkelstein @ 2025-02-17 13:30 UTC (permalink / raw) To: Thomas Zimmermann Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jessica Zhang, asahi, Janne Grunau, linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Dmitry Baryshkov, Neal Gompa On Mon, 17 Feb 2025 at 14:22, Thomas Zimmermann <tzimmermann@suse.de> wrote: > Unless the described problem really happens > in practice, I'd drop this workaround. There's no point in working > around legacy userspace in modern drivers. This workaround was put in place after we noticed x11 either preventing the userspace daemon from working, or breaking itself. So, yes, it does happen in practice. ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v7 3/5] drm: panel: Add a panel driver for the Summit display 2025-02-17 11:39 [PATCH v7 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay 2025-02-17 11:39 ` [PATCH v7 1/5] dt-bindings: display: Add Apple pre-DCP " Sasha Finkelstein via B4 Relay 2025-02-17 11:39 ` [PATCH v7 2/5] drm: adp: Add Apple Display Pipe driver Sasha Finkelstein via B4 Relay @ 2025-02-17 11:39 ` Sasha Finkelstein via B4 Relay 2025-02-17 11:39 ` [PATCH v7 4/5] arm64: dts: apple: Add touchbar screen nodes Sasha Finkelstein via B4 Relay ` (4 subsequent siblings) 7 siblings, 0 replies; 19+ messages in thread From: Sasha Finkelstein via B4 Relay @ 2025-02-17 11:39 UTC (permalink / raw) To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jessica Zhang, asahi, Janne Grunau Cc: linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Sasha Finkelstein, Nick Chan, Dmitry Baryshkov, Neal Gompa From: Sasha Finkelstein <fnkl.kernel@gmail.com> This is the display panel used for the touchbar on laptops that have it. Co-developed-by: Nick Chan <towinchenmi@gmail.com> Signed-off-by: Nick Chan <towinchenmi@gmail.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by: Neal Gompa <neal@gompa.dev> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> --- drivers/gpu/drm/panel/Kconfig | 9 +++ drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-summit.c | 132 +++++++++++++++++++++++++++++++++++ 3 files changed, 142 insertions(+) diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index d7469c565d1db8b8e974dd6c45d03d9352d99d63..5085a82e4bc695e85cabbc3200859bbe10cb0f91 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -925,6 +925,15 @@ config DRM_PANEL_SIMPLE that it can be automatically turned off when the panel goes into a low power state. +config DRM_PANEL_SUMMIT + tristate "Apple Summit display panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y if you want to enable support for the "Summit" display panel + used as a touchbar on certain Apple laptops. + config DRM_PANEL_SYNAPTICS_R63353 tristate "Synaptics R63353-based panels" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index 7dcf72646cacff11bab90c78e3b8b1f357e5f14a..10ac2e850f5cd6d6546439de75483466e4015d1a 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -89,6 +89,7 @@ obj-$(CONFIG_DRM_PANEL_SHARP_LS060T1SX01) += panel-sharp-ls060t1sx01.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7701) += panel-sitronix-st7701.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7703) += panel-sitronix-st7703.o obj-$(CONFIG_DRM_PANEL_SITRONIX_ST7789V) += panel-sitronix-st7789v.o +obj-$(CONFIG_DRM_PANEL_SUMMIT) += panel-summit.o obj-$(CONFIG_DRM_PANEL_SYNAPTICS_R63353) += panel-synaptics-r63353.o obj-$(CONFIG_DRM_PANEL_SONY_ACX565AKM) += panel-sony-acx565akm.o obj-$(CONFIG_DRM_PANEL_SONY_TD4353_JDI) += panel-sony-td4353-jdi.o diff --git a/drivers/gpu/drm/panel/panel-summit.c b/drivers/gpu/drm/panel/panel-summit.c new file mode 100644 index 0000000000000000000000000000000000000000..e780faee18570c9970d381b3f7c65b95665469cd --- /dev/null +++ b/drivers/gpu/drm/panel/panel-summit.c @@ -0,0 +1,132 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include <linux/backlight.h> +#include <drm/drm_device.h> +#include <drm/drm_mipi_dsi.h> +#include <drm/drm_mode.h> +#include <drm/drm_modes.h> +#include <drm/drm_panel.h> +#include <drm/drm_probe_helper.h> +#include <video/mipi_display.h> + +struct summit_data { + struct mipi_dsi_device *dsi; + struct backlight_device *bl; + struct drm_panel panel; +}; + +static int summit_set_brightness(struct device *dev) +{ + struct summit_data *s_data = dev_get_drvdata(dev); + int level = backlight_get_brightness(s_data->bl); + + return mipi_dsi_dcs_set_display_brightness(s_data->dsi, level); +} + +static int summit_bl_update_status(struct backlight_device *dev) +{ + return summit_set_brightness(&dev->dev); +} + +static const struct backlight_ops summit_bl_ops = { + .update_status = summit_bl_update_status, +}; + +static struct drm_display_mode summit_mode = { + .vdisplay = 2008, + .hdisplay = 60, + .hsync_start = 60 + 8, + .hsync_end = 60 + 8 + 80, + .htotal = 60 + 8 + 80 + 40, + .vsync_start = 2008 + 1, + .vsync_end = 2008 + 1 + 15, + .vtotal = 2008 + 1 + 15 + 6, + .clock = ((60 + 8 + 80 + 40) * (2008 + 1 + 15 + 6) * 60) / 1000, + .type = DRM_MODE_TYPE_DRIVER, + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC, +}; + +static int summit_get_modes(struct drm_panel *panel, + struct drm_connector *connector) +{ + connector->display_info.non_desktop = true; + drm_object_property_set_value(&connector->base, + connector->dev->mode_config.non_desktop_property, + connector->display_info.non_desktop); + + return drm_connector_helper_get_modes_fixed(connector, &summit_mode); +} + +static const struct drm_panel_funcs summit_panel_funcs = { + .get_modes = summit_get_modes, +}; + +static int summit_probe(struct mipi_dsi_device *dsi) +{ + struct backlight_properties props = { 0 }; + struct device *dev = &dsi->dev; + struct summit_data *s_data; + int ret; + + s_data = devm_kzalloc(dev, sizeof(*s_data), GFP_KERNEL); + if (!s_data) + return -ENOMEM; + + mipi_dsi_set_drvdata(dsi, s_data); + s_data->dsi = dsi; + + ret = device_property_read_u32(dev, "max-brightness", &props.max_brightness); + if (ret) + return ret; + props.type = BACKLIGHT_RAW; + + s_data->bl = devm_backlight_device_register(dev, dev_name(dev), + dev, s_data, &summit_bl_ops, &props); + if (IS_ERR(s_data->bl)) + return PTR_ERR(s_data->bl); + + drm_panel_init(&s_data->panel, dev, &summit_panel_funcs, + DRM_MODE_CONNECTOR_DSI); + drm_panel_add(&s_data->panel); + + return mipi_dsi_attach(dsi); +} + +static void summit_remove(struct mipi_dsi_device *dsi) +{ + struct summit_data *s_data = mipi_dsi_get_drvdata(dsi); + + mipi_dsi_detach(dsi); + drm_panel_remove(&s_data->panel); +} + +static int summit_suspend(struct device *dev) +{ + struct summit_data *s_data = dev_get_drvdata(dev); + + return mipi_dsi_dcs_set_display_brightness(s_data->dsi, 0); +} + +static DEFINE_SIMPLE_DEV_PM_OPS(summit_pm_ops, summit_suspend, + summit_set_brightness); + +static const struct of_device_id summit_of_match[] = { + { .compatible = "apple,summit" }, + {}, +}; + +MODULE_DEVICE_TABLE(of, summit_of_match); + +static struct mipi_dsi_driver summit_driver = { + .probe = summit_probe, + .remove = summit_remove, + .driver = { + .name = "panel-summit", + .of_match_table = summit_of_match, + .pm = pm_sleep_ptr(&summit_pm_ops), + }, +}; +module_mipi_dsi_driver(summit_driver); + +MODULE_DESCRIPTION("Summit Display Panel Driver"); +MODULE_LICENSE("GPL"); -- 2.48.1 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v7 4/5] arm64: dts: apple: Add touchbar screen nodes 2025-02-17 11:39 [PATCH v7 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay ` (2 preceding siblings ...) 2025-02-17 11:39 ` [PATCH v7 3/5] drm: panel: Add a panel driver for the Summit display Sasha Finkelstein via B4 Relay @ 2025-02-17 11:39 ` Sasha Finkelstein via B4 Relay 2025-02-17 11:39 ` [PATCH v7 5/5] MAINTAINERS: Add entries for touchbar display driver Sasha Finkelstein via B4 Relay ` (3 subsequent siblings) 7 siblings, 0 replies; 19+ messages in thread From: Sasha Finkelstein via B4 Relay @ 2025-02-17 11:39 UTC (permalink / raw) To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jessica Zhang, asahi, Janne Grunau Cc: linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Sasha Finkelstein, Nick Chan, Neal Gompa From: Sasha Finkelstein <fnkl.kernel@gmail.com> Adds device tree entries for the touchbar screen Co-developed-by: Janne Grunau <j@jannau.net> Signed-off-by: Janne Grunau <j@jannau.net> Reviewed-by: Nick Chan <towinchenmi@gmail.com> Reviewed-by: Neal Gompa <neal@gompa.dev> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> --- arch/arm64/boot/dts/apple/t8103-j293.dts | 31 ++++++++++++++++ arch/arm64/boot/dts/apple/t8103.dtsi | 61 ++++++++++++++++++++++++++++++++ arch/arm64/boot/dts/apple/t8112-j493.dts | 31 ++++++++++++++++ arch/arm64/boot/dts/apple/t8112.dtsi | 61 ++++++++++++++++++++++++++++++++ 4 files changed, 184 insertions(+) diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts index 56b0c67bfcda321b60c621de092643017693ff91..3af8536da779b56bf856cf40befd74d4737baa8f 100644 --- a/arch/arm64/boot/dts/apple/t8103-j293.dts +++ b/arch/arm64/boot/dts/apple/t8103-j293.dts @@ -49,3 +49,34 @@ &i2c4 { &fpwm1 { status = "okay"; }; + +&display_dfr { + status = "okay"; +}; + +&dfr_mipi_out { + dfr_mipi_out_panel: endpoint@0 { + reg = <0>; + remote-endpoint = <&dfr_panel_in>; + }; +}; + +&displaydfr_mipi { + status = "okay"; + + dfr_panel: panel@0 { + compatible = "apple,j293-summit", "apple,summit"; + reg = <0>; + max-brightness = <255>; + + port { + dfr_panel_in: endpoint { + remote-endpoint = <&dfr_mipi_out_panel>; + }; + }; + }; +}; + +&displaydfr_dart { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi b/arch/arm64/boot/dts/apple/t8103.dtsi index 9b0dad6b618444ac6b1c9735c50cccfc3965f947..b08176c139ceef913683e41cc7d8a755e6d3216b 100644 --- a/arch/arm64/boot/dts/apple/t8103.dtsi +++ b/arch/arm64/boot/dts/apple/t8103.dtsi @@ -356,6 +356,67 @@ cpufreq_p: performance-controller@211e20000 { #performance-domain-cells = <0>; }; + display_dfr: display-pipe@228200000 { + compatible = "apple,t8103-display-pipe", "apple,h7-display-pipe"; + reg = <0x2 0x28200000 0x0 0xc000>, + <0x2 0x28400000 0x0 0x4000>; + reg-names = "be", "fe"; + power-domains = <&ps_dispdfr_fe>, <&ps_dispdfr_be>; + interrupt-parent = <&aic>; + interrupts = <AIC_IRQ 502 IRQ_TYPE_LEVEL_HIGH>, + <AIC_IRQ 506 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "be", "fe"; + iommus = <&displaydfr_dart 0>; + status = "disabled"; + + port { + dfr_adp_out_mipi: endpoint { + remote-endpoint = <&dfr_mipi_in_adp>; + }; + }; + }; + + displaydfr_dart: iommu@228304000 { + compatible = "apple,t8103-dart"; + reg = <0x2 0x28304000 0x0 0x4000>; + interrupt-parent = <&aic>; + interrupts = <AIC_IRQ 504 IRQ_TYPE_LEVEL_HIGH>; + #iommu-cells = <1>; + power-domains = <&ps_dispdfr_fe>; + status = "disabled"; + }; + + displaydfr_mipi: dsi@228600000 { + compatible = "apple,t8103-display-pipe-mipi", "apple,h7-display-pipe-mipi"; + reg = <0x2 0x28600000 0x0 0x100000>; + power-domains = <&ps_mipi_dsi>; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + dfr_mipi_in: port@0 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + + dfr_mipi_in_adp: endpoint@0 { + reg = <0>; + remote-endpoint = <&dfr_adp_out_mipi>; + }; + }; + + dfr_mipi_out: port@1 { + reg = <1>; + #address-cells = <1>; + #size-cells = <0>; + }; + }; + }; + sio_dart: iommu@235004000 { compatible = "apple,t8103-dart"; reg = <0x2 0x35004000 0x0 0x4000>; diff --git a/arch/arm64/boot/dts/apple/t8112-j493.dts b/arch/arm64/boot/dts/apple/t8112-j493.dts index 0ad908349f55406783942735a2e9dad54cda00ec..372fe69a96f6b84f576221101a4127d68bb54691 100644 --- a/arch/arm64/boot/dts/apple/t8112-j493.dts +++ b/arch/arm64/boot/dts/apple/t8112-j493.dts @@ -35,6 +35,37 @@ led-0 { }; }; +&display_dfr { + status = "okay"; +}; + +&dfr_mipi_out { + dfr_mipi_out_panel: endpoint@0 { + reg = <0>; + remote-endpoint = <&dfr_panel_in>; + }; +}; + +&displaydfr_mipi { + status = "okay"; + + dfr_panel: panel@0 { + compatible = "apple,j493-summit", "apple,summit"; + reg = <0>; + max-brightness = <255>; + + port { + dfr_panel_in: endpoint { + remote-endpoint = <&dfr_mipi_out_panel>; + }; + }; + }; +}; + +&displaydfr_dart { + status = "okay"; +}; + /* * Force the bus number assignments so that we can declare some of the * on-board devices and properties that are populated by the bootloader diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/apple/t8112.dtsi index 1666e6ab250bc0be9b8318e3c8fc903ccd3f3760..1eead9640543632c3ba86c1ff766258e3158c84c 100644 --- a/arch/arm64/boot/dts/apple/t8112.dtsi +++ b/arch/arm64/boot/dts/apple/t8112.dtsi @@ -379,6 +379,67 @@ cpufreq_p: cpufreq@211e20000 { #performance-domain-cells = <0>; }; + display_dfr: display-pipe@228200000 { + compatible = "apple,t8112-display-pipe", "apple,h7-display-pipe"; + reg = <0x2 0x28200000 0x0 0xc000>, + <0x2 0x28400000 0x0 0x4000>; + reg-names = "be", "fe"; + power-domains = <&ps_dispdfr_fe>, <&ps_dispdfr_be>; + interrupt-parent = <&aic>; + interrupts = <AIC_IRQ 614 IRQ_TYPE_LEVEL_HIGH>, + <AIC_IRQ 618 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "be", "fe"; + iommus = <&displaydfr_dart 0>; + status = "disabled"; + + port { + dfr_adp_out_mipi: endpoint { + remote-endpoint = <&dfr_mipi_in_adp>; + }; + }; + }; + + displaydfr_dart: iommu@228304000 { + compatible = "apple,t8110-dart"; + reg = <0x2 0x28304000 0x0 0x4000>; + interrupt-parent = <&aic>; + interrupts = <AIC_IRQ 616 IRQ_TYPE_LEVEL_HIGH>; + #iommu-cells = <1>; + power-domains = <&ps_dispdfr_fe>; + status = "disabled"; + }; + + displaydfr_mipi: dsi@228600000 { + compatible = "apple,t8112-display-pipe-mipi", "apple,h7-display-pipe-mipi"; + reg = <0x2 0x28600000 0x0 0x100000>; + power-domains = <&ps_mipi_dsi>; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + dfr_mipi_in: port@0 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + + dfr_mipi_in_adp: endpoint@0 { + reg = <0>; + remote-endpoint = <&dfr_adp_out_mipi>; + }; + }; + + dfr_mipi_out: port@1 { + reg = <1>; + #address-cells = <1>; + #size-cells = <0>; + }; + }; + }; + sio_dart: iommu@235004000 { compatible = "apple,t8110-dart"; reg = <0x2 0x35004000 0x0 0x4000>; -- 2.48.1 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v7 5/5] MAINTAINERS: Add entries for touchbar display driver 2025-02-17 11:39 [PATCH v7 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay ` (3 preceding siblings ...) 2025-02-17 11:39 ` [PATCH v7 4/5] arm64: dts: apple: Add touchbar screen nodes Sasha Finkelstein via B4 Relay @ 2025-02-17 11:39 ` Sasha Finkelstein via B4 Relay 2025-02-25 10:25 ` (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller Neil Armstrong ` (2 subsequent siblings) 7 siblings, 0 replies; 19+ messages in thread From: Sasha Finkelstein via B4 Relay @ 2025-02-17 11:39 UTC (permalink / raw) To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jessica Zhang, asahi, Janne Grunau Cc: linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Sasha Finkelstein, Neal Gompa From: Sasha Finkelstein <fnkl.kernel@gmail.com> Add the MAINTAINERS entries for the driver Acked-by: Sven Peter <sven@svenpeter.dev> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by: Neal Gompa <neal@gompa.dev> Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> --- MAINTAINERS | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a87ddad78e26f28ffd0f3433560d6db1518f9f95..895d682bcf4e351971b04c6515ebf685fd39b662 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7746,6 +7746,22 @@ F: drivers/gpu/host1x/ F: include/linux/host1x.h F: include/uapi/drm/tegra_drm.h +DRM DRIVERS FOR PRE-DCP APPLE DISPLAY OUTPUT +M: Sasha Finkelstein <fnkl.kernel@gmail.com> +R: Janne Grunau <j@jannau.net> +L: dri-devel@lists.freedesktop.org +L: asahi@lists.linux.dev +S: Maintained +W: https://asahilinux.org +B: https://github.com/AsahiLinux/linux/issues +C: irc://irc.oftc.net/asahi-dev +T: git https://gitlab.freedesktop.org/drm/misc/kernel.git +F: Documentation/devicetree/bindings/display/apple,h7-display-pipe-mipi.yaml +F: Documentation/devicetree/bindings/display/apple,h7-display-pipe.yaml +F: Documentation/devicetree/bindings/display/panel/apple,summit.yaml +F: drivers/gpu/drm/adp/ +F: drivers/gpu/drm/panel/panel-summit.c + DRM DRIVERS FOR RENESAS R-CAR M: Laurent Pinchart <laurent.pinchart@ideasonboard.com> M: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> -- 2.48.1 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller. 2025-02-17 11:39 [PATCH v7 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay ` (4 preceding siblings ...) 2025-02-17 11:39 ` [PATCH v7 5/5] MAINTAINERS: Add entries for touchbar display driver Sasha Finkelstein via B4 Relay @ 2025-02-25 10:25 ` Neil Armstrong 2025-02-25 11:37 ` Dmitry Baryshkov 2025-03-03 16:42 ` Neil Armstrong 2025-03-03 20:03 ` (subset) " Sven Peter 7 siblings, 1 reply; 19+ messages in thread From: Neil Armstrong @ 2025-02-25 10:25 UTC (permalink / raw) To: Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jessica Zhang, asahi, Janne Grunau, Sasha Finkelstein Cc: linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Krzysztof Kozlowski, Neal Gompa, Dmitry Baryshkov, Nick Chan Hi, On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: > This patch series adds support for a secondary display controller > present on Apple M1/M2 chips and used to drive the display of the > "touchbar" touch panel present on those. > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [3/5] drm: panel: Add a panel driver for the Summit display https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/40115947b59f2ca361a47615304dff0a2b69a2b4 -- Neil ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller. 2025-02-25 10:25 ` (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller Neil Armstrong @ 2025-02-25 11:37 ` Dmitry Baryshkov 2025-02-25 17:59 ` Neil Armstrong 0 siblings, 1 reply; 19+ messages in thread From: Dmitry Baryshkov @ 2025-02-25 11:37 UTC (permalink / raw) To: Neil Armstrong Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jessica Zhang, asahi, Janne Grunau, Sasha Finkelstein, linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Krzysztof Kozlowski, Neal Gompa, Nick Chan On Tue, 25 Feb 2025 at 12:25, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > Hi, > > On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: > > This patch series adds support for a secondary display controller > > present on Apple M1/M2 chips and used to drive the display of the > > "touchbar" touch panel present on those. > > > > > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) > > [3/5] drm: panel: Add a panel driver for the Summit display > https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/40115947b59f2ca361a47615304dff0a2b69a2b4 Without the bindings?! -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller. 2025-02-25 11:37 ` Dmitry Baryshkov @ 2025-02-25 17:59 ` Neil Armstrong 2025-02-25 21:00 ` Dmitry Baryshkov 2025-03-03 16:37 ` Rob Herring 0 siblings, 2 replies; 19+ messages in thread From: Neil Armstrong @ 2025-02-25 17:59 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jessica Zhang, asahi, Janne Grunau, Sasha Finkelstein, linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Krzysztof Kozlowski, Neal Gompa, Nick Chan On 25/02/2025 12:37, Dmitry Baryshkov wrote: > On Tue, 25 Feb 2025 at 12:25, Neil Armstrong <neil.armstrong@linaro.org> wrote: >> >> Hi, >> >> On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: >>> This patch series adds support for a secondary display controller >>> present on Apple M1/M2 chips and used to drive the display of the >>> "touchbar" touch panel present on those. >>> >>> >> >> Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) >> >> [3/5] drm: panel: Add a panel driver for the Summit display >> https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/40115947b59f2ca361a47615304dff0a2b69a2b4 > > Without the bindings?! > Bindings will be funneled with the rest of the ADP driver, the panel driver can be applied individually. Neil ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller. 2025-02-25 17:59 ` Neil Armstrong @ 2025-02-25 21:00 ` Dmitry Baryshkov 2025-03-03 16:37 ` Rob Herring 1 sibling, 0 replies; 19+ messages in thread From: Dmitry Baryshkov @ 2025-02-25 21:00 UTC (permalink / raw) To: neil.armstrong Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jessica Zhang, asahi, Janne Grunau, Sasha Finkelstein, linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Krzysztof Kozlowski, Neal Gompa, Nick Chan On Tue, 25 Feb 2025 at 19:59, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > On 25/02/2025 12:37, Dmitry Baryshkov wrote: > > On Tue, 25 Feb 2025 at 12:25, Neil Armstrong <neil.armstrong@linaro.org> wrote: > >> > >> Hi, > >> > >> On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: > >>> This patch series adds support for a secondary display controller > >>> present on Apple M1/M2 chips and used to drive the display of the > >>> "touchbar" touch panel present on those. > >>> > >>> > >> > >> Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) > >> > >> [3/5] drm: panel: Add a panel driver for the Summit display > >> https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/40115947b59f2ca361a47615304dff0a2b69a2b4 > > > > Without the bindings?! > > > > Bindings will be funneled with the rest of the ADP driver, the panel driver can be applied individually. Okay..... -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller. 2025-02-25 17:59 ` Neil Armstrong 2025-02-25 21:00 ` Dmitry Baryshkov @ 2025-03-03 16:37 ` Rob Herring 1 sibling, 0 replies; 19+ messages in thread From: Rob Herring @ 2025-03-03 16:37 UTC (permalink / raw) To: neil.armstrong Cc: Dmitry Baryshkov, Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Krzysztof Kozlowski, Conor Dooley, Jessica Zhang, asahi, Janne Grunau, Sasha Finkelstein, linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Krzysztof Kozlowski, Neal Gompa, Nick Chan On Tue, Feb 25, 2025 at 11:59 AM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > On 25/02/2025 12:37, Dmitry Baryshkov wrote: > > On Tue, 25 Feb 2025 at 12:25, Neil Armstrong <neil.armstrong@linaro.org> wrote: > >> > >> Hi, > >> > >> On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: > >>> This patch series adds support for a secondary display controller > >>> present on Apple M1/M2 chips and used to drive the display of the > >>> "touchbar" touch panel present on those. > >>> > >>> > >> > >> Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) > >> > >> [3/5] drm: panel: Add a panel driver for the Summit display > >> https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/40115947b59f2ca361a47615304dff0a2b69a2b4 > > > > Without the bindings?! > > > > Bindings will be funneled with the rest of the ADP driver, the panel driver can be applied individually. Uh, no. The bindings go with the user. Now 'make dt_compatible_check' reports apple,summit is not documented. Rob ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v7 0/5] Driver for pre-DCP apple display controller. 2025-02-17 11:39 [PATCH v7 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay ` (5 preceding siblings ...) 2025-02-25 10:25 ` (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller Neil Armstrong @ 2025-03-03 16:42 ` Neil Armstrong 2025-03-03 16:43 ` Alyssa Rosenzweig 2025-03-03 20:03 ` (subset) " Sven Peter 7 siblings, 1 reply; 19+ messages in thread From: Neil Armstrong @ 2025-03-03 16:42 UTC (permalink / raw) To: Maxime Ripard, fnkl.kernel, Hector Martin, Sven Peter, Alyssa Rosenzweig, Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jessica Zhang, asahi, Janne Grunau Cc: linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Krzysztof Kozlowski, Neal Gompa, Dmitry Baryshkov, Nick Chan Hi, On 17/02/2025 12:39, Sasha Finkelstein via B4 Relay wrote: > Hi. > > This patch series adds support for a secondary display controller > present on Apple M1/M2 chips and used to drive the display of the > "touchbar" touch panel present on those. > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> > --- > Changes in v7: > - No changes aside from adding r-b trailers, effectively a resend. > - Link to v6: https://lore.kernel.org/r/20250206-adpdrm-v6-0-c8ab9348b853@gmail.com > > Changes in v6: > - Use the drm_connector_helper_get_modes_fixed helper. > - Split out into a separate MAINTAINERS entry > - Link to v5: https://lore.kernel.org/r/20250205-adpdrm-v5-0-4e4ec979bbf2@gmail.com > > Changes in v5: > - Moved to using the component framework. > - Other lifetime fixes > - Link to v4: https://lore.kernel.org/r/20250114-adpdrm-v4-0-e9b5260a39f1@gmail.com > > Changes in v4: > - Fixed dt bindings. > - Link to v3: https://lore.kernel.org/r/20250112-adpdrm-v3-0-c674dc19fa7f@gmail.com > > Changes in v3: > - Fixed building as module after splitting out mipi block > - Addressing the review feedback. > - Link to v2: https://lore.kernel.org/r/20241126-adpdrm-v2-0-c90485336c09@gmail.com > > Changes in v2: > - Addressing the review feedback. > - Split out the mipi part of the display controller into a separate device > - Link to v1: https://lore.kernel.org/r/20241124-adpdrm-v1-0-3191d8e6e49a@gmail.com > > --- > Sasha Finkelstein (5): > dt-bindings: display: Add Apple pre-DCP display controller > drm: adp: Add Apple Display Pipe driver > drm: panel: Add a panel driver for the Summit display > arm64: dts: apple: Add touchbar screen nodes > MAINTAINERS: Add entries for touchbar display driver > > .../display/apple,h7-display-pipe-mipi.yaml | 83 +++ > .../bindings/display/apple,h7-display-pipe.yaml | 88 +++ > .../bindings/display/panel/apple,summit.yaml | 58 ++ > MAINTAINERS | 16 + > arch/arm64/boot/dts/apple/t8103-j293.dts | 31 ++ > arch/arm64/boot/dts/apple/t8103.dtsi | 61 ++ > arch/arm64/boot/dts/apple/t8112-j493.dts | 31 ++ > arch/arm64/boot/dts/apple/t8112.dtsi | 61 ++ > drivers/gpu/drm/Kconfig | 2 + > drivers/gpu/drm/Makefile | 1 + > drivers/gpu/drm/adp/Kconfig | 17 + > drivers/gpu/drm/adp/Makefile | 5 + > drivers/gpu/drm/adp/adp-mipi.c | 276 +++++++++ > drivers/gpu/drm/adp/adp_drv.c | 617 +++++++++++++++++++++ > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-summit.c | 132 +++++ > 17 files changed, 1489 insertions(+) > --- > base-commit: b62cef9a5c673f1b8083159f5dc03c1c5daced2f > change-id: 20241124-adpdrm-25fce3dd8a71 > > All patches are reviewed, can we funnel patches 1, 2 & 5 via drm-misc-next now ? Neil ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v7 0/5] Driver for pre-DCP apple display controller. 2025-03-03 16:42 ` Neil Armstrong @ 2025-03-03 16:43 ` Alyssa Rosenzweig 2025-03-03 16:48 ` Neil Armstrong 2025-03-04 0:01 ` Dmitry Baryshkov 0 siblings, 2 replies; 19+ messages in thread From: Alyssa Rosenzweig @ 2025-03-03 16:43 UTC (permalink / raw) To: Neil Armstrong Cc: Maxime Ripard, fnkl.kernel, Hector Martin, Sven Peter, Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jessica Zhang, asahi, Janne Grunau, linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Krzysztof Kozlowski, Neal Gompa, Dmitry Baryshkov, Nick Chan > > Sasha Finkelstein (5): > > dt-bindings: display: Add Apple pre-DCP display controller > > drm: adp: Add Apple Display Pipe driver > > drm: panel: Add a panel driver for the Summit display > > arm64: dts: apple: Add touchbar screen nodes > > MAINTAINERS: Add entries for touchbar display driver > > > > .../display/apple,h7-display-pipe-mipi.yaml | 83 +++ > > .../bindings/display/apple,h7-display-pipe.yaml | 88 +++ > > .../bindings/display/panel/apple,summit.yaml | 58 ++ > > MAINTAINERS | 16 + > > arch/arm64/boot/dts/apple/t8103-j293.dts | 31 ++ > > arch/arm64/boot/dts/apple/t8103.dtsi | 61 ++ > > arch/arm64/boot/dts/apple/t8112-j493.dts | 31 ++ > > arch/arm64/boot/dts/apple/t8112.dtsi | 61 ++ > > drivers/gpu/drm/Kconfig | 2 + > > drivers/gpu/drm/Makefile | 1 + > > drivers/gpu/drm/adp/Kconfig | 17 + > > drivers/gpu/drm/adp/Makefile | 5 + > > drivers/gpu/drm/adp/adp-mipi.c | 276 +++++++++ > > drivers/gpu/drm/adp/adp_drv.c | 617 +++++++++++++++++++++ > > drivers/gpu/drm/panel/Kconfig | 9 + > > drivers/gpu/drm/panel/Makefile | 1 + > > drivers/gpu/drm/panel/panel-summit.c | 132 +++++ > > 17 files changed, 1489 insertions(+) > > --- > > base-commit: b62cef9a5c673f1b8083159f5dc03c1c5daced2f > > change-id: 20241124-adpdrm-25fce3dd8a71 > > > > > > All patches are reviewed, can we funnel patches 1, 2 & 5 via drm-misc-next now ? I'm planning to do so today, just need to get dim setup first :) ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v7 0/5] Driver for pre-DCP apple display controller. 2025-03-03 16:43 ` Alyssa Rosenzweig @ 2025-03-03 16:48 ` Neil Armstrong 2025-03-04 0:01 ` Dmitry Baryshkov 1 sibling, 0 replies; 19+ messages in thread From: Neil Armstrong @ 2025-03-03 16:48 UTC (permalink / raw) To: Alyssa Rosenzweig Cc: Maxime Ripard, fnkl.kernel, Hector Martin, Sven Peter, Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jessica Zhang, asahi, Janne Grunau, linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Krzysztof Kozlowski, Neal Gompa, Dmitry Baryshkov, Nick Chan On 03/03/2025 17:43, Alyssa Rosenzweig wrote: >>> Sasha Finkelstein (5): >>> dt-bindings: display: Add Apple pre-DCP display controller >>> drm: adp: Add Apple Display Pipe driver >>> drm: panel: Add a panel driver for the Summit display >>> arm64: dts: apple: Add touchbar screen nodes >>> MAINTAINERS: Add entries for touchbar display driver >>> >>> .../display/apple,h7-display-pipe-mipi.yaml | 83 +++ >>> .../bindings/display/apple,h7-display-pipe.yaml | 88 +++ >>> .../bindings/display/panel/apple,summit.yaml | 58 ++ >>> MAINTAINERS | 16 + >>> arch/arm64/boot/dts/apple/t8103-j293.dts | 31 ++ >>> arch/arm64/boot/dts/apple/t8103.dtsi | 61 ++ >>> arch/arm64/boot/dts/apple/t8112-j493.dts | 31 ++ >>> arch/arm64/boot/dts/apple/t8112.dtsi | 61 ++ >>> drivers/gpu/drm/Kconfig | 2 + >>> drivers/gpu/drm/Makefile | 1 + >>> drivers/gpu/drm/adp/Kconfig | 17 + >>> drivers/gpu/drm/adp/Makefile | 5 + >>> drivers/gpu/drm/adp/adp-mipi.c | 276 +++++++++ >>> drivers/gpu/drm/adp/adp_drv.c | 617 +++++++++++++++++++++ >>> drivers/gpu/drm/panel/Kconfig | 9 + >>> drivers/gpu/drm/panel/Makefile | 1 + >>> drivers/gpu/drm/panel/panel-summit.c | 132 +++++ >>> 17 files changed, 1489 insertions(+) >>> --- >>> base-commit: b62cef9a5c673f1b8083159f5dc03c1c5daced2f >>> change-id: 20241124-adpdrm-25fce3dd8a71 >>> >>> >> >> All patches are reviewed, can we funnel patches 1, 2 & 5 via drm-misc-next now ? > > I'm planning to do so today, just need to get dim setup first :) Nice, go ahead then ! Neil ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v7 0/5] Driver for pre-DCP apple display controller. 2025-03-03 16:43 ` Alyssa Rosenzweig 2025-03-03 16:48 ` Neil Armstrong @ 2025-03-04 0:01 ` Dmitry Baryshkov 2025-03-05 13:48 ` Alyssa Rosenzweig 1 sibling, 1 reply; 19+ messages in thread From: Dmitry Baryshkov @ 2025-03-04 0:01 UTC (permalink / raw) To: Alyssa Rosenzweig Cc: Neil Armstrong, Maxime Ripard, fnkl.kernel, Hector Martin, Sven Peter, Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jessica Zhang, asahi, Janne Grunau, linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Krzysztof Kozlowski, Neal Gompa, Nick Chan On Mon, Mar 03, 2025 at 11:43:11AM -0500, Alyssa Rosenzweig wrote: > > > Sasha Finkelstein (5): > > > dt-bindings: display: Add Apple pre-DCP display controller > > > drm: adp: Add Apple Display Pipe driver > > > drm: panel: Add a panel driver for the Summit display > > > arm64: dts: apple: Add touchbar screen nodes > > > MAINTAINERS: Add entries for touchbar display driver > > > > > > .../display/apple,h7-display-pipe-mipi.yaml | 83 +++ > > > .../bindings/display/apple,h7-display-pipe.yaml | 88 +++ > > > .../bindings/display/panel/apple,summit.yaml | 58 ++ > > > MAINTAINERS | 16 + > > > arch/arm64/boot/dts/apple/t8103-j293.dts | 31 ++ > > > arch/arm64/boot/dts/apple/t8103.dtsi | 61 ++ > > > arch/arm64/boot/dts/apple/t8112-j493.dts | 31 ++ > > > arch/arm64/boot/dts/apple/t8112.dtsi | 61 ++ > > > drivers/gpu/drm/Kconfig | 2 + > > > drivers/gpu/drm/Makefile | 1 + > > > drivers/gpu/drm/adp/Kconfig | 17 + > > > drivers/gpu/drm/adp/Makefile | 5 + > > > drivers/gpu/drm/adp/adp-mipi.c | 276 +++++++++ > > > drivers/gpu/drm/adp/adp_drv.c | 617 +++++++++++++++++++++ > > > drivers/gpu/drm/panel/Kconfig | 9 + > > > drivers/gpu/drm/panel/Makefile | 1 + > > > drivers/gpu/drm/panel/panel-summit.c | 132 +++++ > > > 17 files changed, 1489 insertions(+) > > > --- > > > base-commit: b62cef9a5c673f1b8083159f5dc03c1c5daced2f > > > change-id: 20241124-adpdrm-25fce3dd8a71 > > > > > > > > > > All patches are reviewed, can we funnel patches 1, 2 & 5 via drm-misc-next now ? > > I'm planning to do so today, just need to get dim setup first :) Nice! As a heads up, it would be really-really nice if you can send any kind of 'applied' message. If you are using 'dim b4-shazam', then 'b4 ty -a' might do that for you. Otherwise just a simple 'hey, applied' email is useful enough. -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v7 0/5] Driver for pre-DCP apple display controller. 2025-03-04 0:01 ` Dmitry Baryshkov @ 2025-03-05 13:48 ` Alyssa Rosenzweig 0 siblings, 0 replies; 19+ messages in thread From: Alyssa Rosenzweig @ 2025-03-05 13:48 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Neil Armstrong, Maxime Ripard, fnkl.kernel, Hector Martin, Sven Peter, Maarten Lankhorst, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Jessica Zhang, asahi, Janne Grunau, linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Krzysztof Kozlowski, Neal Gompa, Nick Chan > > > All patches are reviewed, can we funnel patches 1, 2 & 5 via drm-misc-next now ? > > > > I'm planning to do so today, just need to get dim setup first :) > > Nice! As a heads up, it would be really-really nice if you can send any > kind of 'applied' message. If you are using 'dim b4-shazam', then > 'b4 ty -a' might do that for you. Otherwise just a simple 'hey, applied' > email is useful enough. Oh cool, it didn't occur to me that `b4 ty` would compose with `dim b4-shazam`. Sent a very belated message and will try to make a habit of it going forward. Thanks for the tip! Cheers, Alyssa ^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller. 2025-02-17 11:39 [PATCH v7 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay ` (6 preceding siblings ...) 2025-03-03 16:42 ` Neil Armstrong @ 2025-03-03 20:03 ` Sven Peter 7 siblings, 0 replies; 19+ messages in thread From: Sven Peter @ 2025-03-03 20:03 UTC (permalink / raw) To: Sasha Finkelstein Cc: Sven Peter, Hector Martin, Alyssa Rosenzweig, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Jessica Zhang, asahi, Janne Grunau, linux-arm-kernel, dri-devel, devicetree, linux-kernel, Alyssa Ross, Krzysztof Kozlowski, Neal Gompa, Dmitry Baryshkov, Nick Chan On Mon, 17 Feb 2025 12:39:30 +0100, Sasha Finkelstein wrote: > This patch series adds support for a secondary display controller > present on Apple M1/M2 chips and used to drive the display of the > "touchbar" touch panel present on those. > > Since the dt-bindings are now part of drm-misc-next I've also applied the dts change, thanks! [4/5] arm64: dts: apple: Add touchbar screen nodes commit: 7275e795e520c7064af52ba67c74d7bac27eea4f Best regards, -- Sven Peter <sven@svenpeter.dev> ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2025-03-05 15:04 UTC | newest] Thread overview: 19+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-02-17 11:39 [PATCH v7 0/5] Driver for pre-DCP apple display controller Sasha Finkelstein via B4 Relay 2025-02-17 11:39 ` [PATCH v7 1/5] dt-bindings: display: Add Apple pre-DCP " Sasha Finkelstein via B4 Relay 2025-02-17 11:39 ` [PATCH v7 2/5] drm: adp: Add Apple Display Pipe driver Sasha Finkelstein via B4 Relay 2025-02-17 13:22 ` Thomas Zimmermann 2025-02-17 13:30 ` Sasha Finkelstein 2025-02-17 11:39 ` [PATCH v7 3/5] drm: panel: Add a panel driver for the Summit display Sasha Finkelstein via B4 Relay 2025-02-17 11:39 ` [PATCH v7 4/5] arm64: dts: apple: Add touchbar screen nodes Sasha Finkelstein via B4 Relay 2025-02-17 11:39 ` [PATCH v7 5/5] MAINTAINERS: Add entries for touchbar display driver Sasha Finkelstein via B4 Relay 2025-02-25 10:25 ` (subset) [PATCH v7 0/5] Driver for pre-DCP apple display controller Neil Armstrong 2025-02-25 11:37 ` Dmitry Baryshkov 2025-02-25 17:59 ` Neil Armstrong 2025-02-25 21:00 ` Dmitry Baryshkov 2025-03-03 16:37 ` Rob Herring 2025-03-03 16:42 ` Neil Armstrong 2025-03-03 16:43 ` Alyssa Rosenzweig 2025-03-03 16:48 ` Neil Armstrong 2025-03-04 0:01 ` Dmitry Baryshkov 2025-03-05 13:48 ` Alyssa Rosenzweig 2025-03-03 20:03 ` (subset) " Sven Peter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).