From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6418C282E5 for ; Wed, 5 Mar 2025 20:18:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BlfG/euYmCskWVm1wTWhPFxNEI+p+lnU32oQtixfjKw=; b=TSraqYVcObauLchWBLZjS8FKzl MZc8VvP9DxfDZt9a1/IvjPJN+wOQP6IdtLnLKkKzofmAIJ9Hns0TCyKdrNP2kipxqlf/NHT8KELHe 06Fp3rgLTlRm/m5j2rUcovXGzvcSrzr6tT/SPuz0kGQQteBhnOR8bjvsWfnVw0PftDq1EIeL/FJ3c YdH/OVp1jrhkv/Y1nyzvbFS5ZkE2Oizl32W+SF2IozWJD71E4WKvbWGEGLTLTahzWdmhiKHkr8aC8 l9LGhGKg3AOPvIHr5cVfbFGmayy4cdsuF2PRPR9DG39939ualSKMbP6Pr4vsY2ZhbPkQmzI5+jz5g j8nc0wOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpvCX-00000009C0n-3j1z; Wed, 05 Mar 2025 20:18:45 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpsvU-00000008qWb-0IUd; Wed, 05 Mar 2025 17:53:01 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AE7785C6BB8; Wed, 5 Mar 2025 17:50:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F10DC4CEE2; Wed, 5 Mar 2025 17:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741197179; bh=hE0MFGTk7bcOjMBBN//SQY7SQOQlJ98ye1JVJhEBqyU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YgLq2Qph/XKnO0vPpE1w+YDPzp+TATFzB/KsCjnTv8bJ7JXTedWgOJQm8tzJLxZgZ RzNeV1nI8Xc2+E/Er4K/hySns3z7+C89eKgfHDUr6QtPU0P5y01Ba1RBAst0pm+6qU mFLXKWzxQEy+Po+4p5IUUfdcPnLlJzrVxqdys88Y/3XRAXIVMDX1fqHm7z0wq3oLAc ji7wVU7OS1ax1G4HnyeM+cI3XG7HBzv9GYCm3VeVF9Nm+ebYUvekUKf7JnvtVEU2qa DZIqOuEuwea+hBvlg7PkrLq3C9fyIilBiwD1tjINhk+UTQelj1WFnTKgjWxTm/3790 lFk35gC77gIuA== Date: Wed, 5 Mar 2025 14:52:56 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: Peter Zijlstra , Ingo Molnar , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , guoren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Charlie Jenkins , Bibo Mao , Huacai Chen , Catalin Marinas , Jiri Slaby , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Howard Chu , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-csky@vger.kernel.org" , linux-riscv@lists.infradead.org, Arnd Bergmann Subject: Re: [PATCH v4 01/11] perf dso: Move libunwind dso_data variables into ifdef Message-ID: References: <20250304050305.901167-1-irogers@google.com> <20250304050305.901167-2-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250304050305.901167-2-irogers@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250305_095300_150197_EFBB5F7D X-CRM114-Status: GOOD ( 14.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 03, 2025 at 09:02:55PM -0800, Ian Rogers wrote: > The variables elf_base_addr, debug_frame_offset, eh_frame_hdr_addr and > eh_frame_hdr_offset are only accessed in unwind-libunwind-local.c > which is conditionally built on having libunwind support. Make the > variables conditional on libunwind support too. Reviewed-by: Arnaldo Carvalho de Melo > Signed-off-by: Ian Rogers > --- > tools/perf/util/dso.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/util/dso.h b/tools/perf/util/dso.h > index bb8e8f444054..dfd763a0bd9d 100644 > --- a/tools/perf/util/dso.h > +++ b/tools/perf/util/dso.h > @@ -154,10 +154,12 @@ struct dso_data { > int status; > u32 status_seen; > u64 file_size; > +#ifdef HAVE_LIBUNWIND_SUPPORT > u64 elf_base_addr; > u64 debug_frame_offset; > u64 eh_frame_hdr_addr; > u64 eh_frame_hdr_offset; > +#endif > }; > > struct dso_bpf_prog { > -- > 2.48.1.711.g2feabab25a-goog