Re: [PATCH v7 1/2] counter: microchip-tcb-capture: Add IRQ handling

[William Breathitt Gray <wbg@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

On Tue, Mar 04, 2025 at 04:51:51PM +0100, Bence Csókás wrote:
> Add interrupt servicing to allow userspace to wait for the following:
> * Change-of-state caused by external trigger
> * Capture of timer value into RA/RB
> * Compare to RC register
> * Overflow
> 
> Signed-off-by: Bence Csókás <csokas.bence@prolan.hu>

Hi Bence,

I'm mostly statisfied with this patch now, but I have one minor
suggestion below.

> @@ -27,6 +33,7 @@ struct mchp_tc_data {
>  	int qdec_mode;
>  	int num_channels;
>  	int channel[2];
> +	int irq;

We don't use the irq member during the driver operation, so I don't
think this value needs to be saved here with the driver data. It seems
to only be needed in mchp_tc_irq_enable() for devm_request_irq().
Perhaps you can pass the irq value as a parameter to
mchp_tc_irq_enable() instead.

With that change made, I think I'll be ready to pick up this patchset
and merge it into counter-next.

William Breathitt Gray

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]