From: Alyssa Rosenzweig <alyssa@rosenzweig.io>
To: fnkl.kernel@gmail.com
Cc: Sven Peter <sven@svenpeter.dev>, Janne Grunau <j@jannau.net>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Jean-Francois Bortolotti <jeff@borto.fr>
Subject: Re: [PATCH v2 2/3] spmi: add a spmi driver for Apple SoC
Date: Fri, 7 Mar 2025 16:59:20 -0500 [thread overview]
Message-ID: <Z8tsOKbxVOXmOicF@blossom> (raw)
In-Reply-To: <20250307-spmi-v2-2-eccdb06afb99@gmail.com>
> +static inline u32 read_reg(struct apple_spmi *spmi, int offset)
> +{
> + return readl(spmi->regs + offset);
> +}
> +
> +static inline void write_reg(u32 value, struct apple_spmi *spmi, int offset)
> +{
> + writel(value, spmi->regs + offset);
> +}
At this point I don't think these are gaining us anything. Can we inline
them?
next prev parent reply other threads:[~2025-03-07 22:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 20:08 [PATCH v2 0/3] Driver for the Apple SPMI controller Sasha Finkelstein via B4 Relay
2025-03-07 20:08 ` [PATCH v2 1/3] dt-bindings: spmi: Add " Sasha Finkelstein via B4 Relay
2025-03-08 9:50 ` Sven Peter
2025-03-07 20:09 ` [PATCH v2 2/3] spmi: add a spmi driver for Apple SoC Sasha Finkelstein via B4 Relay
2025-03-07 21:59 ` Alyssa Rosenzweig [this message]
2025-03-08 9:43 ` Sven Peter
2025-03-07 20:09 ` [PATCH v2 3/3] arm64: dts: apple: Add SPMI controller nodes Sasha Finkelstein via B4 Relay
2025-03-08 9:47 ` Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8tsOKbxVOXmOicF@blossom \
--to=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fnkl.kernel@gmail.com \
--cc=j@jannau.net \
--cc=jeff@borto.fr \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).