From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAF53C282EC for ; Sat, 8 Mar 2025 15:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ajS+tFou1Gk5QnOTsH1BYVe0HyridnWxeu31BiCyPA4=; b=bJKwVhX9optxavlju43ODmbmMu kZgBd7mbJzQG6wIdglpxYUSU2J4gw0Cry+dmPEeJr2t3Ofbkiq7fWEQqCiEwuFLnaHtBQ8x3idZIC +kKr9fAqQYNZEm0wtQh4UBRqUoFWLSR1p995jUbOPn/xFpJ12aM3YhsWBPQOjymde6P/jHkBVI28y Bd3r69znU5SCbYg5CkoPZIp4HT8pihthwgF2R0igXUDgBf8QpvOz9H1yQxTWLNzZvsEZp1GBlW8eo 6nf8VRpEMZ9i62KP3HS3JF1BqD/kmTqn4t7NDpciTwxVhtWqgP798lD4TQdvTKnsB+XA18SfQTbfZ ERiUZg1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tqw7I-0000000GnIv-1ykj; Sat, 08 Mar 2025 15:29:32 +0000 Received: from layka.disroot.org ([178.21.23.139]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tqw5e-0000000Gn8j-1bYq; Sat, 08 Mar 2025 15:27:52 +0000 Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id C074025B9B; Sat, 8 Mar 2025 16:27:44 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id DXIS_cdflHBn; Sat, 8 Mar 2025 16:27:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1741447664; bh=BzbdGhFUgbWVE36GSc3NNkv4xumU2hEjxnkJ3qaNKvA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=YEB9KXBSTSSxK41VGw2GC7PrpTTMzDI2U5XmJyAEGPEb94zjWE4AbiD0RxINY17+1 4XL7MXJ2AT3qa9I+ZIWh+m7STiSpUEkqX6fAXKH0s1CCkEaMGvh9z8PN/2+MgYWPXR B4bfUgc/37PlGfmXwu9rla9qnEL6qjzdnvvYs78Mg6O5vGci6tDQ466GSBnnhH9PYj 3UrAyT9rSExMAcnggY3s6LrDSHHfttlQQhCvgtF2r307Hp7jZo0gfS3ZyjVIEjBZQy xVRZxwEGWyOKmltxDOKfq1kPRdGDjlDbLF0+cbt0OmozVZSXlorn69J05DTnS63NHe gwbQFasUTva3w== Date: Sat, 8 Mar 2025 15:27:22 +0000 From: Yao Zi To: Jonas Karlman , Chukun Pan Cc: conor+dt@kernel.org, cristian.ciocaltea@collabora.com, detlev.casanova@collabora.com, devicetree@vger.kernel.org, heiko@sntech.de, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 8/8] arm64: dts: rockchip: Enable SD-card interface on Radxa E20C Message-ID: References: <20250305194638.47187-1-ziyao@disroot.org> <20250307033508.656479-1-amadeus@jmu.edu.cn> <5a0a7ce1-1dfb-4d19-8a1e-0d89d177f5b8@kwiboo.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5a0a7ce1-1dfb-4d19-8a1e-0d89d177f5b8@kwiboo.se> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250308_072750_996185_F89EC3BB X-CRM114-Status: GOOD ( 25.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonas, On Fri, Mar 07, 2025 at 07:45:00AM +0100, Jonas Karlman wrote: > Hi Chukun, > > On 2025-03-07 06:52, Yao Zi wrote: > > On Fri, Mar 07, 2025 at 11:35:08AM +0800, Chukun Pan wrote: > >> Hi, > >> > >>> +&sdmmc { > >>> + bus-width = <4>; > >>> + cap-mmc-highspeed; > >>> + cap-sd-highspeed; > >>> + disable-wp; > >>> + no-sdio; > >> > >> With 'no-sdio' property: > >> [ 129.608986] mmc_host mmc1: Bus speed (slot 0) = 400000Hz (slot req 400000Hz, actual 400000HZ div = 0) > >> [ 130.711168] mmc1: Card stuck being busy! __mmc_poll_for_busy > >> [ 130.725536] mmc_host mmc1: Bus speed (slot 0) = 300000Hz (slot req 300000Hz, actual 300000HZ div = 0) > >> [ 131.751240] mmc1: Card stuck being busy! __mmc_poll_for_busy > >> [ 131.765608] mmc_host mmc1: Bus speed (slot 0) = 200000Hz (slot req 200000Hz, actual 200000HZ div = 0) > >> [ 132.825083] mmc1: Card stuck being busy! __mmc_poll_for_busy > >> [ 132.839413] mmc_host mmc1: Bus speed (slot 0) = 187500Hz (slot req 187500Hz, actual 187500HZ div = 0) > >> [ 133.960141] mmc1: Card stuck being busy! __mmc_poll_for_busy > >> > >> Without 'no-sdio' property: > >> [ 105.224019] mmc1: error -22 whilst initialising SDIO card > >> [ 106.290838] mmc1: Card stuck being busy! __mmc_poll_for_busy > >> [ 106.801931] dwmmc_rockchip ffc30000.mmc: Busy; trying anyway > >> [ 107.385835] mmc_host mmc1: Timeou sending command (cmd 0x202000 arg 0x0 status 0x80202000) > >> [ 107.400425] mmc_host mmc1: Bus speed (slot 0) = 300000Hz (slot req 300000Hz, actual 300000HZ div = 0) > >> [ 107.431561] mmc_host mmc1: Bus speed (slot 0) = 49800000Hz (slot req 50000000Hz, actual 49800000HZ div = 0) > >> [ 107.433107] mmc1: new high speed SDIO card at address 0001 > > > > So it seems the sdmmc controller actually works with SDIO commands as > > well? I don't expect that since the datasheet says RK3528 has only two > > SDIO 3.0 controllers. > > > > We could remove the "no-sdio" property if SDIO actually works. Will > > apply it in the next version if there's no objection against this. > > On the E20C the sdmmc controller is routed to a microSD card slot mainly > intended for use with microSD-cards and should normally not need SDIO. As pointed out by Chukun, I found the hardware design guide for RK3528[1] (in Chinese) does claim that SDIO 3.0 is supported on all these three controllers in Chapter 2.3.1 (SDMMC/SDIO), RK3528 集成了 1 个 SDMMC 控制器和 2 个 SDIO 控制器，均可支持 SDIO3.0 协 议，以及 MMC V4.51 协议。其中 SDIO0 和 SDIO1 最高可支持 200MHz，SDMMC 最高只支持到 150MHz translated to English, RK3528 integrates one SDMMC controller and two SDIO controllers, all support SDIO3.0 protocol and MMC V4.51 protocol. Among them SDIO0 and SDIO1 support 200MHz frequency at maximum, and SDMMC supports up to 150MHz. So I think there's no reason to explicitly deny SDIO initialization sequence for the controller on Radxa E20C. imho this won't break anything even for a sdcard slot, will it? Additionally, this piece of information points out that wrong max-frequency is set for SDIO{0,1}. Rockchip overrides the frequency in devicetrees for the demo boards[2], I'm not sure whether it's for some speical reason or not. Since I don't have a SDIO-capable board on hand, could you please test whether 200MHz actually works? If so I'll correct the SoC devicetree in v3. > What card/adapter do you have inserted in the microSD card slot that > requires use of SDIO instead of just SD or MMC? What is the use case you > have that requires removal of no-sdio on E20C? > > Regards, > Jonas > > > > > Further tests about the capabilities of the controller are welcome. > > > >> # cat /sys/kernel/debug/mmc1/ios > >> clock: 50000000 Hz > >> vdd: 21 (3.3 ~ 3.4 V) > >> bus mode: 2 (push-pull) > >> chip select: 0 (don't care) > >> power mode: 2 (on) > >> bus width: 2 (4 bits) > >> timing spec: 2 (sd high-speed) > >> signal voltage: 0 (3.30 V) > >> driver type: 0 (driver type B) > >> > >> Thanks, > >> Chukun > >> > >> -- > >> 2.25.1 > >> > > > > Best regards, > > Yao Zi > Thanks, Yao Zi [1]: https://github.com/DeciHD/rockchip_docs/blob/main/rk3528/RK3528%20Hardware%20Design%20Guide-CN-V1.0-20230525.pdf [2]: https://github.com/rockchip-linux/kernel/blob/604cec4004abe5a96c734f2fab7b74809d2d742f/arch/arm64/boot/dts/rockchip/rk3528-demo1-lp4-v10.dtsi#L47