* [PATCH v2] staging: bcm2835-camera: Modify function call formatting
@ 2025-03-22 15:36 Abraham Samuel Adekunle
0 siblings, 0 replies; only message in thread
From: Abraham Samuel Adekunle @ 2025-03-22 15:36 UTC (permalink / raw)
To: Greg Kroah-Hartman, Julia Lawall, outreachy
Cc: Florian Fainelli, Broadcom internal kernel review list, Ray Jui,
Scott Branden, linux-staging, linux-rpi-kernel, linux-arm-kernel,
linux-kernel
The line is a function call which ends with an opening parenthesis
thereby not adhering to the Linux kernel coding style.
Modify the function call to include parameters on the same line as
the opening parenthesis to improve readability and consistency while
adhering to Linux coding styles.
Reported by checkpatch:
CHECK: Lines should not end with '('
Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
---
Changes in v2:
- Add more patch recipients.
.../vc04_services/bcm2835-camera/controls.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c
index 6bce45925bf1..e670226f1edf 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
@@ -533,17 +533,15 @@ static int ctrl_set_image_effect(struct bcm2835_mmal_dev *dev,
control = &dev->component[COMP_CAMERA]->control;
- ret = vchiq_mmal_port_parameter_set(
- dev->instance, control,
- MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS,
- &imagefx, sizeof(imagefx));
+ ret = vchiq_mmal_port_parameter_set(dev->instance, control,
+ MMAL_PARAMETER_IMAGE_EFFECT_PARAMETERS,
+ &imagefx, sizeof(imagefx));
if (ret)
goto exit;
- ret = vchiq_mmal_port_parameter_set(
- dev->instance, control,
- MMAL_PARAMETER_COLOUR_EFFECT,
- &dev->colourfx, sizeof(dev->colourfx));
+ ret = vchiq_mmal_port_parameter_set(dev->instance, control,
+ MMAL_PARAMETER_COLOUR_EFFECT,
+ &dev->colourfx, sizeof(dev->colourfx));
}
exit:
--
2.34.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-03-22 15:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-22 15:36 [PATCH v2] staging: bcm2835-camera: Modify function call formatting Abraham Samuel Adekunle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox