From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E596FC28B28 for ; Wed, 12 Mar 2025 13:32:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=O7nXrf8enrrb8z3uABVuZMTlrSLNofRDk6iKufuqXac=; b=2/1C8mMvdWvmUR0cZfg2JPUrIo lV6wEjwG/nI9FaElTYVsMqJ3sOgT9+bi4HZOl+nnV4+HBx7WxqcG3odCZOc53oAEJ+UaFO15hXumi u4i4GpF8YmdxLnY/v6hKqWJJm8Vz0Dq+oKL4InVwNmJrPOVHAu5mMbPEkwoueeN8U3KXDagjpJu8e VXZPm/iJMP0xjDQzJ8oOfK2FkJGBGa4Up4JCrpt5hed8bU7jRKkZE80RSh1ajl5i6mtFX7n+KRc1d MOBCip96TOgQl4bBcvi7suTFQR4YPX0pjbOtGfmRj6djMfprq7JSY2AFEneh3kbGs5IkkhalxsL90 ttUP4+cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tsMCM-00000008Zpe-3ixr; Wed, 12 Mar 2025 13:32:38 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tsLT0-00000008RnJ-3TA4 for linux-arm-kernel@lists.infradead.org; Wed, 12 Mar 2025 12:45:48 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-43cf3192d8bso42635e9.1 for ; Wed, 12 Mar 2025 05:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741783545; x=1742388345; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=O7nXrf8enrrb8z3uABVuZMTlrSLNofRDk6iKufuqXac=; b=AW8d+0ghk6sUxA9J8RO+Sz8kf47QUC1ICA90qXp1iaIPTR6aCSCRab+M0YbezVRkZq /0RnHT2oUYpm6LL1isGKByWMHZnErQSn5KMcDGnccKpQEh1Wi1ORfL5rZgg4th1LihU5 SMYGN7TbJ7zYdTPrWUDvvM3UDpE/f2hxFnW2le64Mtr7x5ihWSfKYRRyJyaBmxYlwyob +rYdK+Cgz8qB8yXBE4GQ65dB0xErA7kcv1uJilUskxKB3iAv6wCwniDzx749gC7p53Fv EKxi65PyG8qfvYy/Utq8QbF8HpALKX2/hOFtRHsBvcPL3ValVOUpprI3Zi9xAncixlg3 ny/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741783545; x=1742388345; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O7nXrf8enrrb8z3uABVuZMTlrSLNofRDk6iKufuqXac=; b=WxK7E5uWgTdrm2DzNvNnX7kVYN+D5LmoCsgPJ8WUJBnUycY+G7arwxwqvQhEnhXSg0 iuUjZYFC+PXb+7sbWfwSHtysGEC50Ku9YuXQtjL+9dyBv7TKmSANHTzFyXQ1aeBubxob +8U9iU8BSMvNm1D9puK23ZyEt8qB5SiScnN8P6H3RW01yVuOmtmYfVhesF8wlJ6GAE5c co3qPyGsMLKFclEZRwI2/lyEoznVuCuYbbFEP1u0Nr2TU4lHMyiOgOhy4PaaCSxi5WzH jp/lzRNJi+m7s8UVZJHS+q4TZgAOMdU8//38FWbMaaAPNsTV5QHIPC8fVVP3fIOOpX1m zhRg== X-Forwarded-Encrypted: i=1; AJvYcCVXpuVqMv2w2D0uM5KiraXU7qgDnyp5ry75UIJhDxnx3syKhnodz+Y8bRtiKuggSyMg5kIXTapmlMmP9KQekHhs@lists.infradead.org X-Gm-Message-State: AOJu0YxR0Ks3LNxT2i38gdU4uYw8D60H9C5H0PJ+KZe9Cr1QhRabTPED Nlo70/iT1PpaQhtBpq9Doj0WFtctECB1S99aCqZiBKfFCg8j+l+BQpMfZL5EWA== X-Gm-Gg: ASbGncsM90LbsjgtHmNkjBlSG8srwtO1KTCTdK8JnMAUXBAdwRIM8s7Q5222lafVYkb O4b1WHS2Kab3psMTPCTTjGOFLr/CVFnEMy0dAWY0vl7XehzqYGr56VcrSik7TFJ2aT7lEJz75YV wFXjSnOFvH6lCdXeaqsSmO/mv5V0ZfncKmF5oiwHedZ0TA7fRbCOh9NBk9KT2NiYz19esWsWwYX RKcM6r/HNbc0p/VXDUsqMHWew7Yywlf5R2hVRqA+HT+Y9wIj0N26/wd6RcoBe7q7mGI4/wtaeYc e2fbnrxvaMznR8BkDbJ8WNdU9iXfJjCA7JOGRpCkVOwJaY5o2v2L5XAuhVF5Sykl38I83d2OdoY uEAMhS/hWuZD/m9g= X-Google-Smtp-Source: AGHT+IGl6ij5XGs/qN6P6iUkVVrm0h4AAzKswiqP0QsBVlB9onr8dRHcRoIgJqJfm8N1ML/DsO9qAQ== X-Received: by 2002:a05:600c:5801:b0:43b:bfe9:8b43 with SMTP id 5b1f17b1804b1-43d09ea3748mr1245205e9.4.1741783544916; Wed, 12 Mar 2025 05:45:44 -0700 (PDT) Received: from google.com (88.140.78.34.bc.googleusercontent.com. [34.78.140.88]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d0a8c5d0fsm20697625e9.32.2025.03.12.05.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Mar 2025 05:45:44 -0700 (PDT) Date: Wed, 12 Mar 2025 12:45:39 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: Alim Akhtar , Alyssa Rosenzweig , Albert Ou , asahi@lists.linux.dev, Lu Baolu , David Woodhouse , Heiko Stuebner , iommu@lists.linux.dev, Jernej Skrabec , Jonathan Hunter , Joerg Roedel , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, Marek Szyprowski , Hector Martin , Palmer Dabbelt , Paul Walmsley , Robin Murphy , Samuel Holland , Suravee Suthikulpanit , Sven Peter , Thierry Reding , Tomasz Jeznach , Krishna Reddy , Chen-Yu Tsai , Will Deacon , Bagas Sanjaya , Joerg Roedel , Pasha Tatashin , patches@lists.linux.dev, David Rientjes , Matthew Wilcox Subject: Re: [PATCH v3 15/23] iommu/pages: Move the __GFP_HIGHMEM checks into the common code Message-ID: References: <0-v3-e797f4dc6918+93057-iommu_pages_jgg@nvidia.com> <15-v3-e797f4dc6918+93057-iommu_pages_jgg@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15-v3-e797f4dc6918+93057-iommu_pages_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250312_054546_877402_80A2155B X-CRM114-Status: GOOD ( 22.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 25, 2025 at 03:39:32PM -0400, Jason Gunthorpe wrote: > The entire allocator API is built around using the kernel virtual address, > it is illegal to pass GFP_HIGHMEM in as a GFP flag. Block it in the common > code. Remove the duplicated checks from drivers. > > Reviewed-by: Lu Baolu > Signed-off-by: Jason Gunthorpe Reviewed-by: Mostafa Saleh > --- > drivers/iommu/io-pgtable-arm.c | 2 -- > drivers/iommu/io-pgtable-dart.c | 1 - > drivers/iommu/iommu-pages.c | 4 ++++ > 3 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.c > index 62df2528d020b2..08d0f62abe8a09 100644 > --- a/drivers/iommu/io-pgtable-arm.c > +++ b/drivers/iommu/io-pgtable-arm.c > @@ -267,8 +267,6 @@ static void *__arm_lpae_alloc_pages(size_t size, gfp_t gfp, > dma_addr_t dma; > void *pages; > > - VM_BUG_ON((gfp & __GFP_HIGHMEM)); > - > if (cfg->alloc) > pages = cfg->alloc(cookie, size, gfp); > else > diff --git a/drivers/iommu/io-pgtable-dart.c b/drivers/iommu/io-pgtable-dart.c > index 7efcaea0bd5c86..ebf330e67bfa30 100644 > --- a/drivers/iommu/io-pgtable-dart.c > +++ b/drivers/iommu/io-pgtable-dart.c > @@ -111,7 +111,6 @@ static void *__dart_alloc_pages(size_t size, gfp_t gfp) > { > int order = get_order(size); > > - VM_BUG_ON((gfp & __GFP_HIGHMEM)); > return iommu_alloc_pages(gfp, order); > } > > diff --git a/drivers/iommu/iommu-pages.c b/drivers/iommu/iommu-pages.c > index 3077df642adb1f..a7eed09420a231 100644 > --- a/drivers/iommu/iommu-pages.c > +++ b/drivers/iommu/iommu-pages.c > @@ -37,6 +37,10 @@ void *iommu_alloc_pages_node(int nid, gfp_t gfp, unsigned int order) > const unsigned long pgcnt = 1UL << order; > struct folio *folio; > > + /* This uses page_address() on the memory. */ > + if (WARN_ON(gfp & __GFP_HIGHMEM)) > + return NULL; > + > /* > * __folio_alloc_node() does not handle NUMA_NO_NODE like > * alloc_pages_node() did. > -- > 2.43.0 >