Re: [PATCH v2 1/4] KVM: arm64: Use the static initializer for the vesion lock

Will Deacon
2025-03-05T01:44:57Z

On Thu, Feb 27, 2025 at 06:17:46PM +0000, Sebastian Ene wrote:
> Replace the definition of the hypervisor version lock
> with a static initializer.
>
> Signed-off-by: Sebastian Ene <sebastianene@google.com>
> ---
> arch/arm64/kvm/hyp/nvhe/ffa.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/kvm/hyp/nvhe/ffa.c b/arch/arm64/kvm/hyp/nvhe/ffa.c
> index e433dfab882a..6df6131f1107 100644
> --- a/arch/arm64/kvm/hyp/nvhe/ffa.c
> +++ b/arch/arm64/kvm/hyp/nvhe/ffa.c
> @@ -69,7 +69,7 @@ static struct kvm_ffa_buffers hyp_buffers;
> static struct kvm_ffa_buffers host_buffers;
> static u32 hyp_ffa_version;
> static bool has_version_negotiated;
> -static hyp_spinlock_t version_lock;
> +static DEFINE_HYP_SPINLOCK(version_lock);
>
> static void ffa_to_smccc_error(struct arm_smccc_res *res, u64 ffa_errno)
> {
> @@ -911,6 +911,5 @@ int hyp_ffa_init(void *pages)
> .lock = __HYP_SPIN_LOCK_UNLOCKED,
> };
>
> - version_lock = __HYP_SPIN_LOCK_UNLOCKED;
> return 0;

nit: typo in the subject (s/vesion/version/).

With that fixed:

Acked-by: Will Deacon <will@kernel.org>

Will