* [PATCH 2/2] ARM: dts: bananapi: add support for PHY LEDs
[not found] <20250312193629.85417-1-michael@fossekall.de>
@ 2025-03-12 19:36 ` Michael Klein
2025-03-13 6:07 ` Jernej Škrabec
0 siblings, 1 reply; 6+ messages in thread
From: Michael Klein @ 2025-03-12 19:36 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland
Cc: Michael Klein, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel
The Bananapi M1 has three LEDs connected to the RTL8211E ethernet PHY.
Add the corresponding nodes to the device tree.
Signed-off-by: Michael Klein <michael@fossekall.de>
---
.../boot/dts/allwinner/sun7i-a20-bananapi.dts | 27 +++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
index 46ecf9db2324..4976453ed192 100644
--- a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
+++ b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
@@ -48,6 +48,7 @@
#include <dt-bindings/gpio/gpio.h>
#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/leds/common.h>
/ {
model = "LeMaker Banana Pi";
@@ -169,6 +170,32 @@ &ir0 {
&gmac_mdio {
phy1: ethernet-phy@1 {
reg = <1>;
+
+ leds {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ led@0 {
+ reg = <0>;
+ color = <LED_COLOR_ID_GREEN>;
+ default-state = "keep";
+ linux,default-trigger = "netdev";
+ };
+
+ led@1 {
+ reg = <1>;
+ color = <LED_COLOR_ID_AMBER>;
+ default-state = "keep";
+ linux,default-trigger = "netdev";
+ };
+
+ led@2 {
+ reg = <2>;
+ color = <LED_COLOR_ID_BLUE>;
+ default-state = "keep";
+ linux,default-trigger = "netdev";
+ };
+ };
};
};
--
2.39.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: bananapi: add support for PHY LEDs
2025-03-12 19:36 ` [PATCH 2/2] ARM: dts: bananapi: add support for PHY LEDs Michael Klein
@ 2025-03-13 6:07 ` Jernej Škrabec
2025-03-13 8:34 ` Michael Klein
0 siblings, 1 reply; 6+ messages in thread
From: Jernej Škrabec @ 2025-03-13 6:07 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Samuel Holland, Michael Klein
Cc: Michael Klein, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel
Hi,
Dne sreda, 12. marec 2025 ob 20:36:28 Srednjeevropski standardni čas je Michael Klein napisal(a):
> The Bananapi M1 has three LEDs connected to the RTL8211E ethernet PHY.
> Add the corresponding nodes to the device tree.
>
> Signed-off-by: Michael Klein <michael@fossekall.de>
This is patch 2/2. Which one is patch 1/2? I got only one.
Best regards,
Jernej
> ---
> .../boot/dts/allwinner/sun7i-a20-bananapi.dts | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
> index 46ecf9db2324..4976453ed192 100644
> --- a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
> +++ b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
> @@ -48,6 +48,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/leds/common.h>
>
> / {
> model = "LeMaker Banana Pi";
> @@ -169,6 +170,32 @@ &ir0 {
> &gmac_mdio {
> phy1: ethernet-phy@1 {
> reg = <1>;
> +
> + leds {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@0 {
> + reg = <0>;
> + color = <LED_COLOR_ID_GREEN>;
> + default-state = "keep";
> + linux,default-trigger = "netdev";
> + };
> +
> + led@1 {
> + reg = <1>;
> + color = <LED_COLOR_ID_AMBER>;
> + default-state = "keep";
> + linux,default-trigger = "netdev";
> + };
> +
> + led@2 {
> + reg = <2>;
> + color = <LED_COLOR_ID_BLUE>;
> + default-state = "keep";
> + linux,default-trigger = "netdev";
> + };
> + };
> };
> };
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: bananapi: add support for PHY LEDs
2025-03-13 6:07 ` Jernej Škrabec
@ 2025-03-13 8:34 ` Michael Klein
2025-03-13 10:40 ` Andre Przywara
0 siblings, 1 reply; 6+ messages in thread
From: Michael Klein @ 2025-03-13 8:34 UTC (permalink / raw)
To: Jernej Škrabec
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Samuel Holland, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel
Hi,
On Thu, Mar 13, 2025 at 07:07:24AM +0100, Jernej Škrabec wrote:
>Dne sreda, 12. marec 2025 ob 20:36:28 Srednjeevropski standardni čas je Michael Klein napisal(a):
>> The Bananapi M1 has three LEDs connected to the RTL8211E ethernet PHY.
>> Add the corresponding nodes to the device tree.
>>
>> Signed-off-by: Michael Klein <michael@fossekall.de>
>
>This is patch 2/2. Which one is patch 1/2? I got only one.
https://patchwork.kernel.org/project/netdevbpf/patch/20250312193629.85417-1-michael@fossekall.de/
Sorry for any inconvenience in case I messed up the patch submission.
I made two commits for this change and submitted them via `git send-email
HEAD^^`. The first patch went to netdev@vger.kernel.org, the second
to linux-arm-kernel@lists.infradead.org, which seems logical. Have I
done something wrong?
>Best regards,
>Jernej
Michael
>
>> ---
>> .../boot/dts/allwinner/sun7i-a20-bananapi.dts | 27 +++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
>> index 46ecf9db2324..4976453ed192 100644
>> --- a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
>> +++ b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
>> @@ -48,6 +48,7 @@
>>
>> #include <dt-bindings/gpio/gpio.h>
>> #include <dt-bindings/interrupt-controller/irq.h>
>> +#include <dt-bindings/leds/common.h>
>>
>> / {
>> model = "LeMaker Banana Pi";
>> @@ -169,6 +170,32 @@ &ir0 {
>> &gmac_mdio {
>> phy1: ethernet-phy@1 {
>> reg = <1>;
>> +
>> + leds {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + led@0 {
>> + reg = <0>;
>> + color = <LED_COLOR_ID_GREEN>;
>> + default-state = "keep";
>> + linux,default-trigger = "netdev";
>> + };
>> +
>> + led@1 {
>> + reg = <1>;
>> + color = <LED_COLOR_ID_AMBER>;
>> + default-state = "keep";
>> + linux,default-trigger = "netdev";
>> + };
>> +
>> + led@2 {
>> + reg = <2>;
>> + color = <LED_COLOR_ID_BLUE>;
>> + default-state = "keep";
>> + linux,default-trigger = "netdev";
>> + };
>> + };
>> };
>> };
>>
>>
>
>
>
>
>
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: bananapi: add support for PHY LEDs
2025-03-13 8:34 ` Michael Klein
@ 2025-03-13 10:40 ` Andre Przywara
2025-03-13 13:17 ` Andrew Lunn
0 siblings, 1 reply; 6+ messages in thread
From: Andre Przywara @ 2025-03-13 10:40 UTC (permalink / raw)
To: Michael Klein
Cc: Jernej Škrabec, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Chen-Yu Tsai, Samuel Holland, devicetree,
linux-arm-kernel, linux-sunxi, linux-kernel
On Thu, 13 Mar 2025 09:34:50 +0100
Michael Klein <michael@fossekall.de> wrote:
Hi,
> On Thu, Mar 13, 2025 at 07:07:24AM +0100, Jernej Škrabec wrote:
> >Dne sreda, 12. marec 2025 ob 20:36:28 Srednjeevropski standardni čas je Michael Klein napisal(a):
> >> The Bananapi M1 has three LEDs connected to the RTL8211E ethernet PHY.
> >> Add the corresponding nodes to the device tree.
> >>
> >> Signed-off-by: Michael Klein <michael@fossekall.de>
> >
> >This is patch 2/2. Which one is patch 1/2? I got only one.
>
> https://patchwork.kernel.org/project/netdevbpf/patch/20250312193629.85417-1-michael@fossekall.de/
>
> Sorry for any inconvenience in case I messed up the patch submission.
>
> I made two commits for this change and submitted them via `git send-email
> HEAD^^`. The first patch went to netdev@vger.kernel.org, the second
> to linux-arm-kernel@lists.infradead.org, which seems logical. Have I
> done something wrong?
Well, for those really small "series" it's probably better to send all
patches to everyone, especially if the first patch gives some context,
without which the second leaves people (like me) scratching their head.
Also in this case a cover letter would help
(git format-patch --cover-letter), to give some idea of what you are after.
Cheers,
Andre
>
> >Best regards,
> >Jernej
>
> Michael
>
> >
> >> ---
> >> .../boot/dts/allwinner/sun7i-a20-bananapi.dts | 27 +++++++++++++++++++
> >> 1 file changed, 27 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
> >> index 46ecf9db2324..4976453ed192 100644
> >> --- a/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
> >> +++ b/arch/arm/boot/dts/allwinner/sun7i-a20-bananapi.dts
> >> @@ -48,6 +48,7 @@
> >>
> >> #include <dt-bindings/gpio/gpio.h>
> >> #include <dt-bindings/interrupt-controller/irq.h>
> >> +#include <dt-bindings/leds/common.h>
> >>
> >> / {
> >> model = "LeMaker Banana Pi";
> >> @@ -169,6 +170,32 @@ &ir0 {
> >> &gmac_mdio {
> >> phy1: ethernet-phy@1 {
> >> reg = <1>;
> >> +
> >> + leds {
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + led@0 {
> >> + reg = <0>;
> >> + color = <LED_COLOR_ID_GREEN>;
> >> + default-state = "keep";
> >> + linux,default-trigger = "netdev";
> >> + };
> >> +
> >> + led@1 {
> >> + reg = <1>;
> >> + color = <LED_COLOR_ID_AMBER>;
> >> + default-state = "keep";
> >> + linux,default-trigger = "netdev";
> >> + };
> >> +
> >> + led@2 {
> >> + reg = <2>;
> >> + color = <LED_COLOR_ID_BLUE>;
> >> + default-state = "keep";
> >> + linux,default-trigger = "netdev";
> >> + };
> >> + };
> >> };
> >> };
> >>
> >>
> >
> >
> >
> >
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: bananapi: add support for PHY LEDs
2025-03-13 10:40 ` Andre Przywara
@ 2025-03-13 13:17 ` Andrew Lunn
2025-03-13 16:20 ` Michael Klein
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2025-03-13 13:17 UTC (permalink / raw)
To: Andre Przywara
Cc: Michael Klein, Jernej Škrabec, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai, Samuel Holland,
devicetree, linux-arm-kernel, linux-sunxi, linux-kernel
On Thu, Mar 13, 2025 at 10:40:42AM +0000, Andre Przywara wrote:
> On Thu, 13 Mar 2025 09:34:50 +0100
> Michael Klein <michael@fossekall.de> wrote:
>
> Hi,
>
> > On Thu, Mar 13, 2025 at 07:07:24AM +0100, Jernej Škrabec wrote:
> > >Dne sreda, 12. marec 2025 ob 20:36:28 Srednjeevropski standardni čas je Michael Klein napisal(a):
> > >> The Bananapi M1 has three LEDs connected to the RTL8211E ethernet PHY.
> > >> Add the corresponding nodes to the device tree.
> > >>
> > >> Signed-off-by: Michael Klein <michael@fossekall.de>
> > >
> > >This is patch 2/2. Which one is patch 1/2? I got only one.
> >
> > https://patchwork.kernel.org/project/netdevbpf/patch/20250312193629.85417-1-michael@fossekall.de/
> >
> > Sorry for any inconvenience in case I messed up the patch submission.
> >
> > I made two commits for this change and submitted them via `git send-email
> > HEAD^^`. The first patch went to netdev@vger.kernel.org, the second
> > to linux-arm-kernel@lists.infradead.org, which seems logical. Have I
> > done something wrong?
>
> Well, for those really small "series" it's probably better to send all
> patches to everyone, especially if the first patch gives some context,
> without which the second leaves people (like me) scratching their head.
However, netdev does not like pathchsets which contain patches which
should not be applied to the netdev tree. DT patches generally go
through a different Maintainer to driver changes implementing the
binding.
So for your DT patch, you could add to the commit message something
like:
The RTL8211E ethernet PHY driver has recently gained support for
controlling PHY LEDs via /sys/class/leds. The Bananapi M1 has three
LEDs connected to the RTL8211E PHY. Add the corresponding nodes to
the device tree.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ARM: dts: bananapi: add support for PHY LEDs
2025-03-13 13:17 ` Andrew Lunn
@ 2025-03-13 16:20 ` Michael Klein
0 siblings, 0 replies; 6+ messages in thread
From: Michael Klein @ 2025-03-13 16:20 UTC (permalink / raw)
To: Andrew Lunn
Cc: Andre Przywara, Jernej Škrabec, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai, Samuel Holland,
devicetree, linux-arm-kernel, linux-sunxi, linux-kernel
On Thu, Mar 13, 2025 at 02:17:27PM +0100, Andrew Lunn wrote:
>On Thu, Mar 13, 2025 at 10:40:42AM +0000, Andre Przywara wrote:
>> On Thu, 13 Mar 2025 09:34:50 +0100
>> Michael Klein <michael@fossekall.de> wrote:
>> > On Thu, Mar 13, 2025 at 07:07:24AM +0100, Jernej Škrabec wrote:
>> > >Dne sreda, 12. marec 2025 ob 20:36:28 Srednjeevropski standardni čas je Michael Klein napisal(a):
>> > >> The Bananapi M1 has three LEDs connected to the RTL8211E ethernet PHY.
>> > >> Add the corresponding nodes to the device tree.
>> > >>
>> > >> Signed-off-by: Michael Klein <michael@fossekall.de>
>> > >
>> > >This is patch 2/2. Which one is patch 1/2? I got only one.
>> >
>> > https://patchwork.kernel.org/project/netdevbpf/patch/20250312193629.85417-1-michael@fossekall.de/
>> >
>> > Sorry for any inconvenience in case I messed up the patch submission.
>> >
>> > I made two commits for this change and submitted them via `git send-email
>> > HEAD^^`. The first patch went to netdev@vger.kernel.org, the second
>> > to linux-arm-kernel@lists.infradead.org, which seems logical. Have I
>> > done something wrong?
>>
>> Well, for those really small "series" it's probably better to send all
>> patches to everyone, especially if the first patch gives some context,
>> without which the second leaves people (like me) scratching their head.
>
>However, netdev does not like pathchsets which contain patches which
>should not be applied to the netdev tree. DT patches generally go
>through a different Maintainer to driver changes implementing the
>binding.
>
>So for your DT patch, you could add to the commit message something
>like:
>
>The RTL8211E ethernet PHY driver has recently gained support for
>controlling PHY LEDs via /sys/class/leds. The Bananapi M1 has three
>LEDs connected to the RTL8211E PHY. Add the corresponding nodes to
>the device tree.
Thanks, this totally makes sense. I'll split the patch series then and
follow-up here with the updated commit message when the netdev change is
accepted.
--
Michael
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-03-13 17:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250312193629.85417-1-michael@fossekall.de>
2025-03-12 19:36 ` [PATCH 2/2] ARM: dts: bananapi: add support for PHY LEDs Michael Klein
2025-03-13 6:07 ` Jernej Škrabec
2025-03-13 8:34 ` Michael Klein
2025-03-13 10:40 ` Andre Przywara
2025-03-13 13:17 ` Andrew Lunn
2025-03-13 16:20 ` Michael Klein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).