From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E70CDC28B28 for ; Sun, 16 Mar 2025 01:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IU2BU/m+gg/7SnQNAFBVGJwC/Skp0+6Fhqe3NKjxVE4=; b=bXRmhVwyNPY0kVSCTyat316fYJ 5PDZf3zHR5fLPjFG4ldGmEmjqgHEZfd7czs4sZNetEUJewpzUxBptqIeIcMMrQ8HF6YtAckSoe/RQ Dy1DcVo46r3UZFlrbVhd3PG5y/gLhPl1fXV4AwMnavh4FiAtgZuqdzIVR431j2TxbMez/YbKI8Xjo JbwpPmFhyDzRzPxNSxbPhHh8dZnutzbnhW9yE8sPl8xc9XiYFS+99q9uJN/4xBjjk9SisKLXRbVPG 4DtrvMgUvbx4tpqhGc8vtAsFOBfcEK8On+6R3KuoAienKYg7fcUvhQqXKMxivY8SoCy15jUpDrBGB UiDsSFEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1ttciB-0000000H4j7-3wOi; Sun, 16 Mar 2025 01:22:43 +0000 Received: from mail-westeuropeazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c201::5] helo=AS8PR03CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1ttcgS-0000000H4VA-2YtH for linux-arm-kernel@lists.infradead.org; Sun, 16 Mar 2025 01:20:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=zNCX7L5flk1JqFf/4Ox+s2JqQbuCu5Nk/lgrfYJXCqTKq/LeEL9fqmtX0VDZbm/XAhNRsHSZCJiF+DMXh6TtzYmFqUfmh2COAkIkP8e1BqtuEb5yCPqRItfGIKeIlgHp4i9KS+Hs/1Sz+lgNzmrHaI5DLbVO7IoqT9NR524l7wrskdcYqAbGw3vrEdbVuzUWXRPK8BayMAsqaJ7VJjMV9nblIhD8uROFKW5K7WcuaZuH89ibr2h1geD5WIw3W6Yp615pVFkb9wgch5yFjueblyMWfe/vvyjaQfJMJraejJrXXSyD55yM1rdlgDnr1pIKO67dH58twe9blQGlB3Dfaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IU2BU/m+gg/7SnQNAFBVGJwC/Skp0+6Fhqe3NKjxVE4=; b=ZgHDdbpXdCz2B22zwMGi+Lv57hu0Uz1CfvBUI5+jD+v26N0co4iQquf3w83I7uNbqRiBGD+AGDFtkN/sLMyba5QynPPGztXckrP3fqgf443o2LSymZvypSenX3NOyAay9dsWbDJ4d3c78EStInMDn6OMv/9GsQUMD/ahPO0c1vom5TFK5v0sf5iH2HiDdRvRaY9T2FNzJiL2tf1E8iNJFPj7oqdGmV7+wotvhK1b0J1s3KUdVkyhZQHqRsn/gbZ6IVDz6PPYwtqoMXrqQfqYwVaIinIe5BVnJP6wKNqXzDOgFUF+n4tWaohUgou48gewum+IbhjQ/alLOMJpKrKRcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IU2BU/m+gg/7SnQNAFBVGJwC/Skp0+6Fhqe3NKjxVE4=; b=daZEOC4vLEvGwcE2slGn9C9c7o3FbCNTaHzRIOswfndAyrYYYwPUiao9jy+k6yl5OT3hF1iYIzPTZtFUFPg0SCx8AMfMytZ0aQHGioYPguzUPsf6wWKc8Y1I21y3j4BND9x7k3lB3rxQUsUqK2wEA9ELSq+25mikf2fd6YAXmDXPYOJDvJfxOyV48sfPdviuSdCwvloYayj1aN2uCUCvWfUHdAxFrwBAbA/ft19zF6l5m++U8w5LUv+uVncD95sIh1pNQkiuPyIjJdDJa5l5bmJi7vMvchSSrthOfxaUB1zF8+VptWp+DXP0BU3sjrF2gpPb5YPa4qAp8tFQCS3GsQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AS5PR04MB10020.eurprd04.prod.outlook.com (2603:10a6:20b:682::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8511.28; Sun, 16 Mar 2025 01:20:52 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%3]) with mapi id 15.20.8511.026; Sun, 16 Mar 2025 01:20:52 +0000 Date: Sat, 15 Mar 2025 21:20:42 -0400 From: Frank Li To: Bjorn Helgaas Cc: Rob Herring , Saravana Kannan , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Fabio Estevam , Niklas Cassel , Pengutronix Kernel Team , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Bjorn Helgaas Subject: Re: [PATCH v12 05/13] PCI: dwc: Add dw_pcie_parent_bus_offset() Message-ID: References: <20250315201548.858189-1-helgaas@kernel.org> <20250315201548.858189-6-helgaas@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250315201548.858189-6-helgaas@kernel.org> X-ClientProxiedBy: SJ0PR03CA0179.namprd03.prod.outlook.com (2603:10b6:a03:338::34) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AS5PR04MB10020:EE_ X-MS-Office365-Filtering-Correlation-Id: 20219d4b-de29-4817-7a59-08dd6428cafc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?O/jObtWL6gvk/IKvTUHS5AFYcBzG4yJG/sAcswYlR5EiwnrhSNS3GoAuXs5/?= =?us-ascii?Q?HuxgUZEFIwdBRscsXshgMdK7SPoT+m8tksUgIl7m5csdNkv7ZMhEZsO8xTu3?= =?us-ascii?Q?ZD6fEEQf+jaWA/VzqUPuQ1Nc6/yo5M6+uJ27ZgKIpsXQaZeqbuC+jqsCNDAH?= =?us-ascii?Q?1pn05540cS5GRt+34RoUQzr9IdyvfLROs3EKAZIvaQ3UYojv/xcuJ+o9Hoer?= =?us-ascii?Q?1S83Z8iaw1uX0bsyiUwVyO2nzgccghJ7RnTgv757u+Ffhahy0I7TC9UdyEIJ?= =?us-ascii?Q?uUx//BgOW8BAXiPFPb9uqD/7YJwKrIqgf8ID9MAPGgi6uH4Im7IVuNBJw8Nb?= =?us-ascii?Q?pkJo6/Qbf2l31nSZ2la71Np9TPfnADZf6XLFkGyPwZ5W3SFH5fa2/RHBP9fv?= =?us-ascii?Q?33NXyT0rSlj1RVXQahBr0izqnNcVcql2510SnXJaEY1MocTxqAZdWJBGwY2X?= =?us-ascii?Q?C7ZOGCiN2VW9qfOMK+/0PDA9chC6kaCtfEQiflz76svOZVEKu8eJRZ+Fopia?= =?us-ascii?Q?oBT9U7zIp9q789O/13nE4AEAEM24ICYKHiUY5qcBMLSXWg5K20UDB97im0oe?= =?us-ascii?Q?gIpzHVykOczhuesf36xy3sa6ZKxlTF7vzRkeHmJFps7T/Bpd2hC9WaEmwtzw?= =?us-ascii?Q?Ela5w+vfSVfV9ilQc9WgtRJ0+bJiRxZxtDjmDWMmRF0+iy0uhKzn0XLY4vlW?= =?us-ascii?Q?Sie7J1Ke8NkhUQM63u5Aa6frp5Z/gPcuzXMyRPxv7xe4yE/Km96DDdPngiZ3?= =?us-ascii?Q?u1Dd+HHffyMI2gTAoeK+259sQaUpifZgsaW2q+Dz5zqYY8CUdICT4IYmPr9R?= =?us-ascii?Q?uvL94TzCkxzK+W2DsgvIdKRv6qMqKxlh8aKkziMthgpelx+opgwwpoEfk3PF?= =?us-ascii?Q?fmU19PcBok8OEo/mfHQV8nmMPHQLvqUi2jYNLW74VPap9URF2URXjU24m6T0?= =?us-ascii?Q?GWxpVAbx85W9Gc0fCb/7lXORpf2QpyoiIGSHY0rzdeHPVqdizTHO8Jo2zBwl?= =?us-ascii?Q?z1t2X75MY4I6O1/Ko7Qjm+Dpu0b+iudeXRstBAMHezVeaX9pf+yvrk66N04S?= =?us-ascii?Q?YIzslOIiTDEI/jgTVIh91CQvHr0QeGkaqScKmveh/Ct1moCo03BZSSQXSvBz?= =?us-ascii?Q?30J/S8EaiKjf9nrZCDSvUtuzaVrKSmzU14sUzNEDrHgEYZDfJBkh8LXYzC3u?= =?us-ascii?Q?Y6soOtvFsoq4pu/weMrLACG8rBH1vVbijSlmTQOM2s3ycngSd8E9H2EswAlq?= =?us-ascii?Q?s1/Q2fnao+G/clIOr6bVO5r5Hc7Q1GvMv18mFCTOXLGj669XtoEgu0JMxKi0?= =?us-ascii?Q?sHf7Sr0jMc6DRNr/pcAttvAohtXfZMQw+znHYkwVQVv0TwoeHOTVkldSnr9S?= =?us-ascii?Q?F4G6bxmqvcqCSTAEsH00pG5LEIHm3sa0PdRkGwV3WvBF3cbzTBTzqPahKYD+?= =?us-ascii?Q?OWF1km7VgtfOJriVA5P0v6XoFZxY2tz4?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?e5tX6lfX57/jDM1WSjM5b1eedngTCOFspbtqcJUbwWXNc1mQhPQDWHuBhABr?= =?us-ascii?Q?bfl4vuWmBThBW/ugpGCXFC/5pBwygOO9Sthrnx3SfY7f6P8ZJMZtKt1Zndna?= =?us-ascii?Q?coEETLcnObW8ib9b7IAeftYcGKdrBF8e+3RQDuM6jcyHRdViKQg7peSQquvd?= =?us-ascii?Q?6gNvSPYvIdLqrdMz4XDsm/+PpQjzi3v/pIVmsSbnESbQBjVzHUUx6UY0gGVl?= =?us-ascii?Q?jvrUAqRaSaGzcXZIdCF3Tb5xhphqr0FTX9qdmUHOdn2fxf48vdXpkQ1s5ZMc?= =?us-ascii?Q?Gq+RUHOMNPUhphH5MAxVlvlF9/xKaOEltdrt6YnrnLWe9KjKLyGhYdond1D4?= =?us-ascii?Q?5XBuLyDgFUeZ/qK2Ui8+yaRPlRgFYUP93kGKDpzYS/UQAYwOsN4sCzxrgyua?= =?us-ascii?Q?qLfrcoHMvrhL4PCO1qL/TUN3elAmp0sG3wEdVFa6T3lZUjyyQ0PpgJeXzIbP?= =?us-ascii?Q?7B1/O6iWqOBZqQk+qG1k6IsdQbUKEWfz5ffqldQEkPF+0dskt9gwY5tM3t6G?= =?us-ascii?Q?c6ihaancQZjuNWOMvnMcA/ujUZDLZvpWcBiz2Ho5KSdoQWkIW9g/eQnm/8ar?= =?us-ascii?Q?rj4PUm3LzE84l8GMsASyxdFHKfc7GTQs+e9j/AOhKyr75Z0uSAsWAHeOXdhS?= =?us-ascii?Q?JMzB5HbeWrDDqIXvdFogwns9B8IV7C4qe5EoVGkdeuwHqQUs2zWSFIANFYR2?= =?us-ascii?Q?8lyUXLdmDQf1rvRS7ClEiYrJ6DZBk2yWxpCd7HjDYK5U4e+D6lFFq2ZHta0a?= =?us-ascii?Q?Gv934DwrcCmIzTKE2MzpBSJl6AP5bkAX8DBAJ2EdXVF5qjSNN6X3rqed5FP/?= =?us-ascii?Q?NEMrE08Lu6lCzedFWGdgW+qwJ+W1g8/7MSUgJ55pOilodywynMzlCpUQOPAc?= =?us-ascii?Q?JS7q9SUTJwFPH34JE/T6x3qmKtzDoS47TYxjcNjvDDvjFZ2dmPyKzaUx0hpd?= =?us-ascii?Q?jzFZ552O0SkpWvWxuwPwiEuXiN/7bvo8rN1bGvu5G/2DRcDyzK/K9uwsO7+Y?= =?us-ascii?Q?Jicxo6oUjFWZvVbibFJtUZDioJ33eAbff5Qj17G471WWZv81OpYKsb9fDgMJ?= =?us-ascii?Q?VFRaT1M9sd9uS7HqzopaohoT0lpPsbYhLAKin5ifsZHKw6rCjwIwAzkVat3t?= =?us-ascii?Q?1ExmvBy6zNHn3l+sHDDR3ZkM2Nxoah9cOYvYt9QBT1dZKUPfVEqXRMo7AFcu?= =?us-ascii?Q?V9Yw8QkHgvKNECLJ2KZioDiZJZ5utxhoZFqR2tx8q65KYmyg2Fbyxh8EgGiJ?= =?us-ascii?Q?5LxzwCtErl2wVXbLYff13/11k9w0uXJZkkczHm7azzaq5D0KINyN20vZYq6s?= =?us-ascii?Q?zA2bn4Hfo188Bw6+MYSY8QR3lbiXyZySj8kQ7h3x4g1ukrwF380tmD88xNia?= =?us-ascii?Q?OUbrWg1j8fBygRmNTnfr0QDMzkz+mwGb72PqS3tUtZQHRpE6wGwxnPRHBVD/?= =?us-ascii?Q?fJK3vLxluK8fSJtdCOfddVV0NylXqW9T4EiWYu6gBL5QB120pL8OM6D2vDRa?= =?us-ascii?Q?A7DUEWMlZ0LZcuRk/lCLlfIcXaNndY2CEdMGRjhgx5nCtRWbX3LPzrR5v4w1?= =?us-ascii?Q?m257mHeEVQVCvFn0tI0=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20219d4b-de29-4817-7a59-08dd6428cafc X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2025 01:20:52.4762 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MO2x3ZHVoBuleuk7cSFWmm65VAwixOKfYw3PWAbgF5HkHOGpVJbCBMrBg/EBza73k3Zb2RX/0yu8EXSa7cmEsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB10020 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250315_182056_653429_05160A2F X-CRM114-Status: GOOD ( 18.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 15, 2025 at 03:15:40PM -0500, Bjorn Helgaas wrote: > From: Frank Li > > Return the offset from CPU physical address to the parent bus address of > the specified element of the devicetree 'reg' property. > > [bhelgaas: return offset, split .cpu_addr_fixup() checking and debug to > separate patch] > Link: https://lore.kernel.org/r/20250313-pci_fixup_addr-v11-5-01d2313502ab@nxp.com > Signed-off-by: Frank Li > Signed-off-by: Bjorn Helgaas > --- look good! > drivers/pci/controller/dwc/pcie-designware.c | 23 ++++++++++++++++++++ > drivers/pci/controller/dwc/pcie-designware.h | 3 +++ > 2 files changed, 26 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > index 9d0a5f75effc..0a35e36da703 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.c > +++ b/drivers/pci/controller/dwc/pcie-designware.c > @@ -16,6 +16,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1105,3 +1106,25 @@ void dw_pcie_setup(struct dw_pcie *pci) > > dw_pcie_link_set_max_link_width(pci, pci->num_lanes); > } > + > +resource_size_t dw_pcie_parent_bus_offset(struct dw_pcie *pci, > + const char *reg_name, > + resource_size_t cpu_phy_addr) > +{ > + struct device *dev = pci->dev; > + struct device_node *np = dev->of_node; > + int index; > + u64 reg_addr; > + > + /* Look up reg_name address on parent bus */ > + index = of_property_match_string(np, "reg-names", reg_name); > + > + if (index < 0) { > + dev_err(dev, "No %s in devicetree \"reg\" property\n", reg_name); > + return 0; > + } > + > + of_property_read_reg(np, index, ®_addr, NULL); > + > + return cpu_phy_addr - reg_addr; > +} > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h > index d0d8c622a6e8..16548b01347d 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.h > +++ b/drivers/pci/controller/dwc/pcie-designware.h > @@ -500,6 +500,9 @@ void dw_pcie_setup(struct dw_pcie *pci); > void dw_pcie_iatu_detect(struct dw_pcie *pci); > int dw_pcie_edma_detect(struct dw_pcie *pci); > void dw_pcie_edma_remove(struct dw_pcie *pci); > +resource_size_t dw_pcie_parent_bus_offset(struct dw_pcie *pci, > + const char *reg_name, > + resource_size_t cpu_phy_addr); > > static inline void dw_pcie_writel_dbi(struct dw_pcie *pci, u32 reg, u32 val) > { > -- > 2.34.1 >