From: Yao Zi <ziyao@disroot.org>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Rob Herring <robh@kernel.org>, Jonas Karlman <jonas@kwiboo.se>,
Heiko Stuebner <heiko@sntech.de>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: rockchip: Add missing uart3 interrupt for RK3528
Date: Tue, 18 Mar 2025 12:12:33 +0000 [thread overview]
Message-ID: <Z9ljMc96QoCNzzq3@pie> (raw)
In-Reply-To: <20250318100010.2253408-2-amadeus@jmu.edu.cn>
On Tue, Mar 18, 2025 at 06:00:08PM +0800, Chukun Pan wrote:
> The interrupt of uart3 node on rk3528 is missing, fix it.
>
> Fixes: 7983e6c379a9 ("arm64: dts: rockchip: Add base DT for rk3528 SoC")
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Reviewed-by: Yao Zi <ziyao@disroot.org>
Thanks for catching this, seems I messed uart3 up when cleaning the
devicetree.
> ---
> arch/arm64/boot/dts/rockchip/rk3528.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3528.dtsi b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> index 26c3559d6a6d..7f1ffd6003f5 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3528.dtsi
> @@ -404,9 +404,10 @@ uart2: serial@ffa00000 {
>
> uart3: serial@ffa08000 {
> compatible = "rockchip,rk3528-uart", "snps,dw-apb-uart";
> + reg = <0x0 0xffa08000 0x0 0x100>;
> clocks = <&cru SCLK_UART3>, <&cru PCLK_UART3>;
> clock-names = "baudclk", "apb_pclk";
> - reg = <0x0 0xffa08000 0x0 0x100>;
> + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
> reg-io-width = <4>;
> reg-shift = <2>;
> status = "disabled";
> --
> 2.25.1
>
next prev parent reply other threads:[~2025-03-18 12:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 10:00 [PATCH 0/3] arm64: dts: rockchip: Add DMA controller for RK3528 Chukun Pan
2025-03-18 10:00 ` [PATCH 1/3] arm64: dts: rockchip: Add missing uart3 interrupt " Chukun Pan
2025-03-18 12:12 ` Yao Zi [this message]
2025-03-18 10:00 ` [PATCH 2/3] arm64: dts: rockchip: Add DMA controller " Chukun Pan
2025-03-23 21:04 ` Jonas Karlman
2025-03-18 10:00 ` [PATCH 3/3] arm64: dts: rockchip: Add UART DMA support " Chukun Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9ljMc96QoCNzzq3@pie \
--to=ziyao@disroot.org \
--cc=amadeus@jmu.edu.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox