public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Alberto Merciai <alb3rt0.m3rciai@gmail.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<imx@lists.linux.dev>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>,
	Frank Li <Frank.Li@nxp.com>
Subject: Re: [PATCH] arm64: dtsi: imx93: add alias id for bbnsm_rtc
Date: Tue, 18 Mar 2025 16:49:23 +0100	[thread overview]
Message-ID: <Z9mWA5ldMDqZcVf5@alb3rt0-ThinkPad-P15-Gen-1> (raw)
In-Reply-To: <116096172.nniJfEyVGO@steina-w>

On Fri, Mar 07, 2025 at 11:19:13AM +0100, Alexander Stein wrote:
> Hi,
> 
> Am Donnerstag, 6. März 2025, 20:30:14 CET schrieb Frank Li:
> > From: Joy Zou <joy.zou@nxp.com>
> > 
> > Add rtc0 alias to set bbnsm_rtc as the default rtc.
> > 
> > Signed-off-by: Joy Zou <joy.zou@nxp.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx93.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > index 56766fdb0b1e5..7d9aa15ebf5d0 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> > @@ -34,6 +34,7 @@ aliases {
> >  		mmc0 = &usdhc1;
> >  		mmc1 = &usdhc2;
> >  		mmc2 = &usdhc3;
> > +		rtc0 = &bbnsm_rtc;
> 
> IMHO this is a board property, not SoC property.
> 
> Best regards
> Alexander
> 
> >  		serial0 = &lpuart1;
> >  		serial1 = &lpuart2;
> >  		serial2 = &lpuart3;
> > 
> 
> 
> -- 
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
> 
> 
> 
I agree with Alexander, furthermore if we look to others dtsi we don't
create this relationship at soc level even if we have rtc there, is not?

for example:
arch/arm64/boot/dts/freescale/imx8mp.dtsi
arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi

Regards,
Alberto


      reply	other threads:[~2025-03-18 15:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 19:30 [PATCH] arm64: dtsi: imx93: add alias id for bbnsm_rtc Frank Li
2025-03-07 10:19 ` Alexander Stein
2025-03-18 15:49   ` Alberto Merciai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z9mWA5ldMDqZcVf5@alb3rt0-ThinkPad-P15-Gen-1 \
    --to=alb3rt0.m3rciai@gmail.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox