From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA20BC6FA8E for ; Thu, 2 Mar 2023 03:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I74XwRsNeeViFNxCpqxqyPAzsm5BN0Ez9Y9Q+oY4YIk=; b=pcdoZkvKe3CVtC qV/46pZClLyicXmGSG1lJs39d77N3CR8fwK+yDQQdXJgEXYc24Q8P7bRDCtwOjL9Q9/R8jSh3HpD9 ga/Lbae9e10Eh8FZf6pKFwt7GcFEIZkMhPQLN57IqV2h5nta1e+WjLvzl8lXQApDb4T2Jk9Nuc1fq diFXZyBspM6K/uYf6vasQh8hMi0wGujSKPDsEOK2O+OvR3WvWyTs3DETWZ44CK+lD2Y5Wp6Y0RS0e e1K3mb8EKZUK68nz11MMk4hwQSMRK6n6oqPsuXv3xip1M0nUlMyTAEAfrWNOKBr2NAGTQCs1qLKoJ 8sX1cWrKRgvZua9ypSIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXa3c-000jny-AJ; Thu, 02 Mar 2023 03:56:40 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pXa3X-000jn4-Aw for linux-arm-kernel@lists.infradead.org; Thu, 02 Mar 2023 03:56:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677729392; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Grs0Xm2F8lTmefjOhyT/L35DEvt2ZshN4421DWTG63E=; b=dCMFwuaeB40ybELJYW4H7OXjyfMFKmeJh8h9y90hiLIc4YOrgGOzZsbeOTqMa8opiaOd7s lLXBP5IezHKpeBUOIXALOsp3xlVqjhZnY6urqtE7LbPhJuXnC1Ooub/jQmd1gntX/tz7T4 YvyrbklIgFJhqwG2ZpLUiRrfaUzqw+0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-213-F4SkhlxXMiSukBC0RPf_lw-1; Wed, 01 Mar 2023 22:56:29 -0500 X-MC-Unique: F4SkhlxXMiSukBC0RPf_lw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CAAC01C189A0; Thu, 2 Mar 2023 03:56:28 +0000 (UTC) Received: from localhost (ovpn-12-47.pek2.redhat.com [10.72.12.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF13E2166B26; Thu, 2 Mar 2023 03:56:27 +0000 (UTC) Date: Thu, 2 Mar 2023 11:56:24 +0800 From: Baoquan He To: "Leizhen (ThunderTown)" Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com, horms@kernel.org, John.p.donnelly@oracle.com, will@kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3] arm64: kdump: simplify the reservation behaviour of crashkernel=,high Message-ID: References: <20230223124532.128744-1-bhe@redhat.com> <7971ddbe-aefb-271e-647c-59d81c5840a7@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7971ddbe-aefb-271e-647c-59d81c5840a7@huawei.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230301_195635_674725_72251522 X-CRM114-Status: GOOD ( 32.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 03/02/23 at 11:32am, Leizhen (ThunderTown) wrote: > > > On 2023/2/23 20:45, Baoquan He wrote: ...... > There are two minor review comments, see below. Otherwise: Makes sense, all accepted. Will update and repost. Thanks for careful reviewing. > > Reviewed-by: Zhen Lei > > > > > Signed-off-by: Baoquan He > > --- > > v2->v3: > > - Rephrase patch log to clarify the current crashkernel high > > reservation could cross the high and low memory boundary, but not > > 4G boundary only, because RPi4 of arm64 has high and low memory > > boudary as 1G. The v3 patch log could mislead people that the RPi4 > > also use 4G as high,low memory boundary. > > v1->v2: > > - Fold patch 2 of v1 into patch 1 for better reviewing. > > - Update patch log to add more details. > > arch/arm64/mm/init.c | 43 +++++++++++++++++++++++++++++++++---------- > > 1 file changed, 33 insertions(+), 10 deletions(-) > > > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > > index 58a0bb2c17f1..b8cb780df0cb 100644 > > --- a/arch/arm64/mm/init.c > > +++ b/arch/arm64/mm/init.c > > @@ -127,12 +127,13 @@ static int __init reserve_crashkernel_low(unsigned long long low_size) > > */ > > static void __init reserve_crashkernel(void) > > { > > - unsigned long long crash_base, crash_size; > > - unsigned long long crash_low_size = 0; > > + unsigned long long crash_base, crash_size, search_base; > > unsigned long long crash_max = CRASH_ADDR_LOW_MAX; > > + unsigned long long crash_low_size = 0; > > char *cmdline = boot_command_line; > > - int ret; > > bool fixed_base = false; > > + bool high = false; > > + int ret; > > > > if (!IS_ENABLED(CONFIG_KEXEC_CORE)) > > return; > > @@ -155,7 +156,9 @@ static void __init reserve_crashkernel(void) > > else if (ret) > > return; > > > > + search_base = CRASH_ADDR_LOW_MAX; > > crash_max = CRASH_ADDR_HIGH_MAX; > > + high = true; > > } else if (ret || !crash_size) { > > /* The specified value is invalid */ > > return; > > @@ -166,31 +169,51 @@ static void __init reserve_crashkernel(void) > > /* User specifies base address explicitly. */ > > if (crash_base) { > > fixed_base = true; > > + search_base = crash_base; > > crash_max = crash_base + crash_size; > > } > > > > retry: > > crash_base = memblock_phys_alloc_range(crash_size, CRASH_ALIGN, > > - crash_base, crash_max); > > + search_base, crash_max); > > if (!crash_base) { > > /* > > - * If the first attempt was for low memory, fall back to > > - * high memory, the minimum required low memory will be > > - * reserved later. > > + * For crashkernel=size[KMG]@offset[KMG], print out failure > > + * message if can't reserve the specified region. > > */ > > - if (!fixed_base && (crash_max == CRASH_ADDR_LOW_MAX)) { > > + if (fixed_base) { > > + pr_info("crashkernel reservation failed - memory is in use.\n"); > > How about changing pr_info to pr_warn? > > > + return; > > + } > > + > > + /* > > + * For crashkernel=size[KMG], if the first attempt was for > > + * low memory, fall back to high memory, the minimum required > > + * low memory will be reserved later. > > + */ > > + if (!high && crash_max == CRASH_ADDR_LOW_MAX) { > > crash_max = CRASH_ADDR_HIGH_MAX; > > + search_base = CRASH_ADDR_LOW_MAX; > > crash_low_size = DEFAULT_CRASH_KERNEL_LOW_SIZE; > > goto retry; > > } > > > > + /* > > + * For crashkernel=size[KMG],high, if the first attempt was > > + * for high memory, fall back to low memory. > > + */ > > + if (high && crash_max == CRASH_ADDR_HIGH_MAX) { > > Adding unlikely to indicate that it is rare would be better. > > if (unlikely(high && crash_max == CRASH_ADDR_HIGH_MAX)) > > > + crash_max = CRASH_ADDR_LOW_MAX; > > + search_base = 0; > > + goto retry; > > + } > > pr_warn("cannot allocate crashkernel (size:0x%llx)\n", > > crash_size); > > return; > > } > > > > - if ((crash_base > CRASH_ADDR_LOW_MAX - crash_low_size) && > > - crash_low_size && reserve_crashkernel_low(crash_low_size)) { > > + if ((crash_base >= CRASH_ADDR_LOW_MAX) && crash_low_size && > > + reserve_crashkernel_low(crash_low_size)) { > > memblock_phys_free(crash_base, crash_size); > > return; > > } > > > > -- > Regards, > Zhen Lei > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel