From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9A27C64EC4 for ; Mon, 6 Mar 2023 22:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bJNATkMNznfDoabnaX+5dCDdvBfes76YQ8qWGSKTQr4=; b=1c+7652dmPnGG6 bSTt7IfU/vzO5/tO48QRh4m2x64aKxfM2FBy+wld0mWO5R8HrZ5iXPFtfwtKBUM0oIVC2KyrZacJl /9+EJmzcL/Kib4rhHm1/0zRE2JcNHq9y+L1EFLsT7JCueca5GH2qJFbyA/L89yBkE+TfP7DvSwgMw NrDem3ZnaSHaZEmmmqMM7bAjHbE4LDH5A2lWTvGwy3w76NYfYHQ3ptyUdCyT47kOWCPWhFGHF3FBe DbypzkOCUrZ9BLITd6+cqaFP9MldJ2oUt76FwsSZbzbXp84Uqfastjj/d18aYeBwaDjC3yolko3qT l/LJigpANsD//cLRGQHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZJiw-00FLry-UZ; Mon, 06 Mar 2023 22:54:31 +0000 Received: from fgw20-7.mail.saunalahti.fi ([62.142.5.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZJis-00FLr0-Ja for linux-arm-kernel@lists.infradead.org; Mon, 06 Mar 2023 22:54:27 +0000 Received: from localhost (88-113-24-128.elisa-laajakaista.fi [88.113.24.128]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id d687a016-bc71-11ed-b3cf-005056bd6ce9; Tue, 07 Mar 2023 00:54:24 +0200 (EET) From: andy.shevchenko@gmail.com Date: Tue, 7 Mar 2023 00:54:23 +0200 To: Lizhe Cc: linus.walleij@linaro.org, brgl@bgdev.pl, geert+renesas@glider.be, info@metux.net, shc_work@mail.ru, j-keerthy@ti.com, hoan@os.amperecomputing.com, fancer.lancer@gmail.com, orsonzhai@gmail.com, baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com, kaloz@openwrt.org, khalasa@piap.pl, keguang.zhang@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org Subject: Re: [PATCH v1] drivers/gpio: remove redundant platform_set_drvdata() Message-ID: References: <20230306151532.23246-1-sensor1010@163.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230306151532.23246-1-sensor1010@163.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230306_145426_874278_D4475EAE X-CRM114-Status: UNSURE ( 6.50 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Mon, Mar 06, 2023 at 11:15:32PM +0800, Lizhe kirjoitti: > remove redundant platform_set_drvdata(), > Because there is no place to use the platform_get_drvdata The commit message has to be improved: - English grammar and punctuation - style of func() - clearer wording on what it all means Note, to get driver data the dev_get_drvdata() can be used. Do you aware about this? And hHow did you check these drivers? -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel