* Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
2023-03-06 22:47 [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files Andrew Davis
@ 2023-03-07 2:36 ` Masahiro Yamada
2023-03-07 7:59 ` Geert Uytterhoeven
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Masahiro Yamada @ 2023-03-07 2:36 UTC (permalink / raw)
To: Andrew Davis
Cc: Sascha Hauer, Rob Herring, Krzysztof Kozlowski, Nishanth Menon,
Vignesh Raghavendra, Michal Marek, Geert Uytterhoeven,
Frank Rowand, Andy Shevchenko, Nathan Chancellor,
Nick Desaulniers, Nicolas Schier, devicetree, linux-kbuild,
linux-arm-kernel, linux-kernel
On Tue, Mar 7, 2023 at 7:48 AM Andrew Davis <afd@ti.com> wrote:
>
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
> name from accidental being added.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
Acked-by: Masahiro Yamada <masahiroy@kernel.org>
if Rob picks this up.
> ---
> scripts/Makefile.lib | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 100a386fcd71..68d0134bdbf9 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -418,9 +418,6 @@ endif
> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
> $(call if_changed_dep,dtb)
>
> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> - $(call if_changed_dep,dtc)
> -
> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
> $(call if_changed_dep,dtc)
>
> --
> 2.39.2
>
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
2023-03-06 22:47 [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files Andrew Davis
2023-03-07 2:36 ` Masahiro Yamada
@ 2023-03-07 7:59 ` Geert Uytterhoeven
2023-03-07 11:55 ` Andy Shevchenko
2023-03-08 16:56 ` Nicolas Schier
3 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2023-03-07 7:59 UTC (permalink / raw)
To: Andrew Davis
Cc: Sascha Hauer, Rob Herring, Krzysztof Kozlowski, Nishanth Menon,
Vignesh Raghavendra, Michal Marek, Frank Rowand, Andy Shevchenko,
Masahiro Yamada, Nathan Chancellor, Nick Desaulniers,
Nicolas Schier, devicetree, linux-kbuild, linux-arm-kernel,
linux-kernel
On Mon, Mar 6, 2023 at 11:48 PM Andrew Davis <afd@ti.com> wrote:
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
> name from accidental being added.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
2023-03-06 22:47 [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files Andrew Davis
2023-03-07 2:36 ` Masahiro Yamada
2023-03-07 7:59 ` Geert Uytterhoeven
@ 2023-03-07 11:55 ` Andy Shevchenko
2023-03-08 16:56 ` Nicolas Schier
3 siblings, 0 replies; 8+ messages in thread
From: Andy Shevchenko @ 2023-03-07 11:55 UTC (permalink / raw)
To: Andrew Davis
Cc: Sascha Hauer, Rob Herring, Krzysztof Kozlowski, Nishanth Menon,
Vignesh Raghavendra, Michal Marek, Geert Uytterhoeven,
Frank Rowand, Masahiro Yamada, Nathan Chancellor,
Nick Desaulniers, Nicolas Schier, devicetree, linux-kbuild,
linux-arm-kernel, linux-kernel
On Mon, Mar 06, 2023 at 04:47:52PM -0600, Andrew Davis wrote:
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
> name from accidental being added.
Since in the past I had a problem with unnecessary rebuilding, this removes
the rule, so should not bring a similar regression.
Acked-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Thank you.
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> scripts/Makefile.lib | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 100a386fcd71..68d0134bdbf9 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -418,9 +418,6 @@ endif
> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
> $(call if_changed_dep,dtb)
>
> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> - $(call if_changed_dep,dtc)
> -
> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
> $(call if_changed_dep,dtc)
>
> --
> 2.39.2
>
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
2023-03-06 22:47 [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files Andrew Davis
` (2 preceding siblings ...)
2023-03-07 11:55 ` Andy Shevchenko
@ 2023-03-08 16:56 ` Nicolas Schier
2023-03-08 17:01 ` Andrew Davis
3 siblings, 1 reply; 8+ messages in thread
From: Nicolas Schier @ 2023-03-08 16:56 UTC (permalink / raw)
To: Andrew Davis
Cc: Sascha Hauer, Rob Herring, Krzysztof Kozlowski, Nishanth Menon,
Vignesh Raghavendra, Michal Marek, Geert Uytterhoeven,
Frank Rowand, Andy Shevchenko, Masahiro Yamada, Nathan Chancellor,
Nick Desaulniers, devicetree, linux-kbuild, linux-arm-kernel,
linux-kernel
On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote:
> As a follow up to the series allowing DTB overlays to built from .dtso
> files. Now that all overlays have been renamed, remove the ability to
> build from overlays from .dts files to prevent any files with the old
^^^^
The first "from" sounds superfluous to me.
Kind regards,
Nicolas
> name from accidental being added.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> scripts/Makefile.lib | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 100a386fcd71..68d0134bdbf9 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -418,9 +418,6 @@ endif
> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
> $(call if_changed_dep,dtb)
>
> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> - $(call if_changed_dep,dtc)
> -
> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
> $(call if_changed_dep,dtc)
>
> --
> 2.39.2
--
epost|xmpp: nicolas@fjasle.eu irc://oftc.net/nsc
↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f
-- frykten for herren er opphav til kunnskap --
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
2023-03-08 16:56 ` Nicolas Schier
@ 2023-03-08 17:01 ` Andrew Davis
2023-05-15 16:48 ` Andrew Davis
0 siblings, 1 reply; 8+ messages in thread
From: Andrew Davis @ 2023-03-08 17:01 UTC (permalink / raw)
To: Nicolas Schier
Cc: Sascha Hauer, Rob Herring, Krzysztof Kozlowski, Nishanth Menon,
Vignesh Raghavendra, Michal Marek, Geert Uytterhoeven,
Frank Rowand, Andy Shevchenko, Masahiro Yamada, Nathan Chancellor,
Nick Desaulniers, devicetree, linux-kbuild, linux-arm-kernel,
linux-kernel
On 3/8/23 10:56 AM, Nicolas Schier wrote:
> On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote:
>> As a follow up to the series allowing DTB overlays to built from .dtso
>> files. Now that all overlays have been renamed, remove the ability to
>> build from overlays from .dts files to prevent any files with the old
> ^^^^
>
> The first "from" sounds superfluous to me.
>
It is a typo, feel free to drop it locally whoever takes this patch.
Thanks,
Andrew
> Kind regards,
> Nicolas
>> name from accidental being added.
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> ---
>> scripts/Makefile.lib | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 100a386fcd71..68d0134bdbf9 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -418,9 +418,6 @@ endif
>> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
>> $(call if_changed_dep,dtb)
>>
>> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
>> - $(call if_changed_dep,dtc)
>> -
>> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
>> $(call if_changed_dep,dtc)
>>
>> --
>> 2.39.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
2023-03-08 17:01 ` Andrew Davis
@ 2023-05-15 16:48 ` Andrew Davis
2023-05-22 1:36 ` Masahiro Yamada
0 siblings, 1 reply; 8+ messages in thread
From: Andrew Davis @ 2023-05-15 16:48 UTC (permalink / raw)
To: Nicolas Schier
Cc: Sascha Hauer, Rob Herring, Krzysztof Kozlowski, Nishanth Menon,
Vignesh Raghavendra, Michal Marek, Geert Uytterhoeven,
Frank Rowand, Andy Shevchenko, Masahiro Yamada, Nathan Chancellor,
Nick Desaulniers, devicetree, linux-kbuild, linux-arm-kernel,
linux-kernel
On 3/8/23 9:01 AM, Andrew Davis wrote:
> On 3/8/23 10:56 AM, Nicolas Schier wrote:
>> On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote:
>>> As a follow up to the series allowing DTB overlays to built from .dtso
>>> files. Now that all overlays have been renamed, remove the ability to
>>> build from overlays from .dts files to prevent any files with the old
>> ^^^^
>>
>> The first "from" sounds superfluous to me.
>>
>
> It is a typo, feel free to drop it locally whoever takes this patch.
>
Seems no one took this last cycle.. Still valid and applies for this one.
Andrew
> Thanks,
> Andrew
>
>> Kind regards,
>> Nicolas
>>> name from accidental being added.
>>>
>>> Signed-off-by: Andrew Davis <afd@ti.com>
>>> ---
>>> scripts/Makefile.lib | 3 ---
>>> 1 file changed, 3 deletions(-)
>>>
>>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>>> index 100a386fcd71..68d0134bdbf9 100644
>>> --- a/scripts/Makefile.lib
>>> +++ b/scripts/Makefile.lib
>>> @@ -418,9 +418,6 @@ endif
>>> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
>>> $(call if_changed_dep,dtb)
>>> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
>>> - $(call if_changed_dep,dtc)
>>> -
>>> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
>>> $(call if_changed_dep,dtc)
>>> --
>>> 2.39.2
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kbuild: Disallow DTB overlays to built from .dts named source files
2023-05-15 16:48 ` Andrew Davis
@ 2023-05-22 1:36 ` Masahiro Yamada
0 siblings, 0 replies; 8+ messages in thread
From: Masahiro Yamada @ 2023-05-22 1:36 UTC (permalink / raw)
To: Andrew Davis
Cc: Nicolas Schier, Sascha Hauer, Rob Herring, Krzysztof Kozlowski,
Nishanth Menon, Vignesh Raghavendra, Michal Marek,
Geert Uytterhoeven, Frank Rowand, Andy Shevchenko,
Nathan Chancellor, Nick Desaulniers, devicetree, linux-kbuild,
linux-arm-kernel, linux-kernel
On Tue, May 16, 2023 at 1:49 AM Andrew Davis <afd@ti.com> wrote:
>
> On 3/8/23 9:01 AM, Andrew Davis wrote:
> > On 3/8/23 10:56 AM, Nicolas Schier wrote:
> >> On Mon, Mar 06, 2023 at 04:47:52PM -0600 Andrew Davis wrote:
> >>> As a follow up to the series allowing DTB overlays to built from .dtso
> >>> files. Now that all overlays have been renamed, remove the ability to
> >>> build from overlays from .dts files to prevent any files with the old
> >> ^^^^
> >>
> >> The first "from" sounds superfluous to me.
> >>
> >
> > It is a typo, feel free to drop it locally whoever takes this patch.
> >
>
> Seems no one took this last cycle.. Still valid and applies for this one.
Seems it fell into a crack.
Now applied to linux-kbuild. Thanks.
> Andrew
>
> > Thanks,
> > Andrew
> >
> >> Kind regards,
> >> Nicolas
> >>> name from accidental being added.
> >>>
> >>> Signed-off-by: Andrew Davis <afd@ti.com>
> >>> ---
> >>> scripts/Makefile.lib | 3 ---
> >>> 1 file changed, 3 deletions(-)
> >>>
> >>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> >>> index 100a386fcd71..68d0134bdbf9 100644
> >>> --- a/scripts/Makefile.lib
> >>> +++ b/scripts/Makefile.lib
> >>> @@ -418,9 +418,6 @@ endif
> >>> $(obj)/%.dtb: $(src)/%.dts $(DTC) $(DT_TMP_SCHEMA) FORCE
> >>> $(call if_changed_dep,dtb)
> >>> -$(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE
> >>> - $(call if_changed_dep,dtc)
> >>> -
> >>> $(obj)/%.dtbo: $(src)/%.dtso $(DTC) FORCE
> >>> $(call if_changed_dep,dtc)
> >>> --
> >>> 2.39.2
> >>
--
Best Regards
Masahiro Yamada
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread