From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1799C64EC4 for ; Wed, 8 Mar 2023 15:25:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r8ny43+L52QdbNV4/wkeXI/73w6i5bcUjfk7qxRk6cU=; b=k2os5Dc4BUUmN9 e2d9E7Hid4Q3R/qXOmV7ieDGSK4fimQJmp4NzWd4KJkFSgKpPJ9OwXNLe7ifiqhJawp8EsaMyj3Ye XDXSjgsaw+oW8/b3H6wNOAV/jo0AFnuZv53I6KWshhPuSyeV94YpiJjp5BGK3YKGfHj9qhrWKONN7 RHUx5cIPmzqzr9YG1UnmPdO0L3T4YbMpD1mDz8FInorjDpfK6ogJ6nnncWFYVci1pqyX9/x9dczU3 fOkLT/nYO5h7ZtpboZK29IORAA4BUo9lOG8LUeHApei7kb4UaGP8xd1Bz7YRr/PAlIAdKUlMo7epO casmPteBLk4swr2DI+qA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZver-005h0i-Ej; Wed, 08 Mar 2023 15:24:49 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZven-005gzJ-Jg; Wed, 08 Mar 2023 15:24:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CQH39Di29dr/Gqo5tr4azRM7bV/jn6BroV0Z6GxcVTQ=; b=nt4eGNU1vpmMG5CMd/ToMMa/GR RqB54MsLk8c/5naFCaUuHwjQcuBI4PoZTksLoj+MlH9AnAbRCEUKeHR3BXKX3/3Eask+mj+NOjsk0 CDoaxiCdDHUJuJfQ0NEBnoSn9Gu19Do+TVwWbO/1nBaLD1e10I0YPIRL4oYkgBT9t8GZ8p4S3E1Op jU8I3YBVKWCyQ4e5To2juv1IZ46o+rKOnRyzu7rgawD0YHypPS8u/3/GDWPfwfdlpWECVJkLRrHFT eMK4SHu66d2q2ehrEqAS4j/AoNSzRv5GLIVjC9zscqbBubbsHZmDKEGVLHCcGZ3nNgt4lLGnK3Bgy Pxgvt0SQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41704) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pZved-0002qq-BO; Wed, 08 Mar 2023 15:24:35 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pZveU-0002h7-N4; Wed, 08 Mar 2023 15:24:26 +0000 Date: Wed, 8 Mar 2023 15:24:26 +0000 From: "Russell King (Oracle)" To: Daniel Golle Cc: Vladimir Oltean , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Andrew Lunn , Jianhui Zhao , =?iso-8859-1?Q?Bj=F8rn?= Mork , Frank Wunderlich , Alexander Couzens Subject: Re: [PATCH net-next v12 08/18] net: ethernet: mtk_eth_soc: fix 1000Base-X and 2500Base-X modes Message-ID: References: <20230308134642.cdxqw4lxtlgfsl4g@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230308_072445_663830_887C075A X-CRM114-Status: GOOD ( 17.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 08, 2023 at 03:08:55PM +0000, Daniel Golle wrote: > On Wed, Mar 08, 2023 at 03:01:07PM +0000, Russell King (Oracle) wrote: > > > FYI: > > > TP-LINK TL-SM410U 2500Base-T module: > > > > > > sfp EE: 00000000: 03 04 07 00 00 00 00 00 00 40 00 01 1f 00 00 00 .........@...... > > > sfp EE: 00000010: 00 00 00 00 54 50 2d 4c 49 4e 4b 20 20 20 20 20 ....TP-LINK > > > sfp EE: 00000020: 20 20 20 20 00 30 b5 c2 54 4c 2d 53 4d 34 31 30 .0..TL-SM410 > > > sfp EE: 00000030: 55 20 20 20 20 20 20 20 32 2e 30 20 00 00 00 1b U 2.0 .... > > > sfp EE: 00000040: 00 08 01 00 80 ff ff ff 40 3d f0 0d c0 ff ff ff ........@=...... > > > sfp EE: 00000050: c8 39 7a 08 c0 ff ff ff 50 3d f0 0d c0 ff ff ff .9z.....P=...... > > > sfp sfp2: module TP-LINK TL-SM410U rev 2.0 sn 12260M4001782 dc 220622 > > > > I'm guessing this is a module with a checksum problem... > > No, the checksum of the TL-SM410U is correct. I have patched the kernel > to always dump the EEPROM, so I can share it with you. Bear in mind that I haven't spent time with the spec to manually decode the above, when I have tools to do that for me when given the EEPROM in the correct form, which is: > > It would be nice to add these to my database - please send me the > > output of ethtool -m $iface raw on > foo.bin for each module. so if you can do that for me, then I can see whether it's likely that the patches that are already in mainline will do anything to solve the workaround you've had to add for the hw signals. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel