From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EA08C678D5 for ; Wed, 8 Mar 2023 15:44:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bY+ZQdUSLRJT3Oju9RrjtHv3Qv6BUy5MvxBb2CiRNPg=; b=ftXxW0C78zp4B9 lkayCLSW8Xney8b1ruHy56W1rZGnTe9pVQlrl0rvCVZt5i31NxfJ2pEKM8Rjr9fRLaiFBgo+nlBku 5MPYeFxbUG4nP1bJGHON+GMf68QBIS0wve+PAaWYbUYaUbx5+ztmzGuJFFtjSbyFSUN4KMdHvPpO+ NWjnsnMOGj4LLJ8aECr5ZyrF7UJ8e++/tnBAPQu/k0gNoB1U2tkMxA8HPEnXB2pZd3dsNjJqRN92D 4Kp0e85eq9umtjYpDero4AqEP7NQg2H16LkBviv74OrvFFSdV5TIeKyjbdlA/vgWmXWuvhfsLsWzJ 3mmijKzaE1mWUWy/U5sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZvwz-005kp8-7I; Wed, 08 Mar 2023 15:43:33 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZvwv-005koD-SU; Wed, 08 Mar 2023 15:43:31 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 29E436069B; Wed, 8 Mar 2023 15:43:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11B33C433EF; Wed, 8 Mar 2023 15:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678290208; bh=kYutHpejNtmmeokplIU5qESykQhQfmRXB0B3UcVHJ/A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pTEH+9+A2VlNt/UDNUfumfNn78n4Ayb3ttC8+3prI+UMqUH008tp6mbaFrNOs/srD L1ZAJ/t4+FGpDhT0uxetSddfLKNg2ESCG1ofsXlnnUoERbqSc72SIrgZx3pPPF7uuN oEoNQrrCXRczlB4Pj61yTWNqjNHnLvd/m9JjeT+w= Date: Wed, 8 Mar 2023 16:43:25 +0100 From: Greg Kroah-Hartman To: AngeloGioacchino Del Regno Cc: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, matthias.bgg@gmail.com, weiqing.kong@mediatek.com, jitao.shi@mediatek.com, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH 0/2] pwm: mtk-disp: Fix backlight configuration at boot Message-ID: References: <20230123160615.375969-1-angelogioacchino.delregno@collabora.com> <06918fde-64ea-37b2-da1a-1c8316457223@collabora.com> <06909bd8-3da2-1cf0-82ac-3ed4f3e63def@collabora.com> <28142704-d82d-d533-d2a8-b1061182f1f6@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <28142704-d82d-d533-d2a8-b1061182f1f6@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230308_074330_019785_5A696603 X-CRM114-Status: GOOD ( 29.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 08, 2023 at 03:55:59PM +0100, AngeloGioacchino Del Regno wrote: > Il 08/03/23 15:50, Greg Kroah-Hartman ha scritto: > > On Wed, Mar 08, 2023 at 12:46:07PM +0100, AngeloGioacchino Del Regno wr= ote: > > > Il 23/02/23 15:16, AngeloGioacchino Del Regno ha scritto: > > > > Il 23/01/23 17:06, AngeloGioacchino Del Regno ha scritto: > > > > > Since the pwm-mtk-disp driver was fixed to get PWM_EN state from = the > > > > > right register, an old two-wrongs-make-one-right issue emerged: a= s a > > > > > result, MT8192 Asurada Spherion got no backlight at boot unless a > > > > > suspend/resume cycle was performed. > > > > > Also, the backlight would sometimes not get updated with the requ= ested > > > > > value, requiring the user to change it back and forth until it wo= rked. > > > > > = > > > > > This series fixes both of the aforementioned issues found on MT81= 92. > > > > > = > > > > > AngeloGioacchino Del Regno (2): > > > > > =A0=A0 pwm: mtk-disp: Disable shadow registers before setting ba= cklight > > > > > =A0=A0=A0=A0 values > > > > > =A0=A0 pwm: mtk-disp: Configure double buffering before reading = in > > > > > =A0=A0=A0=A0 .get_state() > > > > > = > > > > > =A0 drivers/pwm/pwm-mtk-disp.c | 34 +++++++++++++++++++++++-----= ------ > > > > > =A0 1 file changed, 23 insertions(+), 11 deletions(-) > > > > > = > > > > = > > > > Gentle ping for this one: this is fixing backlight issues on multip= le MediaTek > > > > SoCs and was well tested. > > > > = > > > > Thanks, > > > > Angelo > > > = > > > Since this series was sent more than one month ago, and since this fi= xes broken > > > backlight on a number of Chromebooks with MT8183 and MT8192 SoCs, and= seen the > > > urgency of getting these fixes in, I'm adding Greg to the loop. > > = > > $ ./scripts/get_maintainer.pl drivers/pwm/pwm-mtk-disp.c > > Thierry Reding (maintainer:PWM SUBSYSTEM) > > "Uwe Kleine-K=F6nig" (reviewer:PWM SUB= SYSTEM) > > Matthias Brugger (maintainer:ARM/Mediatek SoC = support) > > AngeloGioacchino Del Regno (r= eviewer:ARM/Mediatek SoC support) > > linux-pwm@vger.kernel.org (open list:PWM SUBSYSTEM) > > linux-kernel@vger.kernel.org (open list:ARM/Mediatek SoC support) > > linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC s= upport) > > linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC sup= port) > > = > > I don't see my name in there, did I become the PWM maintainer somehow? > > = > > What's wrong with Thierry taking this like normal? > > = > = > Nothing wrong with that. I felt like this series got ignored as I've never > received any reply from Thierry, even though it's a Fixes series that I d= eem > to be moderately urgent; that's why I added you to the loop. Then ask Thierry and Uwe, what would you want to have happen if you were the maintainer of a subsystem? > If that created unnecessary noise, I'm extremely sorry and won't happen a= gain. Not noise, just confusion on my part. I'm glad to take patches that have no obvious maintainers, or maintainers that have disappeared, but that doesn't seem to be the case here. Also remember that we had the merge window, which is 2 weeks of us not being able to take any new code at all, even for fixes. And finally, to make it easier for your code to be accepted, please take the time to review other's code for the subsystems you care about to make the maintainer's load easier. If you do that, you will often find your patches getting faster response just by virtue of there being less work to do on the subsystem overall. Why not do that right now to help out with other PWM patches? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel