From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D71FAC61DA4 for ; Thu, 9 Mar 2023 12:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8RLEE4d/hTSLEbvNIWKc++W9SYAI9QFjFDJ3QqwrL2A=; b=iwZi9Hg0sRbekD Ay1W4bEDzrwTOyE4e55Mf4EnGHzJ44DI2JPIgv6kp6IrFpIAgzaGBsEXuD0Iqr8kSNPzv+ob6Qcnd 3LpY/ngQGu5AWsdgnifvvtl07QO6YxzlbF1P+B0CsBAl+JO9C4TojAIi2SEow0VbbkFYysjy5z9Gf EYto8kRHV+vt5THmYSIogHsKtktBADM6hL/feBnBRVDuJ96TmoXle4qBNQAuVtqzc2GIPPFjf0pQk VDw/ZM3fm7SzYxRudEUTtqDGYXp1Dq6pAGRyS1awQH1v+KngP+6Ge0oopeT4b8L9Gx4gaP6+UvTNB /WzfaFeahVLttb1ikcIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1paFF4-009qdY-Tb; Thu, 09 Mar 2023 12:19:31 +0000 Received: from mail11.truemail.it ([2001:4b7e:0:8::81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1paFF0-009qZr-Sm for linux-arm-kernel@lists.infradead.org; Thu, 09 Mar 2023 12:19:29 +0000 Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id D79241F843; Thu, 9 Mar 2023 13:19:17 +0100 (CET) Date: Thu, 9 Mar 2023 13:19:13 +0100 From: Francesco Dolcini To: Krzysztof Kozlowski , Shawn Guo Cc: Philippe Schenker , devicetree@vger.kernel.org, Sascha Hauer , NXP Linux Team , Krzysztof Kozlowski , Rob Herring , Pengutronix Kernel Team , Frank Rowand , linux-arm-kernel@lists.infradead.org, Fabio Estevam , Philippe Schenker , linux-kernel@vger.kernel.org, Marcel Ziswiler Subject: Re: [PATCH v1 03/25] arm64: dts: colibri-imx8x: Sort properties Message-ID: References: <20230308125300.58244-1-dev@pschenker.ch> <20230308125300.58244-4-dev@pschenker.ch> <9d213504-d457-21a6-d467-41d8783d53d3@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9d213504-d457-21a6-d467-41d8783d53d3@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230309_041927_140144_3647D902 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Krzysztof, first thanks for your review. Let's try to get some clarity on this with the help of Shawn. On Wed, Mar 08, 2023 at 01:57:38PM +0100, Krzysztof Kozlowski wrote: > On 08/03/2023 13:52, Philippe Schenker wrote: > > From: Philippe Schenker > > > > Sort properties according to the following order and inside these > > alphabetically. > > > > 1. compatible > > 2. reg > > 3. standard properties > > 4. specific properties > > 5. status > > Is this approved coding style for IMX DTS? I 100% understand your concerns here. With that said let me try to briefly explain the reasoning here, in various threads we were asked in the past to move node around based on some not 100% defined rules [0][1]. On Sun, 2023-01-29 at 11:19 +0800, Shawn Guo wrote: >> +&usbotg1 { >> + adp-disable; >> + ci-disable-lpm; >> + hnp-disable; >> + over-current-active-low; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_usbotg1>; > >We generally want to put such generic properties before device specific >ones. In addition to that we find convenient to have properties sorted alphabetically when no other rule is available, it just prevents any kind of discussion, minimize merge conflicts and make comparing files easier. I also agree that the difference between "generic"/"specific" is fuzzy at best. With all that said ... Shawn: What should we do? We can of course avoid any kind of re-ordering from now on. I am fine to be very pragmatic here, no-reordering on existing DTS files, newly added DTS files we discuss whatever is the reasoning of the reviewer/maintainer on a case-by-case basis. Francesco [0] https://lore.kernel.org/all/895e7df5-65e5-7b26-81d6-864e68957ab6@linaro.org/ [1] https://lore.kernel.org/all/20230129031932.GO20713@T480/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel