From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5138C61DA4 for ; Thu, 9 Mar 2023 13:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GPDx4yoNB6M83tjOwRVXv6n+0tG3moqzchR3d7b2zY8=; b=T5bPmJrFavLv7F fV+SQYYPav9u2mrHCry67cdHGF149yujRX3vXE+megeg6Pw+ErAAL9g8G607IAE1HBYblzXQyQXoS tY5jbj4xkli0Mp9oJeZcQTKiWU4YQEo3AXKS3xYIVOLB+37Vvks1dS5G+xeKyVIV4Xz3c0t5xlmvF q7OZqtZIfh/XWzzT02BAKYrwLh94MfsAlaoLoIhiNVlSasQgGMSrbgaNzpLFGhm9npBEGSx83Ns44 MH3LbUqvxI2oB8N5LkDC+3C43tBjAkZwzZunmoj2MIrftBWb8fxKlnrcNeKrMzsTIn/haK8QimVsk Chqx99cZTzymICA6mltg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1paG02-00A0j5-7V; Thu, 09 Mar 2023 13:08:02 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1paFzy-00A0hP-UU for linux-arm-kernel@lists.infradead.org; Thu, 09 Mar 2023 13:08:00 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 60A9AB81EE8; Thu, 9 Mar 2023 13:07:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 946C5C4339B; Thu, 9 Mar 2023 13:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678367276; bh=OkIirOLzi4noUGuDrFd3QCCm818DgLRyVk2I/IlEGhQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s/ndqFodvUQCwUqKRxSkbEyGEIKCjnv25Whg8kctG5EDX/jW38cY18B0TcYyHuby8 JSMK7w7Asw8Y2lBm/fn8/UDZzSA7hDzpW3uAKOFvL/eLtfj5zSiJAMMG62eXk6FLH2 X7k4lCc3QB1RdXJMWAJxIDk9nPqWQOMtwGY9K19A= Date: Thu, 9 Mar 2023 14:07:53 +0100 From: Greg KH To: Nipun Gupta Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, rafael@kernel.org, eric.auger@redhat.com, alex.williamson@redhat.com, cohuck@redhat.com, song.bao.hua@hisilicon.com, mchehab+huawei@kernel.org, maz@kernel.org, f.fainelli@gmail.com, jeffrey.l.hugo@gmail.com, saravanak@google.com, Michael.Srba@seznam.cz, mani@kernel.org, yishaih@nvidia.com, jgg@ziepe.ca, jgg@nvidia.com, robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, masahiroy@kernel.org, ndesaulniers@google.com, rdunlap@infradead.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, okaya@kernel.org, harpreet.anand@amd.com, nikhil.agarwal@amd.com, michal.simek@amd.com, pieter.jansen-van-vuuren@amd.com, pablo.cascon@amd.com, git@amd.com Subject: Re: [PATCH v9 1/7] cdx: add the cdx bus driver Message-ID: References: <20230307131917.30605-1-nipun.gupta@amd.com> <20230307131917.30605-2-nipun.gupta@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230307131917.30605-2-nipun.gupta@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230309_050759_280288_4C57CBAA X-CRM114-Status: GOOD ( 21.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 07, 2023 at 06:49:11PM +0530, Nipun Gupta wrote: > Introduce AMD CDX bus, which provides a mechanism for scanning > and probing CDX devices. These devices are memory mapped on > system bus for Application Processors(APUs). > > CDX devices can be changed dynamically in the Fabric and CDX > bus interacts with CDX controller to rescan the bus and > rediscover the devices. > > Signed-off-by: Nipun Gupta > Reviewed-by: Pieter Jansen van Vuuren > Tested-by: Nikhil Agarwal > --- > Documentation/ABI/testing/sysfs-bus-cdx | 12 + > MAINTAINERS | 7 + > drivers/Kconfig | 2 + > drivers/Makefile | 1 + > drivers/cdx/Kconfig | 17 + > drivers/cdx/Makefile | 8 + > drivers/cdx/cdx.c | 407 ++++++++++++++++++++++++ > drivers/cdx/cdx.h | 62 ++++ > include/linux/cdx/cdx_bus.h | 147 +++++++++ > include/linux/mod_devicetable.h | 15 + > scripts/mod/devicetable-offsets.c | 4 + > scripts/mod/file2alias.c | 12 + > 12 files changed, 694 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-bus-cdx > create mode 100644 drivers/cdx/Kconfig > create mode 100644 drivers/cdx/Makefile > create mode 100644 drivers/cdx/cdx.c > create mode 100644 drivers/cdx/cdx.h > create mode 100644 include/linux/cdx/cdx_bus.h > > diff --git a/Documentation/ABI/testing/sysfs-bus-cdx b/Documentation/ABI/testing/sysfs-bus-cdx > new file mode 100644 > index 000000000000..063d1a0dd866 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-bus-cdx > @@ -0,0 +1,12 @@ > +What: /sys/bus/cdx/rescan > +Date: March 2023 > +Contact: nipun.gupta@amd.com > +Description: > + Writing a non-zero value to this file cause rescan of the bus > + and devices on the CDX bus. Any new devices are scanned and > + added to the list of Linux devices and any devices removed are > + also deleted from Linux. > + > + For example:: > + > + # echo 1 > /sys/bus/cdx/rescan See my comments on patch 7/7 about "non-zero" not being a good idea. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel