From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFC8EC61DA4 for ; Thu, 9 Mar 2023 16:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RdqTXg3xQZDH/ShIFr2KThcTGXycDEnhlM3FUYAg10Y=; b=Uwz5TzxMnxwcoE 2CUYXlmenFCCENuJoG2iWiVBv3wJQrBmBZ3dJVnZaXzuAG0A4EsC4fNHhare2M8TxszkjUlGKJnY/ +Fnofp0QWy0ufpoV2BkvDhe/1GoO7E/KSTVaA9316nLstZOoOHdZwv1B4uC7TuFSPh8DuegZ2t9RG FeOZd8S92URXFPoPN4V+2+JEqA4YnLum23ZPRVR6FO+HeqqyZO8GbeqdNrIVvnh2MFdR/XWcu36P9 xzby+wviPm5VBi6A4AZTtQCg3bTrQV6+f+FMHzcIjzHZfxCcu+0DhJipPyPdSio/G/pi6S2jaSsUO NVxgiVCAzmG69FTrIfbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1paIxf-00BEUi-Jy; Thu, 09 Mar 2023 16:17:47 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1paIxd-00BETd-0A; Thu, 09 Mar 2023 16:17:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8E96461C30; Thu, 9 Mar 2023 16:17:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B060C433EF; Thu, 9 Mar 2023 16:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1678378664; bh=q9RjBZs+ERaxIV0omkTJ1hSNgg0RjEI7/KoY1XKuSyU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jVhVYbvVqbdH2W69+wx8yTauEYWo0avO97NQe507F8tsK4F2Hte8WTtGIKAVkVf23 dis1Kce8ox34FbnT/tTE/5/8ozmdX88XWnaNdteMxf4stuKuUWqaYHxQfm6E3eWspg anntKbMr0SzOEEfAU8A2wj3O+z2O90FDKm1SELV8= Date: Thu, 9 Mar 2023 17:17:41 +0100 From: Greg Kroah-Hartman To: Nick Alcock Cc: mcgrof@kernel.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Hitomi Hasegawa , Manivannan Sadhasivam , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-unisoc@lists.infradead.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 21/24] kbuild, serial: remove MODULE_LICENSE in non-modules Message-ID: References: <20230217141059.392471-1-nick.alcock@oracle.com> <20230217141059.392471-22-nick.alcock@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230217141059.392471-22-nick.alcock@oracle.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230309_081745_102349_D0637741 X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 17, 2023 at 02:10:56PM +0000, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock > Suggested-by: Luis Chamberlain > Cc: Luis Chamberlain > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa > Cc: Manivannan Sadhasivam > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-unisoc@lists.infradead.org > Cc: linux-serial@vger.kernel.org > --- > drivers/tty/serial/rda-uart.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/rda-uart.c b/drivers/tty/serial/rda-uart.c > index be5c842b5ba9..c3b29d124759 100644 > --- a/drivers/tty/serial/rda-uart.c > +++ b/drivers/tty/serial/rda-uart.c > @@ -825,4 +825,3 @@ module_exit(rda_uart_exit); > > MODULE_AUTHOR("Manivannan Sadhasivam "); > MODULE_DESCRIPTION("RDA8810PL serial device driver"); > -MODULE_LICENSE("GPL"); No, this should be fine, either force remove all MODULE_* macros from built-in code, or none. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel