From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5169C6FA99 for ; Fri, 10 Mar 2023 18:30:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K2KYY7frTRnJMI15vSTLrPCLpwK5G2cnxX3JKgg9+gw=; b=u/xZTpo8cxFyaH CTp9nBu84fX9t7J9o5ZEdCcMCHISTnvhCbWzku8Pxez7WKnk40FANGSoDtR4bjWDi6v4zOh5bbqaG JsvT0+rB4qarCD/qa2TuhU1riYc5DXFuGRR/4prnk92HfN0zU50cqBBS3HEFXM6c1gvUW9fWqnLkt m6tVk0jg2wLUBG4XAfHlGU9H97FPTYqeCZyuCIkCT6dEg3t1tPRg4W7a99XefCggRaKZWjLb1DkFk vOsXFpdmONrYhREDrUe/zWdU+y90tSe/B8XWBz/EzqF95+bHuDV8stMtO8QlqBDerzD5JsPjSk2Hy shdiWQNRa4EUPf5k/1hA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pahUj-00Fl1W-Jq; Fri, 10 Mar 2023 18:29:33 +0000 Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pahUi-00Fl1I-0F; Fri, 10 Mar 2023 18:29:32 +0000 Date: Fri, 10 Mar 2023 10:29:31 -0800 From: Luis Chamberlain To: Arnd Bergmann Cc: Vincenzo Palazzo , Jason Baron , Arnd Bergmann , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dyndbg: allow including dyndbg.h in decompressor Message-ID: References: <20230310140133.291594-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230310140133.291594-1-arnd@kernel.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 10, 2023 at 03:01:26PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > After a change to linux/module.h, dyndbg.h is now included > indirectly from the decompressor for lz4 support, which in turn > causes a build failure on 32-bit Arm: > > In file included from include/linux/module.h:30, > from arch/arm/boot/compressed/../../../../lib/lz4/lz4_decompress.c:39, > from arch/arm/boot/compressed/../../../../lib/decompress_unlz4.c:10, > from arch/arm/boot/compressed/decompress.c:59: > include/linux/dynamic_debug.h: In function 'ddebug_dyndbg_module_param_cb': > include/linux/dynamic_debug.h:307:14: error: implicit declaration of function 'strcmp' [-Werror=implicit-function-declaration] > 307 | if (!strcmp(param, "dyndbg")) { > | ^~~~~~ > include/linux/dynamic_debug.h:1:1: note: 'strcmp' is defined in header ''; did you forget to '#include '? > +++ |+#include > > The decompressor has its own replacement for the linux/string.h contents, > so the normal declaration is not visible here. Since the function is > not actually called, it is sufficient to add a declaration, and this > is in fact the correct one as it matches the definition in > arch/arm/boot/compressed/string.c. > > Fixes: 7deabd674988 ("dyndbg: use the module notifier callbacks") > Signed-off-by: Arnd Bergmann > --- > The patch that caused the problem is in linux-next, maybe fold > the fix into that patch if possible > --- Thanks for figuring this out, Arnd! Pushed to modules-next! Luis _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel