From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED350C6FD1F for ; Sat, 11 Mar 2023 00:25:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ujgzV3LhfKgBIlCu629PhTonkf6/F/asAsWxW0b95io=; b=E9N7WbgHrWdMXV b3uglL1J3zuhkR7k5PFHWCLpWbVFD8XyX5Atq2u8oJ/jJPZhwsETSDmNGMSCMwKXTpEmbO6YhQAQX lZGkUiYq8+XreXrkozpQ5L2Gd3oi8ger+/7pew2o8QOtV9l+oS5VIWng69PFS0kdC/q4hhan/SvQX gH3mKURTH6LexwKQAkbVMmEghf4R5yyvUhXZulL25a1p/9wEbpMrNmQdTZIg71xWzvD+Gk+7CJxyo +JCYMfxYIE0bPTZ2jKMp5BLispDtPVgr9UOEw3KO3ZAgvcMDYwDX5q7fBfVwRZw+SbCs77y574Bfd rINSGsT/KxeQSedFFlKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pan2E-00GoJE-62; Sat, 11 Mar 2023 00:24:30 +0000 Received: from mail-bn7nam10on20622.outbound.protection.outlook.com ([2a01:111:f400:7e8a::622] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pan2A-00GoHj-Si for linux-arm-kernel@lists.infradead.org; Sat, 11 Mar 2023 00:24:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=haJrIw2q9GZq6CPXPRSMQmL+qjmo9jKQHZ1wXw7/YtPyb1b10d42cRwh/1ZBTymmljuI6+TiazRMVbypHVOryx5ZAeeyFgOo4bEXZZgioSbssrDHffNdOSsF1JISVurxDt/6G8YJ4x22n1iG0Cwrncp0HgN7MgQSodzHQRZW6k+MbdKJcCjFg/4EOxbWXWsHNgwFo5mkAFYfD1kHhR6A/yRGAdgrjtOnzzZ81FA6o0Y1BCKTWogKfRZEc/bDXTLrsy99kaxdkIkMW8T618oDLTL8NUauuPsLPYiUYFYSjmswyrbOJxc+8rnmpA5gol7PyXBhUFqSgfHc3X5eKUSY5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lUFFFAuR1QTyqIhB3kNEYP/nCU/qllnv2yLIACLXRi0=; b=FpRfTWwD6mv2G7gisEKzJbd2KT9yXFweqwS3siRIIA3/QCPwg3AIQPZMKpptX5JnwQPZAXkEvkfB0Ecs+sTf7D+eZEMxEmzk5YTPatCJGBwBjXbD5e/MOco53xgXtURewwFjvRkKoA82gI/S2ukpRFbh5JQFhHye1rVl4JyjNVeh8su1oUdFVHY/mm71JXMWPuvsBk7fyV+3wBqnJWvMLyvU7OhUCcCoMynD5KMH8JXub8bq6aGYys6nZA03KIFEUVMmIbz2bYXU9uSsx9V0+b/nRWiVVuRyL9//lVNSEivtw3ixaZRxSfPkb1AZa9UuvBwf7h2oh0y2qsCXFgk5oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lUFFFAuR1QTyqIhB3kNEYP/nCU/qllnv2yLIACLXRi0=; b=uEW0cpNLvwyYKkfQ+nyPXfJ4jjsktVWc0S5jf2ZJyNlgUO74DuL9EGMSEBlCY1hAibo/lNltA7RWE+FEv2aej6eviqaiu/XVqIAKJkVYgrSAuORaPb9huPHsl76V2EoATmU7EVpMYAVJ5sbUU65cXufMP514Q3ltOmf+oSexb7Ikqja9xkNGugXjE+C4io+9wxPXnjYYfwbymD6XZ+mTrQmp1EV3hCSgnW4hiXsJvx8LevPD+j3FJrR6k7FR5mO9mRHrSIkGEu4i9yJm2qqi0e5SiO1y1rcMq7kzxB93dpElsNOs9J99Z/rRisSondwGk+GAh9Cr4mzw5nxgL48kOA== Received: from MW4PR04CA0330.namprd04.prod.outlook.com (2603:10b6:303:82::35) by SN7PR12MB7855.namprd12.prod.outlook.com (2603:10b6:806:343::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.22; Sat, 11 Mar 2023 00:24:23 +0000 Received: from CO1NAM11FT085.eop-nam11.prod.protection.outlook.com (2603:10b6:303:82:cafe::c4) by MW4PR04CA0330.outlook.office365.com (2603:10b6:303:82::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19 via Frontend Transport; Sat, 11 Mar 2023 00:24:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CO1NAM11FT085.mail.protection.outlook.com (10.13.174.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.20 via Frontend Transport; Sat, 11 Mar 2023 00:24:23 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Fri, 10 Mar 2023 16:24:22 -0800 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Fri, 10 Mar 2023 16:24:22 -0800 Received: from Asurada-Nvidia (10.127.8.9) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Fri, 10 Mar 2023 16:24:21 -0800 Date: Fri, 10 Mar 2023 16:24:20 -0800 From: Nicolin Chen To: Jason Gunthorpe CC: Eric Auger , , , , , , , , , , Subject: Re: [PATCH v1 05/14] iommu/arm-smmu-v3: Remove ARM_SMMU_DOMAIN_NESTED Message-ID: References: <1c18d68c-a20d-0f6d-4bf7-56f40557d151@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT085:EE_|SN7PR12MB7855:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c26e3b7-1ab0-4acf-7b05-08db21c6f6da X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: McEWbIXm6fjJ1D5odT17d1XCbCysL/1q1j94SU1u1j8svsllmOseQkmce4Iuk48yDeZ3M/AjHNxqxjLTG7GTfZg2UDzAgW9aMrYKH1fn1p+wlKPQmMJ3Ma6FTkL7Q7Yv/D02r959GBHJt0I4km9tQkaCO0pFroVFkFexPtGqx3hSMUGJz2wg0vdh+ZsS1m5veJexOSU268ZlSe8o+dzd1T9/+yCSL5htwuBZKSKVDPVymsGo9AaQ9dD2+HzQ4r0wTy9fKoB1CugCnO8cKDHiBTPhGF6DEFCnl1m+iN/OvHGWncVdAT6btZaqsGtMUUduQNfXllpQ3Os+hx+mz3JdVv3umkeGrIgMTNpNLd5QYwge3qHQhWTu0QJ5VLI7uggjo7AQhdz2DIAJni36Nmi4gSR+QJ4q1VV/bB5HEqVxGdJDHE5+xT3ZuvW2T93fa+H+FBu9wlQT/MgSyuxN/42Hav7iHNGfxS8zuN45HhY2XX8Ed561pthkngAYU6xgkpWs9NwOYsbTbC0JZWz+6IBD5DM9Yp0hKp6wDUl02eCVfG+lnoioPItc0JS45fXjh3q0IhCrXyK8vGa9XEpf31qOgTxUQPUpdF/nXmwzH+TYhzw1FyiuQt24o6NYDVkpU5ZTNhnfGpSlmjxEylLsSnFpruhoN4R8UmDG9Jl4bPlEVMbg60oO5ad7GzfkR+C4OxqCPIY/Vkq2FoV2RzkfqoUaOTcwPNTbdLTYw0ybLgtxbsat8jpnfJR/LnprXctLdzAtTQC0sfUader4cTHVG+JQzfNp14jfiiJmyEmk3C+E5WA= X-Forefront-Antispam-Report: CIP:216.228.118.233;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge2.nvidia.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(39860400002)(376002)(136003)(396003)(451199018)(36840700001)(46966006)(40470700004)(70586007)(70206006)(8676002)(4326008)(36860700001)(82740400003)(426003)(47076005)(82310400005)(336012)(41300700001)(7636003)(33716001)(316002)(966005)(6862004)(186003)(26005)(6636002)(54906003)(9686003)(356005)(40460700003)(4744005)(7416002)(478600001)(8936002)(40480700001)(55016003)(5660300002)(2906002)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2023 00:24:23.0874 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c26e3b7-1ab0-4acf-7b05-08db21c6f6da X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.233];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT085.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7855 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230310_162426_951605_70283004 X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 10, 2023 at 01:05:36PM -0400, Jason Gunthorpe wrote: > On Fri, Mar 10, 2023 at 05:39:22PM +0100, Eric Auger wrote: > > > > Also drop the unused arm_smmu_enable_nesting(). One following patche will > > > configure the correct smmu_domain->stage. > > > > > > Signed-off-by: Nicolin Chen > > > --- > > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 18 ------------------ > > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 1 - > > If you go this way you may also remove it from arm/arm-smmu/arm-smmu.c. > > Then if I am not wrong no other driver does implement enable_nesting cb. > > Shouldn't we also remove it and fellow iommu_enable_nesting()? > > Yes, lets just put this patch in the series please: > > https://lore.kernel.org/kvm/0-v1-0093c9b0e345+19-vfio_no_nesting_jgg@nvidia.com/ Oh. Didn't read this before sending my previous reply.. Will do that. Nic _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel