From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FE86C61DA4 for ; Sat, 11 Mar 2023 20:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4R0B2cu5femFkaEST2qjiOhQgpRZd7iNwtOa9ieoVvw=; b=Olzgqc2tikgJ3w kJvOwInBM5IH9BbtYqNCuBei5s4uycewGCv+hhE4MXodvmho4OGmBcyFZu2aYBQPHf/41y3NPvc4j yl3o2rqNYmVBilYhk1BpSwwqOdLqr/vD2hD5RqErOh80rKIS1MIBKWQ8KHX/wRl5URWSSq2PHqrce HBYeIPrcPCwCSgpy6fIBv+SmCUHpfh7FwMI2rMH8o6E2buLSl7u1tp9cFHeViMU0kM0qGK4ak4W4D nbm6ArJlVpv7Z425q7NFMK4oUT2oylodf2O8o891M288TYEwmH67PpLfgMeBE+kfWdhr1PZCbccHz pKlU94l9gK5Wd1qd0waQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pb5rk-001CGS-Mh; Sat, 11 Mar 2023 20:30:56 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pb5rg-001CFA-At; Sat, 11 Mar 2023 20:30:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eLT0g8df7rYJKk6srMN+2cPVnZ9SiqxI4tMkh+EKbMo=; b=iUx42NHgule7LbFVNnod+IFhFa 3qN42IDNyqQRllsJFaRM4ky8bNMMVQqgnBPhJz6kIPfU+k3CQpqlWCKfeU5CDinu7NmKvwe+IH/X5 fZyWoRJ5wESuKjnkTxUvA0HzCh8hJNpPlwkdvcC4iRs2WfJRT/SYogB6eu98W5QuvWd75OLW0aaEo 70OHY+Clm5QYxRgY5wq6g/u+zPa9pUgcfGjpBH8bECtgJ4wBsj1JP4hriCyHVu2yLJ5YHC1pV9ngW s+N0VDbxjq5HkyNVawyVcI7JqQ+WeOPtPr89/vxr5Y6hl9C5RJc8jIoGUjJbBRI5jau41He6NvnQO 8IvfgMZA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60470) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pb5rY-0000Pm-BR; Sat, 11 Mar 2023 20:30:44 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pb5rT-00060X-PH; Sat, 11 Mar 2023 20:30:39 +0000 Date: Sat, 11 Mar 2023 20:30:39 +0000 From: "Russell King (Oracle)" To: Frank Wunderlich Cc: Daniel Golle , Vladimir Oltean , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Vladimir Oltean , Florian Fainelli , Andrew Lunn , Jianhui Zhao , =?iso-8859-1?Q?Bj=F8rn?= Mork , Alexander Couzens Subject: Re: Re: [PATCH net-next v12 08/18] net: ethernet: mtk_eth_soc: fix 1000Base-X and 2500Base-X modes Message-ID: References: <20230308134642.cdxqw4lxtlgfsl4g@skbuf> <4B891976-C29E-4D98-B604-3AC4507D3661@public-files.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4B891976-C29E-4D98-B604-3AC4507D3661@public-files.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230311_123052_397166_BABBCED1 X-CRM114-Status: GOOD ( 12.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 11, 2023 at 09:21:47PM +0100, Frank Wunderlich wrote: > Am 11. M=E4rz 2023 21:00:20 MEZ schrieb "Russell King (Oracle)" : > >On Sat, Mar 11, 2023 at 01:05:37PM +0100, Frank Wunderlich wrote: > = > >> i got the 2.5G copper sfps, and tried them...they work well with the v= 12 (including this patch), but not in v13... = > = > >> how can we add a quirk to support this? > > > >Why does it need a quirk? > = > To disable the inband-mode for this 2.5g copper > sfp. But have not found a way to set a flag which i > can grab in phylink. We could make sfp_parse_support() set Autoneg, Pause, and Asym_Pause in "modes" at the top of that function, and then use the SFP modes quirk to clear the Autoneg bit for this SFP. Would that work for you? -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel