From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3C59C6FD20 for ; Fri, 24 Mar 2023 09:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AgQEzRQrhohz+HiVlAXO/PZJo9qCIS3BOkXsTJE7MfY=; b=FjXmCd9HijWn0z rJoqv4HAG3LuxrMjXlel9kZO7Gc5gu1QnFRdQnW/1Qb0TzsTCRejngE8QbSPh9Be1Yz2i+tiLSpPt PBomFaPd8FRDAVj5XeNgg6tviHsTI3ceSTaBD+A888z4cc9w6XiiqY23MIUlSdK/zqAFrhSe+cDEx XxwgQZsUDDN7InGpmi81VkzPyepSu4m0jbvXzbW2lHiuO3beFIHUoYAzr8Br80nhLPd4ML+jTXSUO s9ZdsD8/DEUnG7y4QduGNpyaRAe/C33Lyw/7ZWpxZasxPyR352N5qoYV9zq3YuLKElDzvSOrBu2we 53uiRS0AGnBTarldcCRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfdbt-0040Y8-0n; Fri, 24 Mar 2023 09:21:21 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfdbq-0040W6-1q for linux-arm-kernel@lists.infradead.org; Fri, 24 Mar 2023 09:21:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679649678; x=1711185678; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Zv6p5PxBUIwRGR/FQTKCtRGfcJDPVTzeoNo7mhbkHhY=; b=MdfGdpvRn5CFvBiZBQiYslZgmKQF8XN51/pri6Lo+eutTqIedJHeWQ1E OcaVc9jU3w/5j+Xu9qCSG9WdA+E6I7Qt241qtmQt61E6gwhPJUF9oTMQi SIMbSHrvTKqyfiC7cO8+Syb2gHlc2Df7VmU68p2vX24kdUpFqYSQRnX8r D73IJD8xltGXL+qzsUI3I+HRWLopsrZgDQc6RkJdIeuMoqU+n9+h+FWFJ RPIEn51vW72xoSx2E68qE6sBwgTF68erH10ZOTc7WVHZKrCtF8rmJf4Qp 3EJkuZVePcH9MYldOu9HWXgTyl0UjeazIBuDt3S9B+47VT6GdvSzUv9tr A==; X-IronPort-AV: E=McAfee;i="6600,9927,10658"; a="320129743" X-IronPort-AV: E=Sophos;i="5.98,287,1673942400"; d="scan'208";a="320129743" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Mar 2023 02:21:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10658"; a="771814725" X-IronPort-AV: E=Sophos;i="5.98,287,1673942400"; d="scan'208";a="771814725" Received: from smile.fi.intel.com ([10.237.72.54]) by FMSMGA003.fm.intel.com with ESMTP; 24 Mar 2023 02:20:59 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pfdbS-007qWb-1l; Fri, 24 Mar 2023 11:20:54 +0200 Date: Fri, 24 Mar 2023 11:20:54 +0200 From: Andy Shevchenko To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Mika Westerberg , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Michael Ellerman , Randy Dunlap , Arnd Bergmann , Niklas Schnelle , Bjorn Helgaas , "Rafael J. Wysocki" , Pali =?iso-8859-1?Q?Roh=E1r?= , "Maciej W. Rozycki" , Juergen Gross , Dominik Brodowski , linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xenproject.org, linux-acpi@vger.kernel.org, Miguel Ojeda , Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Thomas Bogendoerfer , Nicholas Piggin , Christophe Leroy , Anatolij Gustschin , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Bjorn Helgaas , Stefano Stabellini , Oleksandr Tyshchenko Subject: Re: [PATCH v7 6/6] PCI: Make use of pci_resource_n() Message-ID: References: <20230323173610.60442-1-andriy.shevchenko@linux.intel.com> <20230323173610.60442-7-andriy.shevchenko@linux.intel.com> <1722e75c-bc06-4a34-5e12-fa3622ed86a3@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1722e75c-bc06-4a34-5e12-fa3622ed86a3@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230324_022118_634320_64E361B8 X-CRM114-Status: GOOD ( 12.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 24, 2023 at 10:08:39AM +0100, Philippe Mathieu-Daud=E9 wrote: > On 23/3/23 18:36, Andy Shevchenko wrote: > > Replace open-coded implementations of pci_resource_n() in pci.h. ... > > #define pci_resource_n(dev, bar) (&(dev)->resource[(bar)]) > > -#define pci_resource_start(dev, bar) ((dev)->resource[(bar)].start) > > -#define pci_resource_end(dev, bar) ((dev)->resource[(bar)].end) > > -#define pci_resource_flags(dev, bar) ((dev)->resource[(bar)].flags) > > -#define pci_resource_len(dev,bar) \ > > - ((pci_resource_end((dev), (bar)) =3D=3D 0) ? 0 : \ > > - \ > > - (pci_resource_end((dev), (bar)) - \ > > - pci_resource_start((dev), (bar)) + 1)) > > +#define pci_resource_start(dev, bar) (pci_resource_n(dev, bar)->start) > > +#define pci_resource_end(dev, bar) (pci_resource_n(dev, bar)->end) > > +#define pci_resource_flags(dev, bar) (pci_resource_n(dev, bar)->flags) > > +#define pci_resource_len(dev,bar) \ > > + (pci_resource_end((dev), (bar)) ? \ > > + resource_size(pci_resource_n((dev), (bar))) : 0) > = > Seems (to me) more logical to have this patch as "PCI: Introduce > pci_resource_n()" ordered before your patch #2 "PCI: Introduce > pci_dev_for_each_resource()". Either way works for me. Bjorn, what do you like? > Here as #6 or as #2: > Reviewed-by: Philippe Mathieu-Daud=E9 Thank you! -- = With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel