From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A1C9C6FD20 for ; Fri, 24 Mar 2023 13:50:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=imYVwAJGRqAe/8/prW5bZCCQ1RjcvPWFv10d/C55EXE=; b=AdvKx0l/OgfsD1 evAy47d2cXV3WwRxOaAHX2MD1F5EmCsIByVYI/m3TA8dUiTwmg/1O3FjSQK/xd44D4wD5s2MKLbvT 0z9blPZw/KJRY+SMggDVMKz7tnSyBVuDZ0fKI6OHEH823yQxqnIUNY0AVQTXglPmHqOS7V8xYRqlW m+6W7ZeO3sG6fJpi960bSvdUiV/oaqQejMpDfkXR3cChRUlsw3P85xusXjlrNztCG5hXRwRQQNene BBvcBR1HIgY0nZDdiDgnbY8/XrfErO7NVRba/Gk5MjuwgeHdNkSZ/GTXzVc08m6899VfMYjVQDLqK hq7/VLilqvinntqddLFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfhnG-004X7w-2H; Fri, 24 Mar 2023 13:49:22 +0000 Received: from fudo.makrotopia.org ([2a07:2ec0:3002::71]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfhnB-004X6d-0v; Fri, 24 Mar 2023 13:49:18 +0000 Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1pfhmm-0006Oz-2c; Fri, 24 Mar 2023 14:48:52 +0100 Date: Fri, 24 Mar 2023 13:47:10 +0000 From: Daniel Golle To: Felix Fietkau Cc: Frank Wunderlich , Mark Lee , Sean Wang , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , John Crispin , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: Aw: Re: [BUG] MTK SoC Ethernet throughput TX only ~620Mbit/s since 6.2-rc1 Message-ID: References: <4a229d53-f058-115a-afc6-dd544a0dedf2@nbd.name> <4462a0c2-f7ea-c81c-e12f-ec629113fc40@nbd.name> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4462a0c2-f7ea-c81c-e12f-ec629113fc40@nbd.name> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230324_064917_325628_A660F2B5 X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Felix, Hi Frank, On Fri, Mar 24, 2023 at 12:52:09PM +0100, Felix Fietkau wrote: > On 18.03.23 14:07, Frank Wunderlich wrote: > > on BPI-R2 the eth0/gmac0 (tested with wan-port) is affected. here i have in TX-Direction only 620Mbit. > > > > I have no idea yet why there the gmac0 is affected and on r3 only gmac1. > > > > But it looks differently...on r3 the gmac1 is nearly completely broken. If it looks "completely broken" as in you see only kilobits or even complete starvation of RX, then you probably miss this fix: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=193250ace270fecd586dd2d0dfbd9cbd2ade977f > Please try this patch and let me know if it resolves the regression: > > --- > --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c > +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c > @@ -718,8 +718,6 @@ static void mtk_mac_link_up(struct phyli > break; > } > - mtk_set_queue_speed(mac->hw, mac->id, speed); > - > /* Configure duplex */ > if (duplex == DUPLEX_FULL) > mcr |= MAC_MCR_FORCE_DPX; > > I was about to suggest exactly this fix, and yes, it resolves the issue and now I see full 1 Gbit/s speed on both, switch ports (even while 100M connection is also used) and eth1 (via 1000Base-T SFP module). Thank you for taking care of this! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel