From: Mark Rutland <mark.rutland@arm.com>
To: Janne Grunau <j@jannau.net>, Will Deacon <will@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] drivers/perf: apple_m1: Add Apple M2 support
Date: Fri, 24 Mar 2023 14:00:34 +0000 [thread overview]
Message-ID: <ZB2tAqs/o/QSI4XD@FVFF77S0Q05N> (raw)
In-Reply-To: <20230214-apple_m2_pmu-v1-2-9c9213ab9b63@jannau.net>
On Tue, Feb 14, 2023 at 11:38:02AM +0100, Janne Grunau wrote:
> The PMU itself is compatible with the one found on M1. We still know
> next to nothing about the counters so keep using CPU uarch specific
> compatibles/PMU names.
>
> Signed-off-by: Janne Grunau <j@jannau.net>
Acked-by: Mark Rutland <mark.rutland@arm.com.
Will, I assume that you'll pick this up.
> ---
> drivers/perf/apple_m1_cpu_pmu.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/perf/apple_m1_cpu_pmu.c b/drivers/perf/apple_m1_cpu_pmu.c
> index 979a7c2b4f56..83b74c7fe63f 100644
> --- a/drivers/perf/apple_m1_cpu_pmu.c
> +++ b/drivers/perf/apple_m1_cpu_pmu.c
> @@ -559,7 +559,21 @@ static int m1_pmu_fire_init(struct arm_pmu *cpu_pmu)
> return m1_pmu_init(cpu_pmu);
> }
>
> +static int m2_pmu_avalanche_init(struct arm_pmu *cpu_pmu)
> +{
> + cpu_pmu->name = "apple_avalanche_pmu";
> + return m1_pmu_init(cpu_pmu);
> +}
> +
> +static int m2_pmu_blizzard_init(struct arm_pmu *cpu_pmu)
> +{
> + cpu_pmu->name = "apple_blizzard_pmu";
> + return m1_pmu_init(cpu_pmu);
> +}
> +
> static const struct of_device_id m1_pmu_of_device_ids[] = {
> + { .compatible = "apple,avalanche-pmu", .data = m2_pmu_avalanche_init, },
> + { .compatible = "apple,blizzard-pmu", .data = m2_pmu_blizzard_init, },
> { .compatible = "apple,icestorm-pmu", .data = m1_pmu_ice_init, },
> { .compatible = "apple,firestorm-pmu", .data = m1_pmu_fire_init, },
> { },
>
> --
> 2.39.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-24 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230214-apple_m2_pmu-v1-0-9c9213ab9b63@jannau.net>
2023-02-14 10:44 ` [PATCH 0/2] Apple M2 PMU support Hector Martin
[not found] ` <20230214-apple_m2_pmu-v1-1-9c9213ab9b63@jannau.net>
2023-02-15 20:46 ` [PATCH 1/2] dt-bindings: arm-pmu: Add PMU compatible strings for Apple M2 cores Rob Herring
[not found] ` <20230214-apple_m2_pmu-v1-2-9c9213ab9b63@jannau.net>
2023-03-24 14:00 ` Mark Rutland [this message]
2023-03-27 15:01 ` [PATCH 0/2] Apple M2 PMU support Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB2tAqs/o/QSI4XD@FVFF77S0Q05N \
--to=mark.rutland@arm.com \
--cc=asahi@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox